test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, XinfengX" <xinfengx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, XinfengX" <xinfengx.zhao@intel.com>
Subject: Re: [dts] [PATCH V1 1/3] framework: fix the issues of dts rerun error	and writing error
Date: Thu, 16 Jan 2020 08:58:17 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBAB915@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200115223300.21661-1-xinfengx.zhao@intel.com>

Applied the series

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xinfengx
> Sent: Thursday, January 16, 2020 6:33 AM
> To: dts@dpdk.org
> Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
> Subject: [dts] [PATCH V1 1/3] framework: fix the issues of dts rerun error and
> writing error
> 
> Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
> ---
>  framework/dts.py          | 1 +
>  framework/qemu_libvirt.py | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/dts.py b/framework/dts.py index 5941b37..afe44b4
> 100644
> --- a/framework/dts.py
> +++ b/framework/dts.py
> @@ -523,6 +523,7 @@ def run_all(config_file, pkgName, git, patch,
> skip_setup,
>      if verbose is True:
>          logger.set_verbose()
> 
> +    re_run = int(re_run)
>      if re_run < 0:
>          re_run = 0
> 
> diff --git a/framework/qemu_libvirt.py b/framework/qemu_libvirt.py index
> 5e34590..e0aeb6c 100644
> --- a/framework/qemu_libvirt.py
> +++ b/framework/qemu_libvirt.py
> @@ -788,11 +788,11 @@ class LibvirtKvm(VirtBase):
>          if os.path.exists(xml_file):
>              os.remove(xml_file)
>          self.root.write(xml_file)
> -        with open(xml_file, 'rb') as fp:
> +        with open(xml_file, 'r') as fp:
>              content = fp.read()
>          doc = minidom.parseString(content)
>          vm_content = doc.toprettyxml(indent='    ')
> -        with open(xml_file, 'wb') as fp:
> +        with open(xml_file, 'w') as fp:
>              fp.write(vm_content)
>          self.host_session.copy_file_to(xml_file)
>          time.sleep(2)
> --
> 2.17.1


      parent reply	other threads:[~2020-01-16  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 22:32 xinfengx
2020-01-15 22:32 ` [dts] [PATCH V1 2/3] nics: fix indentation error xinfengx
2020-01-15 22:33 ` [dts] [PATCH V1 3/3] tests: fix the statement errors that not supported by python3 xinfengx
2020-01-16  8:58 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBAB915@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xinfengx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).