test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Ma, LihongX" <lihongx.ma@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ma, LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V1] tests/unit_tests_pmd_perf: modify app cmd	according to dpdk change
Date: Thu, 13 Feb 2020 01:19:35 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBC670B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1581493388-86904-1-git-send-email-lihongx.ma@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of malihong
> Sent: Wednesday, February 12, 2020 3:43 PM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] tests/unit_tests_pmd_perf: modify app cmd
> according to dpdk change
> 
> Signed-off-by: malihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_unit_tests_pmd_perf.py | 29 +++++++-------------------
>  1 file changed, 7 insertions(+), 22 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_pmd_perf.py
> b/tests/TestSuite_unit_tests_pmd_perf.py
> index 6ecd993..2c932bb 100644
> --- a/tests/TestSuite_unit_tests_pmd_perf.py
> +++ b/tests/TestSuite_unit_tests_pmd_perf.py
> @@ -85,29 +85,14 @@ class TestUnitTestsPmdPerf(TestCase):
>          """
>          pass
> 
> -    def get_core_from_socket(self):
> -       """
> -       select  the port and lcores from same socket.
> -       """
> -
> -       out = self.dut.send_expect("./usertools/cpu_layout.py", "#", 10)
> -       k = re.search("Core 0 (.*)", out)
> -       socket_id = self.dut.ports_info[0]['port'].socket
> -       if socket_id == 0 or socket_id == -1:
> -          result = re.findall("(\d+)", k.group())
> -          return  int(result[0])
> -       else:
> -          result = re.findall("(\d+),", k.group())
> -          return  int(result[1])
> -
>      def test_pmd_burst(self):
>          """
>          Run pmd stream control mode burst test case.
>          """
> 
> -        self.core = self.get_core_from_socket()
> -        eal_params = self.dut.create_eal_parameters()
> -        self.dut.send_expect("./app/test/test %s --lcores='%d-%d'" %
> (eal_params,self.core, self.core + 1), "R.*T.*E.*>.*>", 60)
> +        socket_id = self.dut.ports_info[0]['port'].socket
> +        eal_params = self.dut.create_eal_parameters(socket=socket_id)
> +        self.dut.send_expect("./app/test/test %s" % (eal_params),
> + "R.*T.*E.*>.*>", 60)
>          for mode in self.burst_ctlmodes:
>              self.dut.send_expect("set_rxtx_sc %s" % mode, "RTE>>", 10)
>              out = self.dut.send_expect("pmd_perf_autotest", "RTE>>", 120) @@ -
> 124,18 +109,18 @@ class TestUnitTestsPmdPerf(TestCase):
>          Run pmd stream control mode continues test case.
>          """
> 
> -        self.core = self.get_core_from_socket()
>          self.table_header = ['Mode']
>          self.table_header += self.anchors
>          self.result_table_create(self.table_header)
> -        eal_params = self.dut.create_eal_parameters()
> +        socket_id = self.dut.ports_info[0]['port'].socket
> +        eal_params = self.dut.create_eal_parameters(socket=socket_id)
>          print((self.table_header))
> 
>          for mode in self.rxtx_modes:
>              if mode is "scalar":
> -                self.dut.send_expect("./app/test/test_scalar %s --lcores='%d-%d'" %
> (eal_params,self.core, self.core + 1), "R.*T.*E.*>.*>", 60)
> +                self.dut.send_expect("./app/test/test_scalar %s " %
> + (eal_params), "R.*T.*E.*>.*>", 60)
>              else:
> -                self.dut.send_expect("./app/test/test %s --lcores='%d-%d'" %
> (eal_params,self.core, self.core + 1), "R.*T.*E.*>.*>", 60)
> +                self.dut.send_expect("./app/test/test %s " %
> + (eal_params), "R.*T.*E.*>.*>", 60)
> 
>              table_row = [mode]
>              self.dut.send_expect("set_rxtx_sc continuous", "RTE>>", 10)
> --
> 2.17.2


      reply	other threads:[~2020-02-13  1:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12  7:43 malihong
2020-02-13  1:19 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBC670B@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).