From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>,
"Zhao, HaiyangX" <haiyangx.zhao@intel.com>,
"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, HaiyangX" <haiyangx.zhao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env
Date: Fri, 28 Feb 2020 02:50:57 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE3B8A@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <c3ef2f6ab94f4154888436855f08100a@intel.com>
As you said, it was required on 2M env, so it's not reasonable to remove it without any judgement.
> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Friday, February 28, 2020 10:37 AM
> To: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: RE: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove
> redundant parameter single-file-segments if not 2M env
>
> Hi, Lijuan
>
> I consulted lihong that single-file-segments parameter only required on virtio
> side in 2M env, vhost side doesn't need, so it's ok to remove it.
>
> Regards,
> Xiao Qimai
>
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> > Sent: Tuesday, February 25, 2020 5:01 PM
> > To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > Subject: Re: [dts] [PATCH
> > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > redundant parameter single-file-segments if not 2M env
> >
> > Remove single-file-segments, so what will happen, if 2M env ?
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> > > Sent: Tuesday, February 25, 2020 4:35 PM
> > > To: dts@dpdk.org
> > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > Subject: [dts] [PATCH
> > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > redundant parameter single-file-segments if not 2M env
> > >
> > > remove redundant parameter
> > >
> > > Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> > > ---
> > > tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/TestSuite_virtio_user_for_container_networking.py
> > > b/tests/TestSuite_virtio_user_for_container_networking.py
> > > index ba303b7..1f9a666 100644
> > > --- a/tests/TestSuite_virtio_user_for_container_networking.py
> > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
> > > command_line_user = 'docker run -i -t --privileged -v
> > > %s/vhost- net:/tmp/vhost-net ' + \
> > > '-v /mnt/huge:/dev/hugepages ' + \
> > > '-v %s:%s %s .%s/%s/app/testpmd -c %s -n %d ' + \
> > > - '-m 1024 --no-pci --file-prefix=container --single-file-
> > > segments ' + \
> > > + '-m 1024 --no-pci
> > > + --file-prefix=container ' + \
> > > '--
> > > vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-
> > net,queues=%d '
> > > + \
> > > '-- -i --rxq=%d --txq=%d --nb-cores=%d'
> > > command_line_user = command_line_user %
> > > (self.container_base_dir,
> > > --
> > > 1.8.3.1
next prev parent reply other threads:[~2020-02-28 2:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 8:34 Haiyang Zhao
2020-02-25 9:01 ` Tu, Lijuan
2020-02-28 2:36 ` Xiao, QimaiX
2020-02-28 2:50 ` Tu, Lijuan [this message]
2020-02-28 3:04 ` Wang, Yinan
2020-02-28 3:20 ` Xiao, QimaiX
2020-03-03 7:23 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBE3B8A@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=haiyangx.zhao@intel.com \
--cc=qimaix.xiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).