test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add	create_eal_parameters function.
Date: Tue, 3 Mar 2020 05:41:42 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE8F88@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1582708737-36706-7-git-send-email-shuaix.zhu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_user_4k_pages.py | 24 +++++++++------------
>  1 file changed, 10 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_4k_pages.py
> b/tests/TestSuite_pvp_virtio_user_4k_pages.py
> index 95b5494..5e6f657 100644
> --- a/tests/TestSuite_pvp_virtio_user_4k_pages.py
> +++ b/tests/TestSuite_pvp_virtio_user_4k_pages.py
> @@ -65,9 +65,7 @@ class TestPvpVirtioUser4kPages(TestCase):
>              self.core_config, socket=self.ports_socket)
>          self.core_list_virtio_user = self.core_list[0:2]
>          self.core_list_vhost_user = self.core_list[2:4]
> -        self.core_mask_virtio_user = utils.create_mask(self.core_list_virtio_user)
> -        self.core_mask_vhost_user =
> utils.create_mask(self.core_list_vhost_user)
> -        self.mem_channels = self.dut.get_memory_channels()
> +        self.pci_info = self.dut.ports_info[0]['pci']
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          self.frame_sizes = [64, 128, 256, 512, 1024, 1518]
>          self.logger.info("You can config packet_size in file %s.cfg," %
> self.suite_name + \ @@ -131,12 +129,11 @@ class
> TestPvpVirtioUser4kPages(TestCase):
>          """
>          Start testpmd on vhost
>          """
> -        command_line_client = "%s/app/testpmd -c %s -n %d " + \
> -                              "--file-prefix=vhost  -m 1024 --no-huge " + \
> -                              "--vdev 'net_vhost0,iface=vhost-net,queues=1' -- -i " + \
> -                              "--no-numa --socket-num=%d"
> -        command_line_client = command_line_client % (self.target,
> -                            self.core_mask_vhost_user, self.mem_channels,
> self.ports_socket)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " -m 1024 --no-huge --vdev 'net_vhost0,iface=vhost-
> net,queues=1'"
> +        para = " -- -i --no-numa --socket-num=%d" % self.ports_socket
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost_user,
> prefix='vhost', ports=[self.pci_info])
> +        command_line_client = testcmd + eal_params + vdev + para
>          self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
>          self.vhost_user.send_expect("start", "testpmd> ", 120)
> 
> @@ -144,11 +141,10 @@ class TestPvpVirtioUser4kPages(TestCase):
>          """
>          Start testpmd on virtio
>          """
> -        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
> -                            "--no-huge -m 1024 --file-prefix=virtio-user " + \
> -                            "--
> vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> -        command_line_user = command_line_user % (self.target,
> -                self.mem_channels, self.core_mask_virtio_user)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " --no-huge -m 1024 --
> vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_virtio_user,
> prefix='virtio-user', ports=[self.pci_info])
> +        command_line_user = testcmd + eal_params + vdev
>          self.virtio_user.send_expect(command_line_user, "testpmd> ", 120)
>          self.virtio_user.send_expect("set fwd mac", "testpmd> ", 120)
>          self.virtio_user.send_expect("start", "testpmd> ", 120)
> --
> 2.17.2


  parent reply	other threads:[~2020-03-03  5:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
2020-02-27  9:54   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan [this message]
2020-02-26  9:18 ` [dts] [PATCH V1] tests/virtio_pvp_regression:add " zhu,shuai
2020-02-27  9:51 ` [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " Zhu, ShuaiX
2020-03-03  5:29 ` Tu, Lijuan
2020-03-03  5:50   ` Zhu, ShuaiX
2020-03-03  7:42     ` Tu, Lijuan
2020-03-16  3:36       ` Wang, Yinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBE8F88@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=shuaix.zhu@intel.com \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).