test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg
@ 2020-02-26 18:00 lihong
  2020-02-27  1:32 ` Ma, LihongX
  2020-03-03  5:54 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: lihong @ 2020-02-26 18:00 UTC (permalink / raw)
  To: dts; +Cc: lihong

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/crb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/crb.py b/framework/crb.py
index 2ac197e..2bf99e1 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -472,7 +472,7 @@ class Crb(object):
         if the tester and dut on same server
         and pktgen is trex, do not kill the process
         """
-        if self.crb['pktgen'].lower() == 'trex':
+        if 'pktgen' in self.crb and (self.crb['pktgen'] is not None) and (self.crb['pktgen'].lower() == 'trex'):
             if self.crb['IP'] == self.crb['tester IP'] and self.trex_prefix is None:
                 conf_inst = PktgenConf('trex')
                 conf_info = conf_inst.load_pktgen_config()
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg
  2020-02-26 18:00 [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg lihong
@ 2020-02-27  1:32 ` Ma, LihongX
  2020-03-03  5:54 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Ma, LihongX @ 2020-02-27  1:32 UTC (permalink / raw)
  To: dts

Tested-by: ma,lihong<lihongx.ma@intel.com>

Regards,
Ma,lihong


-----Original Message-----
From: Ma, LihongX 
Sent: Thursday, February 27, 2020 2:01 AM
To: dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts][PATCH V1] framework/crb: add check key of pktgen in crb.cfg

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/crb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/crb.py b/framework/crb.py index 2ac197e..2bf99e1 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -472,7 +472,7 @@ class Crb(object):
         if the tester and dut on same server
         and pktgen is trex, do not kill the process
         """
-        if self.crb['pktgen'].lower() == 'trex':
+        if 'pktgen' in self.crb and (self.crb['pktgen'] is not None) and (self.crb['pktgen'].lower() == 'trex'):
             if self.crb['IP'] == self.crb['tester IP'] and self.trex_prefix is None:
                 conf_inst = PktgenConf('trex')
                 conf_info = conf_inst.load_pktgen_config()
--
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg
  2020-02-26 18:00 [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg lihong
  2020-02-27  1:32 ` Ma, LihongX
@ 2020-03-03  5:54 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-03-03  5:54 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Thursday, February 27, 2020 2:01 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/crb.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/crb.py b/framework/crb.py index 2ac197e..2bf99e1
> 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -472,7 +472,7 @@ class Crb(object):
>          if the tester and dut on same server
>          and pktgen is trex, do not kill the process
>          """
> -        if self.crb['pktgen'].lower() == 'trex':
> +        if 'pktgen' in self.crb and (self.crb['pktgen'] is not None) and
> (self.crb['pktgen'].lower() == 'trex'):
>              if self.crb['IP'] == self.crb['tester IP'] and self.trex_prefix is None:
>                  conf_inst = PktgenConf('trex')
>                  conf_info = conf_inst.load_pktgen_config()
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-03  5:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 18:00 [dts] [PATCH V1] framework/crb: add check key of pktgen in crb.cfg lihong
2020-02-27  1:32 ` Ma, LihongX
2020-03-03  5:54 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).