test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V2] tests/pvp_virtio_user_2M_hugepages:add	create_eal_parameters function.
Date: Tue, 3 Mar 2020 07:24:39 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE929D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1582853558-66855-3-git-send-email-shuaix.zhu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Friday, February 28, 2020 9:33 AM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V2] tests/pvp_virtio_user_2M_hugepages:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  .../TestSuite_pvp_virtio_user_2M_hugepages.py | 23 ++++++++-----------
>  1 file changed, 9 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
> b/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
> index 5531e0b..9d2eaed 100644
> --- a/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
> +++ b/tests/TestSuite_pvp_virtio_user_2M_hugepages.py
> @@ -61,9 +61,6 @@ class TestPVPVirtioWith2Mhuge(TestCase):
> 
>          self.core_list_virtio_user = self.core_list[0:2]
>          self.core_list_vhost_user = self.core_list[2:4]
> -        self.core_mask_virtio_user = utils.create_mask(self.core_list_virtio_user)
> -        self.core_mask_vhost_user =
> utils.create_mask(self.core_list_vhost_user)
> -        self.mem_channels = self.dut.get_memory_channels()
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          self.header_size = HEADER_SIZE['eth'] + HEADER_SIZE['ip'] +
> HEADER_SIZE['tcp']
>          self.frame_sizes = [64, 128, 256, 512, 1024, 1518] @@ -77,6 +74,7 @@
> class TestPVPVirtioWith2Mhuge(TestCase):
>              self.tester.send_expect('mkdir -p %s' % self.out_path, '# ')
>          # create an instance to set stream field setting
>          self.pktgen_helper = PacketGeneratorHelper()
> +        self.pci_info = self.dut.ports_info[0]['pci']
> 
>      def set_up(self):
>          """
> @@ -129,11 +127,10 @@ class TestPVPVirtioWith2Mhuge(TestCase):
>          """
>          start testpmd on vhost
>          """
> -        command_line_client = "%s/app/testpmd -c %s -n %d " + \
> -                              "--socket-mem 1024,1024 --file-prefix=vhost " + \
> -                              "--vdev 'net_vhost0,iface=vhost-net,queues=1' -- -i"
> -        command_line_client = command_line_client % (self.target,
> -                        self.core_mask_vhost_user, self.mem_channels)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = [r"'net_vhost0,iface=vhost-net,queues=1'"]
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost_user,
> prefix='vhost', ports=[self.pci_info], vdevs=vdev)
> +        command_line_client = testcmd + eal_params + " -- -i"
>          self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
>          self.vhost_user.send_expect("start", "testpmd> ", 120)
> 
> @@ -141,12 +138,10 @@ class TestPVPVirtioWith2Mhuge(TestCase):
>          """
>          start testpmd on virtio
>          """
> -        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
> -                            "--no-pci --socket-mem 1024,1024 " + \
> -                            "--file-prefix=virtio-user --single-file-segments " + \
> -                            "--
> vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> -        command_line_user = command_line_user % (self.target,
> -                self.mem_channels, self.core_mask_virtio_user)
> +        testcmd = self.dut.target + "/app/testpmd "
> +        vdev = " --single-file-segments --
> vdev=net_virtio_user0,mac=00:11:22:33:44:10,path=./vhost-net,queues=1 --
> -i"
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_virtio_user, no_pci=True,
> prefix='virtio-user', ports=[self.pci_info])
> +        command_line_user = testcmd + eal_params + vdev
>          self.virtio_user.send_expect(command_line_user, "testpmd> ", 120)
>          self.virtio_user.send_expect("start", "testpmd> ", 120)
> 
> --
> 2.17.2


  parent reply	other threads:[~2020-03-03  7:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28  1:32 [dts] [PATCH V2] tests/pvp_diff_qemu_version:add " zhu,shuai
2020-02-28  1:30 ` Zhu, ShuaiX
2020-02-28  1:32 ` [dts] [PATCH V2] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
2020-02-28  1:32   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` [dts] [PATCH V2] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
2020-02-28  1:32   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan [this message]
2020-02-28  1:32 ` [dts] [PATCH V2] tests/virtio_pvp_regression:add " zhu,shuai
2020-02-28  1:31   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` [dts] [PATCH V2] tests/virtio_user_as_exceptional_path:add " zhu,shuai
2020-02-28  1:34   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan
2020-02-28  1:32 ` [dts] [PATCH V2] tests/vm2vm_virtio_pmd:add " zhu,shuai
2020-02-28  1:35   ` Zhu, ShuaiX
2020-03-03  7:24   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBE929D@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=shuaix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).