test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]shutdown_api: fix scapy cmd error
Date: Mon, 20 Apr 2020 05:24:11 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC0D322@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1587113327-302161-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Friday, April 17, 2020 4:49 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]shutdown_api: fix scapy cmd error
> 
> *. mac addr should be enclosed in quotation marks
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 8661863..b5c0d5a 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -709,7 +709,7 @@ class TestShutdownApi(TestCase):
>          tgenInput = []
>          for port in self.ports:
>              dmac=self.dut.get_mac_address(port)
> -
> self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src="02:00:00:00:00:
> 0%d",dst=%s)/IP()/UDP()/()])'% (port, port, dmac))
> +
> + self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src="02:00:00:00
> + :00:0%d",dst="%s")/IP()/UDP()/()])'% (port, port, dmac))
>              tgenInput.append((self.tester.get_local_port(port),
> self.tester.get_local_port(port), "test%d.pcap" % port))
>          for _ in range(stress_iterations):
>              self.dut.send_expect("port stop all", "testpmd> ", 100)
> --
> 1.8.3.1


      reply	other threads:[~2020-04-20  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17  8:48 Xiao Qimai
2020-04-20  5:24 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC0D322@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).