From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C551FA0561; Mon, 20 Apr 2020 07:24:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD10D1D14C; Mon, 20 Apr 2020 07:24:17 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D9A291C293 for ; Mon, 20 Apr 2020 07:24:15 +0200 (CEST) IronPort-SDR: JciQTskkPfZlHD3mWPQ0wNvGx+QAjAD4KFR1WfEhEu+Xg99nbl0bqpUKSC1Pu0SiaSnzXJ06s8 Xc+MsyyuHCUg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2020 22:24:14 -0700 IronPort-SDR: HMnSaNmGewl+Be2vwv2BopyHViaHP38nF4Z3HLych6m+S7dRIoIqTXhzXlbt4tOuVWgMuVzk0p 034nYvW9ZOAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,405,1580803200"; d="scan'208";a="333807051" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 19 Apr 2020 22:24:14 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 22:24:14 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 22:24:14 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.191]) with mapi id 14.03.0439.000; Mon, 20 Apr 2020 13:24:12 +0800 From: "Tu, Lijuan" To: "Xiao, QimaiX" , "dts@dpdk.org" CC: "Xiao, QimaiX" Thread-Topic: [dts] [PATCH V1]shutdown_api: fix scapy cmd error Thread-Index: AQHWFJX6FjpQ9bV2Z0SfetY7TRfLS6iBfqVA Date: Mon, 20 Apr 2020 05:24:11 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC0D322@SHSMSX101.ccr.corp.intel.com> References: <1587113327-302161-1-git-send-email-qimaix.xiao@intel.com> In-Reply-To: <1587113327-302161-1-git-send-email-qimaix.xiao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]shutdown_api: fix scapy cmd error X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai > Sent: Friday, April 17, 2020 4:49 PM > To: dts@dpdk.org > Cc: Xiao, QimaiX > Subject: [dts] [PATCH V1]shutdown_api: fix scapy cmd error >=20 > *. mac addr should be enclosed in quotation marks >=20 > Signed-off-by: Xiao Qimai > --- > tests/TestSuite_shutdown_api.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py index 8661863..b5c0d5a 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -709,7 +709,7 @@ class TestShutdownApi(TestCase): > tgenInput =3D [] > for port in self.ports: > dmac=3Dself.dut.get_mac_address(port) > - > self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src=3D"02:00:00:00:= 00: > 0%d",dst=3D%s)/IP()/UDP()/()])'% (port, port, dmac)) > + > + self.tester.scapy_append('wrpcap("test%d.pcap",[Ether(src=3D"02:00:00:0= 0 > + :00:0%d",dst=3D"%s")/IP()/UDP()/()])'% (port, port, dmac)) > tgenInput.append((self.tester.get_local_port(port), > self.tester.get_local_port(port), "test%d.pcap" % port)) > for _ in range(stress_iterations): > self.dut.send_expect("port stop all", "testpmd> ", 100) > -- > 1.8.3.1