test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1 3/3]virtio_user_as_exceptional_path: set test nic	to driver specified in cfg
Date: Mon, 27 Apr 2020 07:51:36 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC12B14@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1587897525-114547-4-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Sunday, April 26, 2020 6:39 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1 3/3]virtio_user_as_exceptional_path: set test nic to
> driver specified in cfg
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_virtio_user_as_exceptional_path.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_virtio_user_as_exceptional_path.py
> b/tests/TestSuite_virtio_user_as_exceptional_path.py
> index 470e0de..35a0a98 100644
> --- a/tests/TestSuite_virtio_user_as_exceptional_path.py
> +++ b/tests/TestSuite_virtio_user_as_exceptional_path.py
> @@ -48,6 +48,7 @@ class TestVirtioUserAsExceptionalPath(TestCase):
>          # Get and verify the ports
>          self.dut_ports = self.dut.get_ports()
>          self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
> +        self.def_driver =
> self.dut.ports_info[self.dut_ports[0]]['port'].get_nic_driver()
>          self.pci0 = self.dut.ports_info[0]['pci']
>          pf_info = self.dut_ports[0]
>          netdev = self.dut.ports_info[pf_info]['port']
> @@ -96,9 +97,8 @@ class TestVirtioUserAsExceptionalPath(TestCase):
>          for i in self.dut_ports:
>              port = self.dut.ports_info[i]['port']
>              port.bind_driver()
> -        self.dut.send_expect(
> -            "./usertools/dpdk-devbind.py -b igb_uio %s" %
> -            self.pci, '#', 30)
> +        bind_script_path = self.dut.get_dpdk_bind_script()
> +        self.dut.send_expect('%s --bind=%s %s' % (bind_script_path,
> self.def_driver, self.pci), '# ')
>          self.peer_pci_setup = True
> 
>      def launch_testpmd_vhost(self):
> --
> 1.8.3.1


      reply	other threads:[~2020-04-27  7:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 10:38 [dts] [PATCH V1 0/3] bind " Xiao Qimai
2020-04-26 10:38 ` [dts] [PATCH V1 1/3]dpdk_gro_lib: set " Xiao Qimai
2020-04-27  7:51   ` Tu, Lijuan
2020-04-26 10:38 ` [dts] [PATCH V1 2/3]dpdk_gso_lib: " Xiao Qimai
2020-04-27  7:51   ` Tu, Lijuan
2020-04-26 10:38 ` [dts] [PATCH V1 3/3]virtio_user_as_exceptional_path: " Xiao Qimai
2020-04-27  7:51   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC12B14@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).