test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH v1] test_plans: update case due to virtio path selection logic change in loopback_multi_paths_port_restart_test_plan.rst
@ 2020-04-28 19:02 Yinan
  2020-05-06  3:14 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Yinan @ 2020-04-28 19:02 UTC (permalink / raw)
  To: dts; +Cc: Wang Yinan

From: Wang Yinan <yinan.wang@intel.com>

Signed-off-by: Wang Yinan <yinan.wang@intel.com>
---
 ...loopback_multi_paths_port_restart_test_plan.rst | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/test_plans/loopback_multi_paths_port_restart_test_plan.rst b/test_plans/loopback_multi_paths_port_restart_test_plan.rst
index 4e5c886..3da94ad 100644
--- a/test_plans/loopback_multi_paths_port_restart_test_plan.rst
+++ b/test_plans/loopback_multi_paths_port_restart_test_plan.rst
@@ -38,10 +38,6 @@ This test plan includes split virtqueue mergeable, non-mergeable, vectorized_rx,
 inorder mergeable, inorder non-mergeable path, and packed virtqueue mergeable,
 non-mergeable,inorder mergeable, inorder non-mergeable, vectorized path test.
 Also test port restart and only send one packet each time using testpmd.
-Note: Packed virtqueue vectorized path need below three initial requirements:
-    1. AVX512 is allowed in config file and supported by compiler
-    2. Host cpu support AVX512F
-    3. ring size is power of two
 
 Test Case 1: loopback test with packed ring mergeable path
 ==========================================================
@@ -180,7 +176,7 @@ Test Case 4: loopback test with packed ring inorder non-mergeable path
 
     ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
     --legacy-mem --no-pci --file-prefix=virtio \
-    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_vq=1,mrg_rxbuf=0,in_order=1,packed_vec=1 \
+    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_vq=1,mrg_rxbuf=0,in_order=1,vectorized=1 \
     -- -i --rx-offloads=0x10 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --txd=1024 --rxd=1024
     >set fwd mac
     >start
@@ -344,8 +340,8 @@ Test Case 8: loopback test with split ring non-mergeable path
 
     ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
     --legacy-mem --no-pci --file-prefix=virtio \
-    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_order=0,mrg_rxbuf=0 \
-    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --txd=1024 --rxd=1024
+    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_order=0,mrg_rxbuf=0,vectorized=1 \
+    -- -i --rx-offloads=0x10 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --txd=1024 --rxd=1024
     >set fwd mac
     >start
 
@@ -385,7 +381,7 @@ Test Case 9: loopback test with split ring vector_rx path
 
     ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
     --legacy-mem --no-pci --file-prefix=virtio \
-    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_order=0,mrg_rxbuf=0 \
+    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_order=0,mrg_rxbuf=0,vectorized=1 \
     -- -i --nb-cores=1 --txd=1024 --rxd=1024
     >set fwd mac
     >start
@@ -425,7 +421,7 @@ Test Case 10: loopback test with packed ring vectorized path
 2. Launch virtio-user by below command::
 
     ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
-    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_vq=1,in_order=0,mrg_rxbuf=0,packed_vec=1 \
+    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_vq=1,in_order=0,mrg_rxbuf=0,vectorized=1 \
     -- -i --nb-cores=1 --txd=1024 --rxd=1024
     >set fwd mac
     >start
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH v1] test_plans: update case due to virtio path selection logic change in loopback_multi_paths_port_restart_test_plan.rst
  2020-04-28 19:02 [dts] [PATCH v1] test_plans: update case due to virtio path selection logic change in loopback_multi_paths_port_restart_test_plan.rst Yinan
@ 2020-05-06  3:14 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-05-06  3:14 UTC (permalink / raw)
  To: Wang, Yinan, dts; +Cc: Wang, Yinan

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yinan
> Sent: Wednesday, April 29, 2020 3:03 AM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: [dts] [PATCH v1] test_plans: update case due to virtio path selection
> logic change in loopback_multi_paths_port_restart_test_plan.rst
> 
> From: Wang Yinan <yinan.wang@intel.com>
> 
> Signed-off-by: Wang Yinan <yinan.wang@intel.com>
> ---
>  ...loopback_multi_paths_port_restart_test_plan.rst | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/test_plans/loopback_multi_paths_port_restart_test_plan.rst
> b/test_plans/loopback_multi_paths_port_restart_test_plan.rst
> index 4e5c886..3da94ad 100644
> --- a/test_plans/loopback_multi_paths_port_restart_test_plan.rst
> +++ b/test_plans/loopback_multi_paths_port_restart_test_plan.rst
> @@ -38,10 +38,6 @@ This test plan includes split virtqueue mergeable, non-
> mergeable, vectorized_rx,  inorder mergeable, inorder non-mergeable path,
> and packed virtqueue mergeable,
>  non-mergeable,inorder mergeable, inorder non-mergeable, vectorized
> path test.
>  Also test port restart and only send one packet each time using testpmd.
> -Note: Packed virtqueue vectorized path need below three initial
> requirements:
> -    1. AVX512 is allowed in config file and supported by compiler
> -    2. Host cpu support AVX512F
> -    3. ring size is power of two
> 
>  Test Case 1: loopback test with packed ring mergeable path
> ==========================================================
> @@ -180,7 +176,7 @@ Test Case 4: loopback test with packed ring inorder
> non-mergeable path
> 
>      ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
>      --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=0,in_order=1,packed_vec=1 \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_
> + vq=1,mrg_rxbuf=0,in_order=1,vectorized=1 \
>      -- -i --rx-offloads=0x10 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
>      >set fwd mac
>      >start
> @@ -344,8 +340,8 @@ Test Case 8: loopback test with split ring non-
> mergeable path
> 
>      ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
>      --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0 \
> -    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0,vectorized=1 \
> +    -- -i --rx-offloads=0x10 --enable-hw-vlan-strip --rss-ip
> + --nb-cores=1 --txd=1024 --rxd=1024
>      >set fwd mac
>      >start
> 
> @@ -385,7 +381,7 @@ Test Case 9: loopback test with split ring vector_rx
> path
> 
>      ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
>      --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0 \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_orde
> + r=0,mrg_rxbuf=0,vectorized=1 \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      >set fwd mac
>      >start
> @@ -425,7 +421,7 @@ Test Case 10: loopback test with packed ring
> vectorized path  2. Launch virtio-user by below command::
> 
>      ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,in_order=0,mrg_rxbuf=0,packed_vec=1 \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_
> + vq=1,in_order=0,mrg_rxbuf=0,vectorized=1 \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      >set fwd mac
>      >start
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-06  3:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 19:02 [dts] [PATCH v1] test_plans: update case due to virtio path selection logic change in loopback_multi_paths_port_restart_test_plan.rst Yinan
2020-05-06  3:14 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).