test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]pvp_virtio_user_multi_queues_port_restart: update	script to test virtio new path
Date: Wed, 6 May 2020 03:16:17 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC21E28@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1588126073-292482-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Wednesday, April 29, 2020 10:08 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]pvp_virtio_user_multi_queues_port_restart: update
> script to test virtio new path
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  ...te_pvp_virtio_user_multi_queues_port_restart.py | 31 +++++++++-----------
> --
>  1 file changed, 12 insertions(+), 19 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_multi_queues_port_restart.py
> b/tests/TestSuite_pvp_virtio_user_multi_queues_port_restart.py
> index 58d603f..d948e15 100644
> --- a/tests/TestSuite_pvp_virtio_user_multi_queues_port_restart.py
> +++ b/tests/TestSuite_pvp_virtio_user_multi_queues_port_restart.py
> @@ -98,21 +98,14 @@ class
> TestPVPVirtioUserMultiQueuesPortRestart(TestCase):
>          self.vhost.send_expect("set fwd mac", "testpmd> ", 120)
>          self.vhost.send_expect("start", "testpmd> ", 120)
> 
> -    def start_virtio_user_testpmd(self, flag):
> +    def start_virtio_user_testpmd(self, vdevs, vector_flag=False):
>          """
>          start testpmd in vm depend on different path
>          """
>          testcmd = self.dut.target + "/app/testpmd "
> -        vdev = 'net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,queues=2'
> -        if 'packed_ring' in flag:
> -            vdev += ',packed_vq=1'
> -        if 'nonmergeable' in flag or 'vector' in flag:
> -            vdev += ',mrg_rxbuf=0'
> -        if 'inorder' not in flag:
> -            vdev += ',in_order=0'
>          eal_params = self.dut.create_eal_parameters(cores=self.core_list[5:8],
> prefix='virtio', no_pci=True,
> -                                                    vdevs=[vdev])
> -        if 'vector' not in flag:
> +                                                    vdevs=[vdevs])
> +        if vector_flag:
>              para = " -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-
> cores=2 --rxq=%s --txq=%s --rss-ip" % (
>              self.queue_number, self.queue_number)
>          else:
> @@ -219,63 +212,63 @@ class
> TestPVPVirtioUserMultiQueuesPortRestart(TestCase):
> 
>      def test_perf_pvp_2queues_test_with_packed_ring_mergeable_path(self):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="packed_ring_mergeable")
> +
> self.start_virtio_user_testpmd(vdevs='net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-
> net,queues=2,packed_vq=1,mrg_rxbuf=1,in_order=0,queue_size=255')
>          self.send_and_verify("packed_ring_mergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def
> test_perf_pvp_2queues_test_with_packed_ring_nonmergeable_path(self):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="packed_ring_nonmergeable")
> +
> self.start_virtio_user_testpmd(vdevs='net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-
> net,queues=2,packed_vq=1,mrg_rxbuf=0,in_order=0,queue_size=255')
>          self.send_and_verify("packed_ring_nonmergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def
> test_perf_pvp_2queues_test_with_split_ring_inorder_mergeable_path(self):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="split_ring_inorder_mergeable")
> +
> self.start_virtio_user_testpmd(vdevs='net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-net,queues=2,in_order=1,mrg_rxbuf=1')
>          self.send_and_verify("split_ring_inorder_mergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def
> test_perf_pvp_2queues_test_with_split_ring_inorder_nonmergeable_path(s
> elf):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="split_ring_inorder_nonmergeable")
> +
> self.start_virtio_user_testpmd(vdevs='net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-net,queues=2,in_order=1,mrg_rxbuf=0,vectorized=1')
>          self.send_and_verify("split_ring_inorder_nonmergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def test_perf_pvp_2queues_test_with_split_ring_mergeable_path(self):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="split_ring_mergeable")
> +
> self.start_virtio_user_testpmd(vdevs='net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-net,queues=2,in_order=0,mrg_rxbuf=1')
>          self.send_and_verify("split_ring_mergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def
> test_perf_pvp_2queues_test_with_split_ring_nonmergeable_path(self):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="split_ring_nonmergeable")
> +
> self.start_virtio_user_testpmd(vdevs='net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-net,queues=2,in_order=0,mrg_rxbuf=0,vectorized=1')
>          self.send_and_verify("split_ring_nonmergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def test_perf_pvp_2queues_test_with_split_ring_vector_rx_path(self):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="split_ring_vector_rx")
> +
> self.start_virtio_user_testpmd(vdevs="net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-
> net,queues=2,packed_vq=1,mrg_rxbuf=1,in_order=1,queue_size=255",
> vector_flag=True)
>          self.send_and_verify("split_ring_vector_rx")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def
> test_perf_pvp_2queues_test_with_packed_ring_inorder_mergeable_path(se
> lf):
>          self.start_vhost_testpmd()
> -        self.start_virtio_user_testpmd(flag="packed_ring_inorder_mergeable")
> +
> self.start_virtio_user_testpmd(vdevs="net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-
> net,queues=2,packed_vq=1,mrg_rxbuf=0,in_order=1,vectorized=1,queue_siz
> e=255")
>          self.send_and_verify("packed_ring_inorder_mergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> 
>      def
> test_perf_pvp_2queues_test_with_packed_ring_inorder_nonmergeable_pat
> h(self):
>          self.start_vhost_testpmd()
> -
> self.start_virtio_user_testpmd(flag="packed_ring_inorder_nonmergeable")
> +
> self.start_virtio_user_testpmd(vdevs="net_virtio_user0,mac=00:01:02:03:04:
> 05,path=./vhost-
> net,queues=2,packed_vq=1,mrg_rxbuf=0,in_order=1,vectorized=1,queue_siz
> e=255")
>          self.send_and_verify("packed_ring_inorder_nonmergeable")
>          self.close_all_testpmd()
>          self.result_table_print()
> --
> 1.8.3.1


      parent reply	other threads:[~2020-05-06  3:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  2:07 Xiao Qimai
2020-04-29  2:16 ` Xiao, QimaiX
2020-05-06  3:16 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC21E28@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).