test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Wang, Yinan" <yinan.wang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>
Subject: Re: [dts] [PATCH v1] tests: turn off server mode option since dpdk code	change in TestSuite_vhost_dequeue_zero_copy.py
Date: Mon, 1 Jun 2020 03:12:56 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC565ED@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200525010237.66586-1-yinan.wang@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yinan
> Sent: Monday, May 25, 2020 9:03 AM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: [dts] [PATCH v1] tests: turn off server mode option since dpdk code
> change in TestSuite_vhost_dequeue_zero_copy.py
> 
> From: Wang Yinan <yinan.wang@intel.com>
> 
> Signed-off-by: Wang Yinan <yinan.wang@intel.com>
> ---
>  tests/TestSuite_vhost_dequeue_zero_copy.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_vhost_dequeue_zero_copy.py
> b/tests/TestSuite_vhost_dequeue_zero_copy.py
> index 8fca47a..500204b 100644
> --- a/tests/TestSuite_vhost_dequeue_zero_copy.py
> +++ b/tests/TestSuite_vhost_dequeue_zero_copy.py
> @@ -363,7 +363,7 @@ class TestVhostDequeueZeroCopy(TestCase):
>              value_without_zero_copy = self.big_pkt_record['dequeue-zero-
> copy=0']
>          self.verify(value_with_zero_copy != 0 and value_without_zero_copy != 0,
>                  'can not get the value of big pkts, please check self.frame_sizes')
> -        self.verify(value_with_zero_copy - value_without_zero_copy >=
> value_with_zero_copy*0.1,
> +        self.verify(value_with_zero_copy - value_without_zero_copy >=
> + value_with_zero_copy*0.05,
>                  'the drop with dequeue-zero-copy=0 is not as expected')
> 
>      def close_all_testpmd_and_vm(self):
> @@ -447,7 +447,7 @@ class TestVhostDequeueZeroCopy(TestCase):
>          self.nb_cores = 4
>          self.queue_number = 16
>          self.prepare_test_evn(vhost_txfreet_mode='normal',
> vhost_zero_copy=True,
> -                    vhost_client_mode=True, vm_testpmd_fwd_mode='rxonly',
> packed_mode=False)
> +                    vhost_client_mode=False,
> + vm_testpmd_fwd_mode='rxonly', packed_mode=False)
>          self.send_and_verify_throughput(cycle="before relaunch",
> fwd_mode="rxonly")
> 
>          # relaunch testpmd at virtio side in VM for driver reloading @@ -462,7
> +462,7 @@ class TestVhostDequeueZeroCopy(TestCase):
>          self.nb_cores = 4
>          self.queue_number = 16
>          self.prepare_test_evn(vhost_txfreet_mode='normal',
> vhost_zero_copy=True,
> -                    vhost_client_mode=True, vm_testpmd_fwd_mode='rxonly',
> packed_mode=True)
> +                    vhost_client_mode=False,
> + vm_testpmd_fwd_mode='rxonly', packed_mode=True)
>          self.send_and_verify_throughput(cycle="before relaunch",
> fwd_mode="rxonly")
> 
>          # relaunch testpmd at virtio side in VM for driver reloading @@ -477,7
> +477,7 @@ class TestVhostDequeueZeroCopy(TestCase):
>          self.nb_cores = 4
>          self.queue_number = 16
>          self.prepare_test_evn(vhost_txfreet_mode='maximum',
> vhost_zero_copy=True,
> -                    vhost_client_mode=True, vm_testpmd_fwd_mode='mac',
> packed_mode=False)
> +                    vhost_client_mode=False, vm_testpmd_fwd_mode='mac',
> + packed_mode=False)
>          self.send_and_verify_throughput(cycle='dequeue-zero-copy=1')
>          self.result_table_print()
> 
> --
> 2.17.1


      reply	other threads:[~2020-06-01  3:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  1:02 Yinan
2020-06-01  3:12 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC565ED@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).