test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhang, XiX" <xix.zhang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhang, XiX" <xix.zhang@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_kni:Modify ping6 mode to adapt to	the higher version of Ping
Date: Thu, 11 Jun 2020 12:08:39 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC5BB87@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1591239424-10425-1-git-send-email-xix.zhang@intel.com>

Applied, thanks

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of xizhan4x
Sent: 2020年6月4日 10:57
To: dts@dpdk.org
Cc: Zhang, XiX <xix.zhang@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_kni:Modify ping6 mode to adapt to the higher version of Ping


Modify ping6 mode to adapt to the higher version of Ping 

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_kni.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index d518f3e..8f95e75 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -613,8 +613,8 @@ class TestKni(TestCase):
             self.tester.send_expect("ifconfig %s up" % tx_interface, "# ")
             out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
                                        (v_intf_ip, str(ipv6_address)), "# ", 10)
-            out1 = self.dut.send_expect("ping6 -w 1 -I %s %s" %
-                                       (virtual_interface, str(ipv6_address)), "# ", 10)
+            out1 = self.dut.send_expect("ping6 -w 1  %s%%%s" %
+                                       
+ (str(ipv6_address),virtual_interface), "# ", 10)
             # FC25 ping6 output info is "64 bytes from ipv6_address%v: icmp_seq=1 ttl=64"
             # other os ping6 output is "64 bytes from ipv6_address: icmp_seq=1 ttl=64"
             expected_str = "64 bytes from %s" % ipv6_address @@ -623,7 +623,7 @@ class TestKni(TestCase):
             out = self.tester.send_expect(
                 "ping6 -w 1 -I %s %s" % (tx_intf_ip, str(ipv6_address)), "# ", 10)
             out1 = self.tester.send_expect(
-                "ping6 -w 1 -I %s %s" % (tx_interface, str(ipv6_address)), "# ", 10)
+                "ping6 -w 1 %s%%%s" % (str(ipv6_address),tx_interface), 
+ "# ", 10)
             expected_str = "64 bytes from %s" % ipv6_address
             self.verify(any([expected_str in out, expected_str in out1]),
                         "kni cannot reply ping6 packet") @@ -637,8 +637,8 @@ class TestKni(TestCase):
 
             out = self.dut.send_expect("ping6 -w 1 -I %s %s" %
                                        (v_intf_ip, ''.join(ipv6list)), "# ", 10)
-            out1 = self.dut.send_expect("ping6 -w 1 -I %s %s" %
-                                       (virtual_interface, ''.join(ipv6list)), "# ", 10)
+            out1 = self.dut.send_expect("ping6 -w 1 %s%%%s" %
+                                       
+ (''.join(ipv6list),virtual_interface), "# ", 10)
             expected_str = "0 received, 100% packet loss"
             self.verify(any([expected_str in out, expected_str in out1]),
                         "ping6 not supported")
--
2.17.2


      parent reply	other threads:[~2020-06-11 12:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  2:57 xizhan4x
2020-06-04  3:02 ` Zhang, XiX
2020-06-11 12:08 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC5BB87@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xix.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).