test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] tests/link_flowctrl: fix case/setting agreement
Date: Thu, 11 Jun 2020 12:21:44 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC5BC58@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1591203807-162767-1-git-send-email-lijuan.tu@intel.com>

Applied, thanks

-----Original Message-----
From: Tu, Lijuan <lijuan.tu@intel.com> 
Sent: 2020年6月4日 1:03
To: dts@dpdk.org
Cc: Tu, Lijuan <lijuan.tu@intel.com>
Subject: [PATCH] tests/link_flowctrl: fix case/setting agreement

* fix case setting: test_perf_flowctrl_on_pause_fwd_off
* fix comments

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 tests/TestSuite_link_flowctrl.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
index ee190d0..0349c11 100644
--- a/tests/TestSuite_link_flowctrl.py
+++ b/tests/TestSuite_link_flowctrl.py
@@ -367,7 +367,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_on_pause_fwd_on(self):
         """
-        Disable link flow control and PAUSE frame forwarding
+        Enable link flow control and PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
@@ -381,7 +381,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_on_pause_fwd_off(self):
         """
-        Disable link flow control and enable PAUSE frame forwarding
+        Enable link flow control and disable PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
@@ -399,7 +399,7 @@ class TestLinkFlowctrl(TestCase):
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
-                                            tx_flow_control='on',
+                                            tx_flow_control='off',
                                             pause_frame_fwd='off')
 
         self.logger.info("Packet loss: %.3f" % result) @@ -409,7 +409,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_off_pause_fwd_on(self):
         """
-        Enable link flow control and disable PAUSE frame forwarding
+        Disable link flow control and enable PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='off',
@@ -437,7 +437,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_tx_on(self):
         """
-        Disable link flow control and PAUSE frame forwarding
+        Enable only tx link flow control
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='off',
--
1.8.3.1


      reply	other threads:[~2020-06-11 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 17:03 Lijuan Tu
2020-06-11 12:21 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC5BC58@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).