Re: [dts] [PATCH] test_plan: add hotplug_test_plan

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Qiu, Michael]

[+cc] Bernard

Hi, Bernard and Tetsuya

Would you have time to review this test plan?
Your comments are very important.

Thanks,
Michael
On 2/2/2015 4:47 PM, Qiu, Michael wrote:
> As hotplug feature will be supported by DPDK 2.0, the test plan
> is needed for testing affairs, this could help who wants to do
> hotplug testing for their projects.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  test_plans/hotplug_test_plan.rst | 152 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 152 insertions(+)
>  create mode 100644 test_plans/hotplug_test_plan.rst
>
> diff --git a/test_plans/hotplug_test_plan.rst b/test_plans/hotplug_test_plan.rst
> new file mode 100644
> index 0000000..63c3d70
> --- /dev/null
> +++ b/test_plans/hotplug_test_plan.rst
> @@ -0,0 +1,152 @@
> +.. Copyright (c) <2015>, Intel Corporation
> +   All rights reserved.
> +
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:
> +
> +   - Redistributions of source code must retain the above copyright
> +     notice, this list of conditions and the following disclaimer.
> +
> +   - Redistributions in binary form must reproduce the above copyright
> +     notice, this list of conditions and the following disclaimer in
> +     the documentation and/or other materials provided with the
> +     distribution.
> +
> +   - Neither the name of Intel Corporation nor the names of its
> +     contributors may be used to endorse or promote products derived
> +     from this software without specific prior written permission.
> +
> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> +   OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +======================================
> +DPDK Hotplug API Feature Tests
> +======================================
> +
> +This test for Hotplug API feature can be run on linux userspace. It
> +will check if NIC port can be attach and detach without exiting the
> +application process. Furthermore, it will check if it can reconfigure
> +new configurations for a port after the port is stopped, and if it is
> +able to restart with those new configurations. It is based on testpmd
> +application.
> +
> +The test is performed by running the testpmd application and using a
> +traffic generator. Port configurations can be set interactively,
> +and still be set at the command line when launching the application in
> +order to be compatible with previous test framework.
> +
> +Prerequisites
> +-------------
> +Assume DPDK managerd at least one device for physical or none for virtual.
> +This feature only supports igb_uio now, for uio_pci_generic is
> +on the way, will test it after enabled.
> +
> +To run the testpmd application in linuxapp environment with 4 lcores,
> +4 channels with other default parameters in interactive mode.
> +
> +        $ ./testpmd -c 0xf -n 4 -- -i
> +
> +Test ENV:
> +
> +All test case can be run in 32bit and 64bit platform.
> +
> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd will
> +not include as hotplug has no plan to support that platform
> +
> +All kernel version(start from 2.6) can be support, for vfio need kernel
> +        version greater than 3.6.
> +
> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
> +
> +-------------------------------------------------------------------------------
> +Test Case 1: port dettach & attach for physical devices with igb_uio
> +-------------------------------------------------------------------------------
> +1. run "port attach 0000:02:00.0",
> +   assume the physical devices is BDF is 0000:02:00.0
> +
> +2. run "port start 0".
> +
> +3. run "show port info 0", check port 0 info display.
> +
> +4. run "start", then "show port stats 0" check fwd packages start.
> +
> +5. run "port detach 0", check the error message of port not stopped.
> +
> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> +
> +7. run "port close 0".
> +
> +8. run "port detach 0", check port detached successful.
> +
> +-------------------------------------------------------------------------------
> +Test Case 2: port dettach & attach for physical devices with vfio
> +-------------------------------------------------------------------------------
> +1. run "port attach 0000:02:00.0",
> +   assume the physical devices is BDF is 0000:02:00.0
> +
> +2. run "port start 0".
> +
> +3. run "show port info 0", check port 0 info display.
> +
> +4. run "start", then "show port stats 0" check fwd packages start.
> +
> +5. run "port detach 0", check the error message of port not stopped.
> +
> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> +
> +7. run "port close 0".
> +
> +8. run "port detach 0", check port detached failed(If hotplug for vfio
> +   implemented, should be successful).
> +
> +-------------------------------------------------------------------------------
> +Test Case 3: port dettach & attach for physical devices with uio_pci_generic
> +-------------------------------------------------------------------------------
> +1. run "port attach 0000:02:00.0",
> +   assume the physical devices is BDF is 0000:02:00.0
> +
> +2. run "port start 0".
> +
> +3. run "show port info 0", check port 0 info display.
> +
> +4. run "start", then "show port stats 0" check fwd packages start.
> +
> +5. run "port detach 0", check the error message of port not stopped.
> +
> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> +
> +7. run "port close 0".
> +
> +8. run "port detach 0", check port detached successful.
> +
> +-------------------------------------------------------------------------------
> +Test Case 4: port dettach & attach for virtual devices
> +-------------------------------------------------------------------------------
> +1. run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
> +
> +2. run "port start 0".
> +
> +3. run "show port info 0", check port 0 info display.
> +
> +4. run "start", then "show port stats 0" check fwd packages start.
> +
> +5. run "port detach 0", check the error message of port not stopped.
> +
> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> +
> +7. run "port close 0".
> +
> +8. run "port detach 0", check port detached successful.
> +
> +successfully  

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Iremonger, Bernard]

> -----Original Message-----
> From: Qiu, Michael
> Sent: Monday, February 9, 2015 1:14 PM
> To: dts@dpdk.org
> Cc: mukawa@igel.co.jp; Iremonger, Bernard
> Subject: Re: [PATCH] test_plan: add hotplug_test_plan
> 
> [+cc] Bernard
> 
> Hi, Bernard and Tetsuya
> 
> Would you have time to review this test plan?

Hi Michael,

Yes, my comments are inline.

> Your comments are very important.
> 
> Thanks,
> Michael
> On 2/2/2015 4:47 PM, Qiu, Michael wrote:
> > As hotplug feature will be supported by DPDK 2.0, the test plan is
> > needed for testing affairs, this could help who wants to do hotplug
> > testing for their projects.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> >  test_plans/hotplug_test_plan.rst | 152
> > +++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 152 insertions(+)
> >  create mode 100644 test_plans/hotplug_test_plan.rst
> >
> > diff --git a/test_plans/hotplug_test_plan.rst
> > b/test_plans/hotplug_test_plan.rst
> > new file mode 100644
> > index 0000000..63c3d70
> > --- /dev/null
> > +++ b/test_plans/hotplug_test_plan.rst
> > @@ -0,0 +1,152 @@
> > +.. Copyright (c) <2015>, Intel Corporation
> > +   All rights reserved.
> > +
> > +   Redistribution and use in source and binary forms, with or without
> > +   modification, are permitted provided that the following conditions
> > +   are met:
> > +
> > +   - Redistributions of source code must retain the above copyright
> > +     notice, this list of conditions and the following disclaimer.
> > +
> > +   - Redistributions in binary form must reproduce the above copyright
> > +     notice, this list of conditions and the following disclaimer in
> > +     the documentation and/or other materials provided with the
> > +     distribution.
> > +
> > +   - Neither the name of Intel Corporation nor the names of its
> > +     contributors may be used to endorse or promote products derived
> > +     from this software without specific prior written permission.
> > +
> > +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> > +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> > +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> > +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> > +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> > +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> > +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> > +   OF THE POSSIBILITY OF SUCH DAMAGE.
> > +
> > +======================================
> > +DPDK Hotplug API Feature Tests
> > +======================================
> > +
> > +This test for Hotplug API feature can be run on linux userspace. It
> > +will check if NIC port can be attach and detach without exiting the

Reword "can be attach and detach" to  "can be attached and detached"

> > +application process. Furthermore, it will check if it can reconfigure
> > +new configurations for a port after the port is stopped, and if it is
> > +able to restart with those new configurations. It is based on testpmd
> > +application.
> > +
> > +The test is performed by running the testpmd application and using a
> > +traffic generator. Port configurations can be set interactively, and
> > +still be set at the command line when launching the application in
> > +order to be compatible with previous test framework.
> > +
> > +Prerequisites
> > +-------------
> > +Assume DPDK managerd at least one device for physical or none for virtual.

Reword "managerd" to "managed"

> > +This feature only supports igb_uio now, for uio_pci_generic is on the
> > +way, will test it after enabled.
> > +
> > +To run the testpmd application in linuxapp environment with 4 lcores,
> > +4 channels with other default parameters in interactive mode.
> > +
> > +        $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +Test ENV:
> > +
> > +All test case can be run in 32bit and 64bit platform.

Reword "case" to "cases"

> > +
> > +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd

Reword "All os can be support" to "All os's can be supported"

> > +will not include as hotplug has no plan to support that platform

Reword "will not include" to "will not be included".

> > +
> > +All kernel version(start from 2.6) can be support, for vfio need kernel

Reword " All kernel version(start from 2.6) can be support" to "All kernel versions(from 2.6) can be supported"

> > +        version greater than 3.6.
> > +
> > +Virtulization support: KVM/VMware/Xen, container is in the roadmap
> > +
> > +---------------------------------------------------------------------
> > +---------- Test Case 1: port dettach & attach for physical devices

Reword "dettach" to "detach"

> > +with igb_uio
> > +---------------------------------------------------------------------
> > +----------
> > +1. run "port attach 0000:02:00.0",
> > +   assume the physical devices is BDF is 0000:02:00.0
> > +
> > +2. run "port start 0".
> > +
> > +3. run "show port info 0", check port 0 info display.
> > +
> > +4. run "start", then "show port stats 0" check fwd packages start.
> > +
> > +5. run "port detach 0", check the error message of port not stopped.
> > +
> > +6. run "stop", then "show port stats 0", check fwd packages stoped.

Reword "stoped" to "stopped"

> > +
> > +7. run "port close 0".
> > +
> > +8. run "port detach 0", check port detached successful.

Should probably have a test case to attach a port again after it has been detached.

> > +
> > +---------------------------------------------------------------------
> > +---------- Test Case 2: port dettach & attach for physical devices

Reword "dettach"  to "detach"

> > +with vfio
> > +---------------------------------------------------------------------
> > +----------
> > +1. run "port attach 0000:02:00.0",
> > +   assume the physical devices is BDF is 0000:02:00.0
> > +
> > +2. run "port start 0".
> > +
> > +3. run "show port info 0", check port 0 info display.
> > +
> > +4. run "start", then "show port stats 0" check fwd packages start.
> > +
> > +5. run "port detach 0", check the error message of port not stopped.
> > +
> > +6. run "stop", then "show port stats 0", check fwd packages stoped.

Reword "stoped" to "stopped" 
> > +
> > +7. run "port close 0".
> > +
> > +8. run "port detach 0", check port detached failed(If hotplug for vfio
> > +   implemented, should be successful).

This should fail as no detach support at the moment for vfio.

> > +
> > +---------------------------------------------------------------------
> > +---------- Test Case 3: port dettach & attach for physical devices

Reword "dettach" to detach.

> > +with uio_pci_generic
> > +---------------------------------------------------------------------
> > +----------

There is no support for uio_pci_generic at present.
It might be better to leave this test case out until support is added.

> > +1. run "port attach 0000:02:00.0",
> > +   assume the physical devices is BDF is 0000:02:00.0
> > +
> > +2. run "port start 0".
> > +
> > +3. run "show port info 0", check port 0 info display.
> > +
> > +4. run "start", then "show port stats 0" check fwd packages start.
> > +
> > +5. run "port detach 0", check the error message of port not stopped.
> > +
> > +6. run "stop", then "show port stats 0", check fwd packages stoped.

Reword "stoped" to "stopped"

> > +
> > +7. run "port close 0".
> > +
> > +8. run "port detach 0", check port detached successful.
> > +
> > +---------------------------------------------------------------------
> > +---------- Test Case 4: port dettach & attach for virtual devices

Reword "dettach" to detach.

> > +---------------------------------------------------------------------
> > +---------- 1. run "port attach eth_pcap0,iface=xxxx", where "xxxx" is
> > +one workable ifname.
> > +
> > +2. run "port start 0".
> > +
> > +3. run "show port info 0", check port 0 info display.
> > +
> > +4. run "start", then "show port stats 0" check fwd packages start.
> > +
> > +5. run "port detach 0", check the error message of port not stopped.
> > +
> > +6. run "stop", then "show port stats 0", check fwd packages stoped.

Reword "stoped" to  "stopped"

> > +
> > +7. run "port close 0".
> > +
> > +8. run "port detach 0", check port detached successful.
> > +
> > +successfully

Should probably have a test case to attach a virtual port again after it has been detached.

Regards,

Bernard.

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Qiu, Michael]

On 2/10/2015 12:27 AM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Qiu, Michael
>> Sent: Monday, February 9, 2015 1:14 PM
>> To: dts@dpdk.org
>> Cc: mukawa@igel.co.jp; Iremonger, Bernard
>> Subject: Re: [PATCH] test_plan: add hotplug_test_plan
>>
>> [+cc] Bernard
>>
>> Hi, Bernard and Tetsuya
>>
>> Would you have time to review this test plan?
> Hi Michael,
>
> Yes, my comments are inline.

OK, I will fix all typo.

Thanks,
Michael
>> Your comments are very important.
>>
>> Thanks,
>> Michael
>> On 2/2/2015 4:47 PM, Qiu, Michael wrote:
>>> As hotplug feature will be supported by DPDK 2.0, the test plan is
>>> needed for testing affairs, this could help who wants to do hotplug
>>> testing for their projects.
>>>
>>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>>> ---
>>>  test_plans/hotplug_test_plan.rst | 152
>>> +++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 152 insertions(+)
>>>  create mode 100644 test_plans/hotplug_test_plan.rst
>>>
>>> diff --git a/test_plans/hotplug_test_plan.rst
>>> b/test_plans/hotplug_test_plan.rst
>>> new file mode 100644
>>> index 0000000..63c3d70
>>> --- /dev/null
>>> +++ b/test_plans/hotplug_test_plan.rst
>>> @@ -0,0 +1,152 @@
>>> +.. Copyright (c) <2015>, Intel Corporation
>>> +   All rights reserved.
>>> +
>>> +   Redistribution and use in source and binary forms, with or without
>>> +   modification, are permitted provided that the following conditions
>>> +   are met:
>>> +
>>> +   - Redistributions of source code must retain the above copyright
>>> +     notice, this list of conditions and the following disclaimer.
>>> +
>>> +   - Redistributions in binary form must reproduce the above copyright
>>> +     notice, this list of conditions and the following disclaimer in
>>> +     the documentation and/or other materials provided with the
>>> +     distribution.
>>> +
>>> +   - Neither the name of Intel Corporation nor the names of its
>>> +     contributors may be used to endorse or promote products derived
>>> +     from this software without specific prior written permission.
>>> +
>>> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>>> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
>>> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
>>> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
>>> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
>>> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>>> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
>>> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
>>> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
>>> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
>>> +   OF THE POSSIBILITY OF SUCH DAMAGE.
>>> +
>>> +======================================
>>> +DPDK Hotplug API Feature Tests
>>> +======================================
>>> +
>>> +This test for Hotplug API feature can be run on linux userspace. It
>>> +will check if NIC port can be attach and detach without exiting the
> Reword "can be attach and detach" to  "can be attached and detached"
>
>>> +application process. Furthermore, it will check if it can reconfigure
>>> +new configurations for a port after the port is stopped, and if it is
>>> +able to restart with those new configurations. It is based on testpmd
>>> +application.
>>> +
>>> +The test is performed by running the testpmd application and using a
>>> +traffic generator. Port configurations can be set interactively, and
>>> +still be set at the command line when launching the application in
>>> +order to be compatible with previous test framework.
>>> +
>>> +Prerequisites
>>> +-------------
>>> +Assume DPDK managerd at least one device for physical or none for virtual.
> Reword "managerd" to "managed"
>
>>> +This feature only supports igb_uio now, for uio_pci_generic is on the
>>> +way, will test it after enabled.
>>> +
>>> +To run the testpmd application in linuxapp environment with 4 lcores,
>>> +4 channels with other default parameters in interactive mode.
>>> +
>>> +        $ ./testpmd -c 0xf -n 4 -- -i
>>> +
>>> +Test ENV:
>>> +
>>> +All test case can be run in 32bit and 64bit platform.
> Reword "case" to "cases"
>
>>> +
>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd
> Reword "All os can be support" to "All os's can be supported"
>
>>> +will not include as hotplug has no plan to support that platform
> Reword "will not include" to "will not be included".
>
>>> +
>>> +All kernel version(start from 2.6) can be support, for vfio need kernel
> Reword " All kernel version(start from 2.6) can be support" to "All kernel versions(from 2.6) can be supported"
>
>>> +        version greater than 3.6.
>>> +
>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
>>> +
>>> +---------------------------------------------------------------------
>>> +---------- Test Case 1: port dettach & attach for physical devices
> Reword "dettach" to "detach"
>
>>> +with igb_uio
>>> +---------------------------------------------------------------------
>>> +----------
>>> +1. run "port attach 0000:02:00.0",
>>> +   assume the physical devices is BDF is 0000:02:00.0
>>> +
>>> +2. run "port start 0".
>>> +
>>> +3. run "show port info 0", check port 0 info display.
>>> +
>>> +4. run "start", then "show port stats 0" check fwd packages start.
>>> +
>>> +5. run "port detach 0", check the error message of port not stopped.
>>> +
>>> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> Reword "stoped" to "stopped"
>
>>> +
>>> +7. run "port close 0".
>>> +
>>> +8. run "port detach 0", check port detached successful.
> Should probably have a test case to attach a port again after it has been detached.
>
>>> +
>>> +---------------------------------------------------------------------
>>> +---------- Test Case 2: port dettach & attach for physical devices
> Reword "dettach"  to "detach"
>
>>> +with vfio
>>> +---------------------------------------------------------------------
>>> +----------
>>> +1. run "port attach 0000:02:00.0",
>>> +   assume the physical devices is BDF is 0000:02:00.0
>>> +
>>> +2. run "port start 0".
>>> +
>>> +3. run "show port info 0", check port 0 info display.
>>> +
>>> +4. run "start", then "show port stats 0" check fwd packages start.
>>> +
>>> +5. run "port detach 0", check the error message of port not stopped.
>>> +
>>> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> Reword "stoped" to "stopped" 
>>> +
>>> +7. run "port close 0".
>>> +
>>> +8. run "port detach 0", check port detached failed(If hotplug for vfio
>>> +   implemented, should be successful).
> This should fail as no detach support at the moment for vfio.
>
>>> +
>>> +---------------------------------------------------------------------
>>> +---------- Test Case 3: port dettach & attach for physical devices
> Reword "dettach" to detach.
>
>>> +with uio_pci_generic
>>> +---------------------------------------------------------------------
>>> +----------
> There is no support for uio_pci_generic at present.
> It might be better to leave this test case out until support is added.
>
>>> +1. run "port attach 0000:02:00.0",
>>> +   assume the physical devices is BDF is 0000:02:00.0
>>> +
>>> +2. run "port start 0".
>>> +
>>> +3. run "show port info 0", check port 0 info display.
>>> +
>>> +4. run "start", then "show port stats 0" check fwd packages start.
>>> +
>>> +5. run "port detach 0", check the error message of port not stopped.
>>> +
>>> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> Reword "stoped" to "stopped"
>
>>> +
>>> +7. run "port close 0".
>>> +
>>> +8. run "port detach 0", check port detached successful.
>>> +
>>> +---------------------------------------------------------------------
>>> +---------- Test Case 4: port dettach & attach for virtual devices
> Reword "dettach" to detach.
>
>>> +---------------------------------------------------------------------
>>> +---------- 1. run "port attach eth_pcap0,iface=xxxx", where "xxxx" is
>>> +one workable ifname.
>>> +
>>> +2. run "port start 0".
>>> +
>>> +3. run "show port info 0", check port 0 info display.
>>> +
>>> +4. run "start", then "show port stats 0" check fwd packages start.
>>> +
>>> +5. run "port detach 0", check the error message of port not stopped.
>>> +
>>> +6. run "stop", then "show port stats 0", check fwd packages stoped.
> Reword "stoped" to  "stopped"
>
>>> +
>>> +7. run "port close 0".
>>> +
>>> +8. run "port detach 0", check port detached successful.
>>> +
>>> +successfully
> Should probably have a test case to attach a virtual port again after it has been detached.
>
> Regards,
>
> Bernard.
>

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Qiu, Michael]

On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote:
> Hi Michael,
>
> On 2015/02/09 22:13, Qiu, Michael wrote:
>> [+cc] Bernard
>>
>> Hi, Bernard and Tetsuya
>>
>> Would you have time to review this test plan?
>> Your comments are very important.
>>
>> Thanks,
>> Michael
>> On 2/2/2015 4:47 PM, Qiu, Michael wrote:

[...]

>> +
>> +Prerequisites
>> +-------------
>> +Assume DPDK managerd at least one device for physical or none for virtual.
> "managerd" may be typo.
>
>>> +This feature only supports igb_uio now, for uio_pci_generic is
>>> +on the way, will test it after enabled.
>>> +
>>> +To run the testpmd application in linuxapp environment with 4 lcores,
>>> +4 channels with other default parameters in interactive mode.
>>> +
>>> +        $ ./testpmd -c 0xf -n 4 -- -i
>>> +
>>> +Test ENV:
>>> +
>>> +All test case can be run in 32bit and 64bit platform.
>>> +
>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd will
>>> +not include as hotplug has no plan to support that platform
>>> +
>>> +All kernel version(start from 2.6) can be support, for vfio need kernel
>>> +        version greater than 3.6.
>>> +
>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
> "Virtulization" may be typo.
>
>>> +
>>> +-------------------------------------------------------------------------------
>>> +Test Case 1: port dettach & attach for physical devices with igb_uio
>>> +-------------------------------------------------------------------------------
>>> +1. run "port attach 0000:02:00.0",
>>> +   assume the physical devices is BDF is 0000:02:00.0
> Above sentence may be typo.

[...]

> Usually before submitting hotplug patches, I test almost same as above,
> and additionally below cases.
>
> ---------------------------
> Test Re-attach
> ---------------------------
>   - testpmd> attach
>  - testpmd> port start
>  - testpmd> start
>  - testpmd> stop
>  - testpmd> port stop
>  - testpmd> port close
>  - testpmd> port detach
>  - testpmd> port attach
>  - testpmd> port start
>  - testpmd> start
>  - testpmd> stop
>   (To check if re-attached port works fine.)

This will be added for every test case

> ---------------------------
> start testpmd with "--vdev" option, and detach.
> ---------------------------
>
>   - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=<interface>" -- -i
>  - testpmd> start
>  - testpmd> stop
>  - testpmd> port stop
>  - testpmd> port close
>  - testpmd> port detach
>    (To make sure if we can detach the port)
>
> ---------------------------
> start testpmd with an attached physical NIC port, and detach.
> ---------------------------
>   - ./dpdk_nic_bind -b igb_uio <pci address>
>  - ./testpmd -c 0xf -n 4 -- -i
>  - testpmd> start
>  - testpmd> stop
>  - testpmd> port stop
>  - testpmd> port close
>  - testpmd> port detach
>    (To make sure if we can detach the port)

I will add both.

Thanks,
Michael
> How about adding such cases?
>
> Thanks,
> Tetsuya
>
>
>
>
>
>

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Iremonger, Bernard]

> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, February 10, 2015 8:55 AM
> To: Tetsuya Mukawa; dts@dpdk.org
> Cc: Iremonger, Bernard
> Subject: Re: [PATCH] test_plan: add hotplug_test_plan
> 
> On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote:
> > Hi Michael,
> >
> > On 2015/02/09 22:13, Qiu, Michael wrote:
> >> [+cc] Bernard
> >>
> >> Hi, Bernard and Tetsuya
> >>
> >> Would you have time to review this test plan?
> >> Your comments are very important.
> >>
> >> Thanks,
> >> Michael
> >> On 2/2/2015 4:47 PM, Qiu, Michael wrote:
> 
> [...]
> 
> >> +
> >> +Prerequisites
> >> +-------------
> >> +Assume DPDK managerd at least one device for physical or none for virtual.
> > "managerd" may be typo.
> >
> >>> +This feature only supports igb_uio now, for uio_pci_generic is on
> >>> +the way, will test it after enabled.
> >>> +
> >>> +To run the testpmd application in linuxapp environment with 4
> >>> +lcores,
> >>> +4 channels with other default parameters in interactive mode.
> >>> +
> >>> +        $ ./testpmd -c 0xf -n 4 -- -i
> >>> +
> >>> +Test ENV:
> >>> +
> >>> +All test case can be run in 32bit and 64bit platform.
> >>> +
> >>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd
> >>> +will not include as hotplug has no plan to support that platform
> >>> +
> >>> +All kernel version(start from 2.6) can be support, for vfio need kernel
> >>> +        version greater than 3.6.
> >>> +
> >>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
> > "Virtulization" may be typo.
> >
> >>> +
> >>> +-------------------------------------------------------------------
> >>> +------------ Test Case 1: port dettach & attach for physical
> >>> +devices with igb_uio
> >>> +-------------------------------------------------------------------
> >>> +------------
> >>> +1. run "port attach 0000:02:00.0",
> >>> +   assume the physical devices is BDF is 0000:02:00.0
> > Above sentence may be typo.
> 
> [...]
> 
> > Usually before submitting hotplug patches, I test almost same as
> > above, and additionally below cases.
> >
> > ---------------------------
> > Test Re-attach
> > ---------------------------
> >   - testpmd> attach
> >  - testpmd> port start
> >  - testpmd> start
> >  - testpmd> stop
> >  - testpmd> port stop
> >  - testpmd> port close
> >  - testpmd> port detach
> >  - testpmd> port attach
> >  - testpmd> port start
> >  - testpmd> start
> >  - testpmd> stop
> >   (To check if re-attached port works fine.)
> 
> This will be added for every test case
> 
> > ---------------------------
> > start testpmd with "--vdev" option, and detach.
> > ---------------------------
> >
> >   - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=<interface>" -- -i
> >  - testpmd> start
> >  - testpmd> stop
> >  - testpmd> port stop
> >  - testpmd> port close
> >  - testpmd> port detach
> >    (To make sure if we can detach the port)
> >
> > ---------------------------
> > start testpmd with an attached physical NIC port, and detach.
> > ---------------------------
> >   - ./dpdk_nic_bind -b igb_uio <pci address>
> >  - ./testpmd -c 0xf -n 4 -- -i
> >  - testpmd> start
> >  - testpmd> stop
> >  - testpmd> port stop
> >  - testpmd> port close
> >  - testpmd> port detach
> >    (To make sure if we can detach the port)
> 
> I will add both.
> 
> Thanks,
> Michael
> > How about adding such cases?
> >
> > Thanks,
> > Tetsuya
> >
> >
Hi Michael, Tetsuya,

Should there be test cases added using pmd_null (eth_null0) ?

Regards,

Bernard.

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Tetsuya Mukawa]

On 2015/02/11 1:54, Iremonger, Bernard wrote:
>
>> -----Original Message-----
>> From: Qiu, Michael
>> Sent: Tuesday, February 10, 2015 8:55 AM
>> To: Tetsuya Mukawa; dts@dpdk.org
>> Cc: Iremonger, Bernard
>> Subject: Re: [PATCH] test_plan: add hotplug_test_plan
>>
>> On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote:
>>> Hi Michael,
>>>
>>> On 2015/02/09 22:13, Qiu, Michael wrote:
>>>> [+cc] Bernard
>>>>
>>>> Hi, Bernard and Tetsuya
>>>>
>>>> Would you have time to review this test plan?
>>>> Your comments are very important.
>>>>
>>>> Thanks,
>>>> Michael
>>>> On 2/2/2015 4:47 PM, Qiu, Michael wrote:
>> [...]
>>
>>>> +
>>>> +Prerequisites
>>>> +-------------
>>>> +Assume DPDK managerd at least one device for physical or none for virtual.
>>> "managerd" may be typo.
>>>
>>>>> +This feature only supports igb_uio now, for uio_pci_generic is on
>>>>> +the way, will test it after enabled.
>>>>> +
>>>>> +To run the testpmd application in linuxapp environment with 4
>>>>> +lcores,
>>>>> +4 channels with other default parameters in interactive mode.
>>>>> +
>>>>> +        $ ./testpmd -c 0xf -n 4 -- -i
>>>>> +
>>>>> +Test ENV:
>>>>> +
>>>>> +All test case can be run in 32bit and 64bit platform.
>>>>> +
>>>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd
>>>>> +will not include as hotplug has no plan to support that platform
>>>>> +
>>>>> +All kernel version(start from 2.6) can be support, for vfio need kernel
>>>>> +        version greater than 3.6.
>>>>> +
>>>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
>>> "Virtulization" may be typo.
>>>
>>>>> +
>>>>> +-------------------------------------------------------------------
>>>>> +------------ Test Case 1: port dettach & attach for physical
>>>>> +devices with igb_uio
>>>>> +-------------------------------------------------------------------
>>>>> +------------
>>>>> +1. run "port attach 0000:02:00.0",
>>>>> +   assume the physical devices is BDF is 0000:02:00.0
>>> Above sentence may be typo.
>> [...]
>>
>>> Usually before submitting hotplug patches, I test almost same as
>>> above, and additionally below cases.
>>>
>>> ---------------------------
>>> Test Re-attach
>>> ---------------------------
>>>   - testpmd> attach
>>>  - testpmd> port start
>>>  - testpmd> start
>>>  - testpmd> stop
>>>  - testpmd> port stop
>>>  - testpmd> port close
>>>  - testpmd> port detach
>>>  - testpmd> port attach
>>>  - testpmd> port start
>>>  - testpmd> start
>>>  - testpmd> stop
>>>   (To check if re-attached port works fine.)
>> This will be added for every test case
>>
>>> ---------------------------
>>> start testpmd with "--vdev" option, and detach.
>>> ---------------------------
>>>
>>>   - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=<interface>" -- -i
>>>  - testpmd> start
>>>  - testpmd> stop
>>>  - testpmd> port stop
>>>  - testpmd> port close
>>>  - testpmd> port detach
>>>    (To make sure if we can detach the port)
>>>
>>> ---------------------------
>>> start testpmd with an attached physical NIC port, and detach.
>>> ---------------------------
>>>   - ./dpdk_nic_bind -b igb_uio <pci address>
>>>  - ./testpmd -c 0xf -n 4 -- -i
>>>  - testpmd> start
>>>  - testpmd> stop
>>>  - testpmd> port stop
>>>  - testpmd> port close
>>>  - testpmd> port detach
>>>    (To make sure if we can detach the port)
>> I will add both.
>>
>> Thanks,
>> Michael
>>> How about adding such cases?
>>>
>>> Thanks,
>>> Tetsuya
>>>
>>>
> Hi Michael, Tetsuya,
>
> Should there be test cases added using pmd_null (eth_null0) ?

Hi Bernard,

I guess port hotplug function can be separated in below 2 implementations.
- port hotplug framework
- port hotplug implementation in each PMD.

This test plan is for checking hotplug framework.
So I guess we don't need to add Null pmd cases.

When DTS has tests for each PMD, I guess each PMD tests should have
cases for hotplug, because each PMD will have different implementation
for hotplug. I guess null pmd should be also checked like this.

Anyway, if we are not so hurry about adding null pmd tests, I guess I
will be able to commit it next month.

Thanks,
Tetsuya

> Regards,
>
> Bernard.
>
>

Re: [dts] [PATCH] test_plan: add hotplug_test_plan

[Qiu, Michael]

On 2/11/2015 10:33 AM, Tetsuya Mukawa wrote:
> On 2015/02/11 1:54, Iremonger, Bernard wrote:
>>> -----Original Message-----
>>> From: Qiu, Michael
>>> Sent: Tuesday, February 10, 2015 8:55 AM
>>> To: Tetsuya Mukawa; dts@dpdk.org
>>> Cc: Iremonger, Bernard
>>> Subject: Re: [PATCH] test_plan: add hotplug_test_plan
>>>
>>> On 2/10/2015 11:24 AM, Tetsuya Mukawa wrote:
>>>> Hi Michael,
>>>>
>>>> On 2015/02/09 22:13, Qiu, Michael wrote:
>>>>> [+cc] Bernard
>>>>>
>>>>> Hi, Bernard and Tetsuya
>>>>>
>>>>> Would you have time to review this test plan?
>>>>> Your comments are very important.
>>>>>
>>>>> Thanks,
>>>>> Michael
>>>>> On 2/2/2015 4:47 PM, Qiu, Michael wrote:
>>> [...]
>>>
>>>>> +
>>>>> +Prerequisites
>>>>> +-------------
>>>>> +Assume DPDK managerd at least one device for physical or none for virtual.
>>>> "managerd" may be typo.
>>>>
>>>>>> +This feature only supports igb_uio now, for uio_pci_generic is on
>>>>>> +the way, will test it after enabled.
>>>>>> +
>>>>>> +To run the testpmd application in linuxapp environment with 4
>>>>>> +lcores,
>>>>>> +4 channels with other default parameters in interactive mode.
>>>>>> +
>>>>>> +        $ ./testpmd -c 0xf -n 4 -- -i
>>>>>> +
>>>>>> +Test ENV:
>>>>>> +
>>>>>> +All test case can be run in 32bit and 64bit platform.
>>>>>> +
>>>>>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd
>>>>>> +will not include as hotplug has no plan to support that platform
>>>>>> +
>>>>>> +All kernel version(start from 2.6) can be support, for vfio need kernel
>>>>>> +        version greater than 3.6.
>>>>>> +
>>>>>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap
>>>> "Virtulization" may be typo.
>>>>
>>>>>> +
>>>>>> +-------------------------------------------------------------------
>>>>>> +------------ Test Case 1: port dettach & attach for physical
>>>>>> +devices with igb_uio
>>>>>> +-------------------------------------------------------------------
>>>>>> +------------
>>>>>> +1. run "port attach 0000:02:00.0",
>>>>>> +   assume the physical devices is BDF is 0000:02:00.0
>>>> Above sentence may be typo.
>>> [...]
>>>
>>>> Usually before submitting hotplug patches, I test almost same as
>>>> above, and additionally below cases.
>>>>
>>>> ---------------------------
>>>> Test Re-attach
>>>> ---------------------------
>>>>   - testpmd> attach
>>>>  - testpmd> port start
>>>>  - testpmd> start
>>>>  - testpmd> stop
>>>>  - testpmd> port stop
>>>>  - testpmd> port close
>>>>  - testpmd> port detach
>>>>  - testpmd> port attach
>>>>  - testpmd> port start
>>>>  - testpmd> start
>>>>  - testpmd> stop
>>>>   (To check if re-attached port works fine.)
>>> This will be added for every test case
>>>
>>>> ---------------------------
>>>> start testpmd with "--vdev" option, and detach.
>>>> ---------------------------
>>>>
>>>>   - ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=<interface>" -- -i
>>>>  - testpmd> start
>>>>  - testpmd> stop
>>>>  - testpmd> port stop
>>>>  - testpmd> port close
>>>>  - testpmd> port detach
>>>>    (To make sure if we can detach the port)
>>>>
>>>> ---------------------------
>>>> start testpmd with an attached physical NIC port, and detach.
>>>> ---------------------------
>>>>   - ./dpdk_nic_bind -b igb_uio <pci address>
>>>>  - ./testpmd -c 0xf -n 4 -- -i
>>>>  - testpmd> start
>>>>  - testpmd> stop
>>>>  - testpmd> port stop
>>>>  - testpmd> port close
>>>>  - testpmd> port detach
>>>>    (To make sure if we can detach the port)
>>> I will add both.
>>>
>>> Thanks,
>>> Michael
>>>> How about adding such cases?
>>>>
>>>> Thanks,
>>>> Tetsuya
>>>>
>>>>
>> Hi Michael, Tetsuya,
>>
>> Should there be test cases added using pmd_null (eth_null0) ?
> Hi Bernard,
>
> I guess port hotplug function can be separated in below 2 implementations.
> - port hotplug framework
> - port hotplug implementation in each PMD.
>
> This test plan is for checking hotplug framework.
> So I guess we don't need to add Null pmd cases.

Agree, DTS do not care PMD, it care about different NICs, for DPDK, it
chose PMD for different NICs
 
Thanks,
Michael
> When DTS has tests for each PMD, I guess each PMD tests should have
> cases for hotplug, because each PMD will have different implementation
> for hotplug. I guess null pmd should be also checked like this.
>
> Anyway, if we are not so hurry about adding null pmd tests, I guess I
> will be able to commit it next month.
>
> Thanks,
> Tetsuya
>
>> Regards,
>>
>> Bernard.
>>
>>
>
>

[dts] [PATCH v2] test_plan: add hotplug_test_plan

[Michael Qiu]

As hotplug feature will be supported by DPDK 2.0, the test plan
is needed for testing affairs, this could help who wants to do
hotplug testing for their projects.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
v2 --> v1:
	Fix typos.
	Add new cases
	Make steps much more clearly

 test_plans/hotplug_test_plan.rst | 316 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 316 insertions(+)
 create mode 100644 test_plans/hotplug_test_plan.rst

diff --git a/test_plans/hotplug_test_plan.rst b/test_plans/hotplug_test_plan.rst
new file mode 100644
index 0000000..0ef329d
--- /dev/null
+++ b/test_plans/hotplug_test_plan.rst
@@ -0,0 +1,316 @@
+.. Copyright (c) <2015>, Intel Corporation
+   All rights reserved.
+
+   Redistribution and use in source and binary forms, with or without
+   modification, are permitted provided that the following conditions
+   are met:
+
+   - Redistributions of source code must retain the above copyright
+     notice, this list of conditions and the following disclaimer.
+
+   - Redistributions in binary form must reproduce the above copyright
+     notice, this list of conditions and the following disclaimer in
+     the documentation and/or other materials provided with the
+     distribution.
+
+   - Neither the name of Intel Corporation nor the names of its
+     contributors may be used to endorse or promote products derived
+     from this software without specific prior written permission.
+
+   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+   OF THE POSSIBILITY OF SUCH DAMAGE.
+
+======================================
+DPDK Hotplug API Feature Tests
+======================================
+
+This test for Hotplug API feature can be run on linux userspace. It
+will check if NIC port can be attached and detached without exiting the
+application process. Furthermore, it will check if it can reconfigure
+new configurations for a port after the port is stopped, and if it is
+able to restart with those new configurations. It is based on testpmd
+application.
+
+The test is performed by running the testpmd application and using a
+traffic generator. Port configurations can be set interactively,
+and still be set at the command line when launching the application in
+order to be compatible with previous test framework.
+
+Prerequisites
+-------------
+Assume DPDK managed at least one device for physical or none for virtual.
+This feature only supports igb_uio now, for uio_pci_generic is
+on the way, will test it after enabled.
+
+To run the testpmd application in linuxapp environment with 4 lcores,
+4 channels with other default parameters in interactive mode.
+
+        $ ./testpmd -c 0xf -n 4 -- -i
+
+Test ENV:
+
+All test cases can be run in 32bit and 64bit platform.
+
+OS support: Fedora, Ubuntu, RHEL, SUSE, but freebsd will not be
+included as hotplug has no plan to support that platform
+
+All kernel version(from 2.6) can be support, for vfio need kernel
+        version greater than 3.6.
+
+Virtualization support: KVM/VMware/Xen, container is in the roadmap
+
+-------------------------------------------------------------------------------
+Test Case 1: port detach & attach for physical devices with igb_uio
+-------------------------------------------------------------------------------
+
+1. Start testpmd
+    $ ./testpmd -c 0xf -n 4 -- -i
+
+2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
+    # ./tools/dpdk_nic_bind -b igb_uio 0000:02:00.0
+
+
+3. Attach port 0
+    run "port attach 0000:02:00.0"
+
+    run "port start 0"
+
+    run "show port info 0", check port 0 info display.
+
+4. Check package forwarding when startup
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+5. Detach port 0 after port closed
+    run "port stop 0"
+
+    run "port close 0".
+
+    run "port detach 0", check port detached successful.
+
+6. Re-attach port 0(assume BDF 0000:02:00.0)
+    run "port attach 0000:02:00.0",
+
+    run "port start 0".
+
+    run "show port info 0", check port 0 info display.
+
+7. Check package forwarding after re-attach
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+-------------------------------------------------------------------------------
+Test Case 2: port dettach & attach for physical devices with vfio
+-------------------------------------------------------------------------------
+
+1. Start testpmd
+    $ ./testpmd -c 0xf -n 4 -- -i
+
+2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
+    # ./tools/dpdk_nic_bind -b vfio-pci 0000:02:00.0
+
+3. Attach port 0(assume BDF 0000:02:00.0)
+    run "port attach 0000:02:00.0"
+
+    run "port start 0"
+
+    run "show port info 0", check port 0 info display.
+
+4. Detach port 0 after port closed
+    run "port stop 0", then "show port stats 0", check port stopped.
+
+    run "port close 0".
+
+    run "port detach 0", check detach status(should fail as no detach
+                         support at the moment for vfio).
+
+-------------------------------------------------------------------------------
+Test Case 3: port detach & attach for physical devices with uio_pci_generic
+             This case should be enabled after uio_pci_generic enabled for DPDK
+-------------------------------------------------------------------------------
+
+1. Start testpmd
+    $ ./testpmd -c 0xf -n 4 -- -i
+
+2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
+    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
+
+3. Attach port 0(assume BDF 0000:02:00.0)
+    run "port attach 0000:02:00.0"
+
+    run "port start 0"
+
+    run "show port info 0", check port 0 info display.
+
+4. Check package forwarding when startup
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+5. Detach port 0 after port closed
+    run "port stop 0"
+
+    run "port close 0".
+
+    run "port detach 0", check port detached successful.
+
+6. Re-attach port 0(assume BDF is 0000:02:00.0)
+    run "port attach 0000:02:00.0",
+
+    run "port start 0".
+
+    run "show port info 0", check port 0 info display.
+
+7. Check package forwarding after re-attach
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+-------------------------------------------------------------------------------
+Test Case 4: port detach & attach for physical devices with igb_uio
+             Bind driver before testpmd started, port will start automatically
+-------------------------------------------------------------------------------
+
+1. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
+    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
+
+2. Start testpmd
+    $ ./testpmd -c 0xf -n 4 -- -i
+
+3. Check package forwarding when startup
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+4. Detach port 0 after port closed
+    run "port stop 0"
+
+    run "port close 0".
+
+    run "port detach 0", check port detached successful.
+
+5. Re-attach port 0(assume BDF 0000:02:00.0)
+    run "port attach 0000:02:00.0",
+
+    run "port start 0".
+
+    run "show port info 0", check port 0 info display.
+
+6. Check package forwarding after re-attach
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+-------------------------------------------------------------------------------
+Test Case 5: port detach & attach for virtual devices
+-------------------------------------------------------------------------------
+
+1. Start testpmd
+    $ ./testpmd -c 0xf -n 4 -- -i
+
+2. Attach virtual device as port 0
+    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
+
+    run "port start 0".
+
+    run "show port info 0", check port 0 info display correctly.
+
+3. Check package forwarding after port start
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+4. Detach port 0 after port closed
+
+    run "port stop 0".
+
+    run "port close 0".
+
+    run "port detach 0", check port detached successful.
+
+5. Re-attach port 0
+
+    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
+
+    run "port start 0".
+
+    run "show port info 0", check port 0 info display correctly.
+
+6. Check package forwarding after port start
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+-------------------------------------------------------------------------------
+Test Case 6: port detach & attach for virtual devices, with "--vdev"
+-------------------------------------------------------------------------------
+
+1. Start testpmd, ""xxxx" is one workable ifname
+    $ ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=xxxx" -- -i
+
+2. Check package forwarding after port start
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+3. Detach port 0 after port closed
+
+    run "port stop 0".
+
+    run "port close 0".
+
+    run "port detach 0", check port detached successful.
+
+4. Re-attach port 0
+
+    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
+
+    run "port start 0".
+
+    run "show port info 0", check port 0 info display correctly.
+
+5. Check package forwarding after port start
+
+    run "start", then "show port stats 0" check forwarding packages start.
+
+    run "port detach 0", check the error message of port not stopped.
+
+    run "stop", then "show port stats 0", check forwarding packages stopped.
+
+successfully
-- 
1.9.3

Re: [dts] [PATCH v2] test_plan: add hotplug_test_plan

[Qiu, Michael]

Hi, Marvin

What about this patch? It is hotplug test plan.

Thanks,
Michael

On 3/4/2015 10:53 AM, Qiu, Michael wrote:
> As hotplug feature will be supported by DPDK 2.0, the test plan
> is needed for testing affairs, this could help who wants to do
> hotplug testing for their projects.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> v2 --> v1:
> 	Fix typos.
> 	Add new cases
> 	Make steps much more clearly
>
>  test_plans/hotplug_test_plan.rst | 316 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 316 insertions(+)
>  create mode 100644 test_plans/hotplug_test_plan.rst
>
> diff --git a/test_plans/hotplug_test_plan.rst b/test_plans/hotplug_test_plan.rst
> new file mode 100644
> index 0000000..0ef329d
> --- /dev/null
> +++ b/test_plans/hotplug_test_plan.rst
> @@ -0,0 +1,316 @@
> +.. Copyright (c) <2015>, Intel Corporation
> +   All rights reserved.
> +
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:
> +
> +   - Redistributions of source code must retain the above copyright
> +     notice, this list of conditions and the following disclaimer.
> +
> +   - Redistributions in binary form must reproduce the above copyright
> +     notice, this list of conditions and the following disclaimer in
> +     the documentation and/or other materials provided with the
> +     distribution.
> +
> +   - Neither the name of Intel Corporation nor the names of its
> +     contributors may be used to endorse or promote products derived
> +     from this software without specific prior written permission.
> +
> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> +   OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +======================================
> +DPDK Hotplug API Feature Tests
> +======================================
> +
> +This test for Hotplug API feature can be run on linux userspace. It
> +will check if NIC port can be attached and detached without exiting the
> +application process. Furthermore, it will check if it can reconfigure
> +new configurations for a port after the port is stopped, and if it is
> +able to restart with those new configurations. It is based on testpmd
> +application.
> +
> +The test is performed by running the testpmd application and using a
> +traffic generator. Port configurations can be set interactively,
> +and still be set at the command line when launching the application in
> +order to be compatible with previous test framework.
> +
> +Prerequisites
> +-------------
> +Assume DPDK managed at least one device for physical or none for virtual.
> +This feature only supports igb_uio now, for uio_pci_generic is
> +on the way, will test it after enabled.
> +
> +To run the testpmd application in linuxapp environment with 4 lcores,
> +4 channels with other default parameters in interactive mode.
> +
> +        $ ./testpmd -c 0xf -n 4 -- -i
> +
> +Test ENV:
> +
> +All test cases can be run in 32bit and 64bit platform.
> +
> +OS support: Fedora, Ubuntu, RHEL, SUSE, but freebsd will not be
> +included as hotplug has no plan to support that platform
> +
> +All kernel version(from 2.6) can be support, for vfio need kernel
> +        version greater than 3.6.
> +
> +Virtualization support: KVM/VMware/Xen, container is in the roadmap
> +
> +-------------------------------------------------------------------------------
> +Test Case 1: port detach & attach for physical devices with igb_uio
> +-------------------------------------------------------------------------------
> +
> +1. Start testpmd
> +    $ ./testpmd -c 0xf -n 4 -- -i
> +
> +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> +    # ./tools/dpdk_nic_bind -b igb_uio 0000:02:00.0
> +
> +
> +3. Attach port 0
> +    run "port attach 0000:02:00.0"
> +
> +    run "port start 0"
> +
> +    run "show port info 0", check port 0 info display.
> +
> +4. Check package forwarding when startup
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +5. Detach port 0 after port closed
> +    run "port stop 0"
> +
> +    run "port close 0".
> +
> +    run "port detach 0", check port detached successful.
> +
> +6. Re-attach port 0(assume BDF 0000:02:00.0)
> +    run "port attach 0000:02:00.0",
> +
> +    run "port start 0".
> +
> +    run "show port info 0", check port 0 info display.
> +
> +7. Check package forwarding after re-attach
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +-------------------------------------------------------------------------------
> +Test Case 2: port dettach & attach for physical devices with vfio
> +-------------------------------------------------------------------------------
> +
> +1. Start testpmd
> +    $ ./testpmd -c 0xf -n 4 -- -i
> +
> +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> +    # ./tools/dpdk_nic_bind -b vfio-pci 0000:02:00.0
> +
> +3. Attach port 0(assume BDF 0000:02:00.0)
> +    run "port attach 0000:02:00.0"
> +
> +    run "port start 0"
> +
> +    run "show port info 0", check port 0 info display.
> +
> +4. Detach port 0 after port closed
> +    run "port stop 0", then "show port stats 0", check port stopped.
> +
> +    run "port close 0".
> +
> +    run "port detach 0", check detach status(should fail as no detach
> +                         support at the moment for vfio).
> +
> +-------------------------------------------------------------------------------
> +Test Case 3: port detach & attach for physical devices with uio_pci_generic
> +             This case should be enabled after uio_pci_generic enabled for DPDK
> +-------------------------------------------------------------------------------
> +
> +1. Start testpmd
> +    $ ./testpmd -c 0xf -n 4 -- -i
> +
> +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> +    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
> +
> +3. Attach port 0(assume BDF 0000:02:00.0)
> +    run "port attach 0000:02:00.0"
> +
> +    run "port start 0"
> +
> +    run "show port info 0", check port 0 info display.
> +
> +4. Check package forwarding when startup
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +5. Detach port 0 after port closed
> +    run "port stop 0"
> +
> +    run "port close 0".
> +
> +    run "port detach 0", check port detached successful.
> +
> +6. Re-attach port 0(assume BDF is 0000:02:00.0)
> +    run "port attach 0000:02:00.0",
> +
> +    run "port start 0".
> +
> +    run "show port info 0", check port 0 info display.
> +
> +7. Check package forwarding after re-attach
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +-------------------------------------------------------------------------------
> +Test Case 4: port detach & attach for physical devices with igb_uio
> +             Bind driver before testpmd started, port will start automatically
> +-------------------------------------------------------------------------------
> +
> +1. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> +    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
> +
> +2. Start testpmd
> +    $ ./testpmd -c 0xf -n 4 -- -i
> +
> +3. Check package forwarding when startup
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +4. Detach port 0 after port closed
> +    run "port stop 0"
> +
> +    run "port close 0".
> +
> +    run "port detach 0", check port detached successful.
> +
> +5. Re-attach port 0(assume BDF 0000:02:00.0)
> +    run "port attach 0000:02:00.0",
> +
> +    run "port start 0".
> +
> +    run "show port info 0", check port 0 info display.
> +
> +6. Check package forwarding after re-attach
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +-------------------------------------------------------------------------------
> +Test Case 5: port detach & attach for virtual devices
> +-------------------------------------------------------------------------------
> +
> +1. Start testpmd
> +    $ ./testpmd -c 0xf -n 4 -- -i
> +
> +2. Attach virtual device as port 0
> +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
> +
> +    run "port start 0".
> +
> +    run "show port info 0", check port 0 info display correctly.
> +
> +3. Check package forwarding after port start
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +4. Detach port 0 after port closed
> +
> +    run "port stop 0".
> +
> +    run "port close 0".
> +
> +    run "port detach 0", check port detached successful.
> +
> +5. Re-attach port 0
> +
> +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
> +
> +    run "port start 0".
> +
> +    run "show port info 0", check port 0 info display correctly.
> +
> +6. Check package forwarding after port start
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +-------------------------------------------------------------------------------
> +Test Case 6: port detach & attach for virtual devices, with "--vdev"
> +-------------------------------------------------------------------------------
> +
> +1. Start testpmd, ""xxxx" is one workable ifname
> +    $ ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=xxxx" -- -i
> +
> +2. Check package forwarding after port start
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +3. Detach port 0 after port closed
> +
> +    run "port stop 0".
> +
> +    run "port close 0".
> +
> +    run "port detach 0", check port detached successful.
> +
> +4. Re-attach port 0
> +
> +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one workable ifname.
> +
> +    run "port start 0".
> +
> +    run "show port info 0", check port 0 info display correctly.
> +
> +5. Check package forwarding after port start
> +
> +    run "start", then "show port stats 0" check forwarding packages start.
> +
> +    run "port detach 0", check the error message of port not stopped.
> +
> +    run "stop", then "show port stats 0", check forwarding packages stopped.
> +
> +successfully

Re: [dts] [PATCH v2] test_plan: add hotplug_test_plan

[Liu, Yong]

Michael,

This test plan is fine for me. Do we have done the internal code review thus can make sure there's no gap in this plan.
And do you have schedule for corresponding test suite, look like most of cases in this plan can be automated.
 
> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, April 28, 2015 5:08 PM
> To: Liu, Yong
> Cc: dts@dpdk.org
> Subject: Re: [PATCH v2] test_plan: add hotplug_test_plan
> 
> Hi, Marvin
> 
> What about this patch? It is hotplug test plan.
> 
> Thanks,
> Michael
> 
> On 3/4/2015 10:53 AM, Qiu, Michael wrote:
> > As hotplug feature will be supported by DPDK 2.0, the test plan
> > is needed for testing affairs, this could help who wants to do
> > hotplug testing for their projects.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> > v2 --> v1:
> > 	Fix typos.
> > 	Add new cases
> > 	Make steps much more clearly
> >
> >  test_plans/hotplug_test_plan.rst | 316
> +++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 316 insertions(+)
> >  create mode 100644 test_plans/hotplug_test_plan.rst
> >
> > diff --git a/test_plans/hotplug_test_plan.rst
> b/test_plans/hotplug_test_plan.rst
> > new file mode 100644
> > index 0000000..0ef329d
> > --- /dev/null
> > +++ b/test_plans/hotplug_test_plan.rst
> > @@ -0,0 +1,316 @@
> > +.. Copyright (c) <2015>, Intel Corporation
> > +   All rights reserved.
> > +
> > +   Redistribution and use in source and binary forms, with or without
> > +   modification, are permitted provided that the following conditions
> > +   are met:
> > +
> > +   - Redistributions of source code must retain the above copyright
> > +     notice, this list of conditions and the following disclaimer.
> > +
> > +   - Redistributions in binary form must reproduce the above copyright
> > +     notice, this list of conditions and the following disclaimer in
> > +     the documentation and/or other materials provided with the
> > +     distribution.
> > +
> > +   - Neither the name of Intel Corporation nor the names of its
> > +     contributors may be used to endorse or promote products derived
> > +     from this software without specific prior written permission.
> > +
> > +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> > +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> > +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> > +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> > +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> > +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> > +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> > +   OF THE POSSIBILITY OF SUCH DAMAGE.
> > +
> > +======================================
> > +DPDK Hotplug API Feature Tests
> > +======================================
> > +
> > +This test for Hotplug API feature can be run on linux userspace. It
> > +will check if NIC port can be attached and detached without exiting the
> > +application process. Furthermore, it will check if it can reconfigure
> > +new configurations for a port after the port is stopped, and if it is
> > +able to restart with those new configurations. It is based on testpmd
> > +application.
> > +
> > +The test is performed by running the testpmd application and using a
> > +traffic generator. Port configurations can be set interactively,
> > +and still be set at the command line when launching the application in
> > +order to be compatible with previous test framework.
> > +
> > +Prerequisites
> > +-------------
> > +Assume DPDK managed at least one device for physical or none for
> virtual.
> > +This feature only supports igb_uio now, for uio_pci_generic is
> > +on the way, will test it after enabled.
> > +
> > +To run the testpmd application in linuxapp environment with 4 lcores,
> > +4 channels with other default parameters in interactive mode.
> > +
> > +        $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +Test ENV:
> > +
> > +All test cases can be run in 32bit and 64bit platform.
> > +
> > +OS support: Fedora, Ubuntu, RHEL, SUSE, but freebsd will not be
> > +included as hotplug has no plan to support that platform
> > +
> > +All kernel version(from 2.6) can be support, for vfio need kernel
> > +        version greater than 3.6.
> > +
> > +Virtualization support: KVM/VMware/Xen, container is in the roadmap
> > +
> > +-----------------------------------------------------------------------
> --------
> > +Test Case 1: port detach & attach for physical devices with igb_uio
> > +-----------------------------------------------------------------------
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b igb_uio 0000:02:00.0
> > +
> > +
> > +3. Attach port 0
> > +    run "port attach 0000:02:00.0"
> > +
> > +    run "port start 0"
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +4. Check package forwarding when startup
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +5. Detach port 0 after port closed
> > +    run "port stop 0"
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +6. Re-attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0",
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +7. Check package forwarding after re-attach
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-----------------------------------------------------------------------
> --------
> > +Test Case 2: port dettach & attach for physical devices with vfio
> > +-----------------------------------------------------------------------
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b vfio-pci 0000:02:00.0
> > +
> > +3. Attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0"
> > +
> > +    run "port start 0"
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +4. Detach port 0 after port closed
> > +    run "port stop 0", then "show port stats 0", check port stopped.
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check detach status(should fail as no detach
> > +                         support at the moment for vfio).
> > +
> > +-----------------------------------------------------------------------
> --------
> > +Test Case 3: port detach & attach for physical devices with
> uio_pci_generic
> > +             This case should be enabled after uio_pci_generic enabled
> for DPDK
> > +-----------------------------------------------------------------------
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
> > +
> > +3. Attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0"
> > +
> > +    run "port start 0"
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +4. Check package forwarding when startup
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +5. Detach port 0 after port closed
> > +    run "port stop 0"
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +6. Re-attach port 0(assume BDF is 0000:02:00.0)
> > +    run "port attach 0000:02:00.0",
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +7. Check package forwarding after re-attach
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-----------------------------------------------------------------------
> --------
> > +Test Case 4: port detach & attach for physical devices with igb_uio
> > +             Bind driver before testpmd started, port will start
> automatically
> > +-----------------------------------------------------------------------
> --------
> > +
> > +1. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
> > +
> > +2. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +3. Check package forwarding when startup
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +4. Detach port 0 after port closed
> > +    run "port stop 0"
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +5. Re-attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0",
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +6. Check package forwarding after re-attach
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-----------------------------------------------------------------------
> --------
> > +Test Case 5: port detach & attach for virtual devices
> > +-----------------------------------------------------------------------
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Attach virtual device as port 0
> > +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one
> workable ifname.
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display correctly.
> > +
> > +3. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +4. Detach port 0 after port closed
> > +
> > +    run "port stop 0".
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +5. Re-attach port 0
> > +
> > +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one
> workable ifname.
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display correctly.
> > +
> > +6. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-----------------------------------------------------------------------
> --------
> > +Test Case 6: port detach & attach for virtual devices, with "--vdev"
> > +-----------------------------------------------------------------------
> --------
> > +
> > +1. Start testpmd, ""xxxx" is one workable ifname
> > +    $ ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=xxxx" -- -i
> > +
> > +2. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +3. Detach port 0 after port closed
> > +
> > +    run "port stop 0".
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +4. Re-attach port 0
> > +
> > +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one
> workable ifname.
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display correctly.
> > +
> > +5. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +successfully

Re: [dts] [PATCH v2] test_plan: add hotplug_test_plan

[Qiu, Michael]

Actually, automation depends on free time slot of mine.

Thanks,
Michael

-----Original Message-----
From: Liu, Yong 
Sent: Tuesday, April 28, 2015 5:32 PM
To: Qiu, Michael
Cc: dts@dpdk.org
Subject: RE: [PATCH v2] test_plan: add hotplug_test_plan

Michael,

This test plan is fine for me. Do we have done the internal code review thus can make sure there's no gap in this plan.
And do you have schedule for corresponding test suite, look like most of cases in this plan can be automated.
 
> -----Original Message-----
> From: Qiu, Michael
> Sent: Tuesday, April 28, 2015 5:08 PM
> To: Liu, Yong
> Cc: dts@dpdk.org
> Subject: Re: [PATCH v2] test_plan: add hotplug_test_plan
> 
> Hi, Marvin
> 
> What about this patch? It is hotplug test plan.
> 
> Thanks,
> Michael
> 
> On 3/4/2015 10:53 AM, Qiu, Michael wrote:
> > As hotplug feature will be supported by DPDK 2.0, the test plan is 
> > needed for testing affairs, this could help who wants to do hotplug 
> > testing for their projects.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> > v2 --> v1:
> > 	Fix typos.
> > 	Add new cases
> > 	Make steps much more clearly
> >
> >  test_plans/hotplug_test_plan.rst | 316
> +++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 316 insertions(+)
> >  create mode 100644 test_plans/hotplug_test_plan.rst
> >
> > diff --git a/test_plans/hotplug_test_plan.rst
> b/test_plans/hotplug_test_plan.rst
> > new file mode 100644
> > index 0000000..0ef329d
> > --- /dev/null
> > +++ b/test_plans/hotplug_test_plan.rst
> > @@ -0,0 +1,316 @@
> > +.. Copyright (c) <2015>, Intel Corporation
> > +   All rights reserved.
> > +
> > +   Redistribution and use in source and binary forms, with or without
> > +   modification, are permitted provided that the following conditions
> > +   are met:
> > +
> > +   - Redistributions of source code must retain the above copyright
> > +     notice, this list of conditions and the following disclaimer.
> > +
> > +   - Redistributions in binary form must reproduce the above copyright
> > +     notice, this list of conditions and the following disclaimer in
> > +     the documentation and/or other materials provided with the
> > +     distribution.
> > +
> > +   - Neither the name of Intel Corporation nor the names of its
> > +     contributors may be used to endorse or promote products derived
> > +     from this software without specific prior written permission.
> > +
> > +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> > +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> > +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> > +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> > +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> > +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
> > +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> > +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> > +   OF THE POSSIBILITY OF SUCH DAMAGE.
> > +
> > +======================================
> > +DPDK Hotplug API Feature Tests
> > +======================================
> > +
> > +This test for Hotplug API feature can be run on linux userspace. It 
> > +will check if NIC port can be attached and detached without exiting 
> > +the application process. Furthermore, it will check if it can 
> > +reconfigure new configurations for a port after the port is 
> > +stopped, and if it is able to restart with those new 
> > +configurations. It is based on testpmd application.
> > +
> > +The test is performed by running the testpmd application and using 
> > +a traffic generator. Port configurations can be set interactively, 
> > +and still be set at the command line when launching the application 
> > +in order to be compatible with previous test framework.
> > +
> > +Prerequisites
> > +-------------
> > +Assume DPDK managed at least one device for physical or none for
> virtual.
> > +This feature only supports igb_uio now, for uio_pci_generic is on 
> > +the way, will test it after enabled.
> > +
> > +To run the testpmd application in linuxapp environment with 4 
> > +lcores,
> > +4 channels with other default parameters in interactive mode.
> > +
> > +        $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +Test ENV:
> > +
> > +All test cases can be run in 32bit and 64bit platform.
> > +
> > +OS support: Fedora, Ubuntu, RHEL, SUSE, but freebsd will not be 
> > +included as hotplug has no plan to support that platform
> > +
> > +All kernel version(from 2.6) can be support, for vfio need kernel
> > +        version greater than 3.6.
> > +
> > +Virtualization support: KVM/VMware/Xen, container is in the roadmap
> > +
> > +-------------------------------------------------------------------
> > +----
> --------
> > +Test Case 1: port detach & attach for physical devices with igb_uio
> > +-------------------------------------------------------------------
> > +----
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b igb_uio 0000:02:00.0
> > +
> > +
> > +3. Attach port 0
> > +    run "port attach 0000:02:00.0"
> > +
> > +    run "port start 0"
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +4. Check package forwarding when startup
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +5. Detach port 0 after port closed
> > +    run "port stop 0"
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +6. Re-attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0",
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +7. Check package forwarding after re-attach
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-------------------------------------------------------------------
> > +----
> --------
> > +Test Case 2: port dettach & attach for physical devices with vfio
> > +-------------------------------------------------------------------
> > +----
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b vfio-pci 0000:02:00.0
> > +
> > +3. Attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0"
> > +
> > +    run "port start 0"
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +4. Detach port 0 after port closed
> > +    run "port stop 0", then "show port stats 0", check port stopped.
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check detach status(should fail as no detach
> > +                         support at the moment for vfio).
> > +
> > +-------------------------------------------------------------------
> > +----
> --------
> > +Test Case 3: port detach & attach for physical devices with
> uio_pci_generic
> > +             This case should be enabled after uio_pci_generic 
> > + enabled
> for DPDK
> > +-------------------------------------------------------------------
> > +----
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
> > +
> > +3. Attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0"
> > +
> > +    run "port start 0"
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +4. Check package forwarding when startup
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +5. Detach port 0 after port closed
> > +    run "port stop 0"
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +6. Re-attach port 0(assume BDF is 0000:02:00.0)
> > +    run "port attach 0000:02:00.0",
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +7. Check package forwarding after re-attach
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-------------------------------------------------------------------
> > +----
> --------
> > +Test Case 4: port detach & attach for physical devices with igb_uio
> > +             Bind driver before testpmd started, port will start
> automatically
> > +-------------------------------------------------------------------
> > +----
> --------
> > +
> > +1. Bind new physical port to igb_uio(assume BDF 0000:02:00.0)
> > +    # ./tools/dpdk_nic_bind -b uio_pci_generic 0000:02:00.0
> > +
> > +2. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +3. Check package forwarding when startup
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +4. Detach port 0 after port closed
> > +    run "port stop 0"
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +5. Re-attach port 0(assume BDF 0000:02:00.0)
> > +    run "port attach 0000:02:00.0",
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display.
> > +
> > +6. Check package forwarding after re-attach
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-------------------------------------------------------------------
> > +----
> --------
> > +Test Case 5: port detach & attach for virtual devices
> > +-------------------------------------------------------------------
> > +----
> --------
> > +
> > +1. Start testpmd
> > +    $ ./testpmd -c 0xf -n 4 -- -i
> > +
> > +2. Attach virtual device as port 0
> > +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one
> workable ifname.
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display correctly.
> > +
> > +3. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +4. Detach port 0 after port closed
> > +
> > +    run "port stop 0".
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +5. Re-attach port 0
> > +
> > +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one
> workable ifname.
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display correctly.
> > +
> > +6. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +-------------------------------------------------------------------
> > +----
> --------
> > +Test Case 6: port detach & attach for virtual devices, with "--vdev"
> > +-------------------------------------------------------------------
> > +----
> --------
> > +
> > +1. Start testpmd, ""xxxx" is one workable ifname
> > +    $ ./testpmd -c 0xf -n 4 --vdev "eth_pcap0,iface=xxxx" -- -i
> > +
> > +2. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +3. Detach port 0 after port closed
> > +
> > +    run "port stop 0".
> > +
> > +    run "port close 0".
> > +
> > +    run "port detach 0", check port detached successful.
> > +
> > +4. Re-attach port 0
> > +
> > +    run "port attach eth_pcap0,iface=xxxx", where "xxxx" is one
> workable ifname.
> > +
> > +    run "port start 0".
> > +
> > +    run "show port info 0", check port 0 info display correctly.
> > +
> > +5. Check package forwarding after port start
> > +
> > +    run "start", then "show port stats 0" check forwarding packages
> start.
> > +
> > +    run "port detach 0", check the error message of port not stopped.
> > +
> > +    run "stop", then "show port stats 0", check forwarding packages
> stopped.
> > +
> > +successfully