From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D9F71A0096 for ; Tue, 9 Apr 2019 07:11:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDC134D3A; Tue, 9 Apr 2019 07:11:58 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2F4AA4CC3 for ; Tue, 9 Apr 2019 07:11:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 22:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,328,1549958400"; d="scan'208";a="336174643" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 08 Apr 2019 22:11:55 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Apr 2019 22:11:49 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Apr 2019 22:11:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Tue, 9 Apr 2019 13:11:48 +0800 From: "Yao, BingX Y" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" , "Yao, BingX Y" Thread-Topic: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment conditions Thread-Index: AQHU7oVJTWaTZDBpC06wyaERq9xj/aYzSEGA Date: Tue, 9 Apr 2019 05:11:47 +0000 Message-ID: <95BCD24840F32441BEA74E0F8A31839E04F14253@shsmsx102.ccr.corp.intel.com> References: <1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment conditions X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Tested-by:Yao, BingX Y -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui Sent: Tuesday, April 9, 2019 11:39 AM To: dts@dpdk.org Cc: Zhu, WenhuiX Subject: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment condition= s The second package pkt_size needs to be added HEADER_SIZE['eth']. The mtu threshold is 2022, when mtu is over 2022,require to open/stop port Signed-off-by: zhuwenhui --- tests/TestSuite_userspace_ethtool.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspa= ce_ethtool.py index 4208e0f..f8428ea 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -547,6 +547,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerato= r): """ self.dut.send_expect(self.cmd, "EthApp>", 60) mtus =3D [1519, 2048] + mtu_threshold =3D 2022 for index in range(len(self.ports)): port =3D self.ports[index] # change mtu @@ -555,14 +556,19 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenera= tor): ori_mtu =3D self.strip_mtu(intf) self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ") for mtu in mtus: + # The mtu threshold is 2022,When it is greater than 2022, = the open/stop port is required. + if mtu > mtu_threshold: + self.dut.send_expect("stop %s" % index, "EthApp>") + self.dut.send_expect("mtu %d %d" % (index, mtu), "EthA= pp>") + self.dut.send_expect("open %s" % index, "EthApp>") self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>"= ) ori_rx_pkts, _ =3D self.strip_portstats(index) pkt_size =3D mtu + HEADER_SIZE['eth'] pkt =3D Packet(pkt_len=3Dpkt_size) pkt.send_pkt(tx_port=3Dintf) rx_pkts, _ =3D self.strip_portstats(index) - self.verify(rx_pkts =3D=3D ori_rx_pkts, "Packet match mtu = not forwarded as expected") - pkt =3D Packet(pkt_len=3Dmtu + 1) + self.verify(rx_pkts =3D=3D ori_rx_pkts + 1, "Packet match = mtu not forwarded as expected") + pkt =3D Packet(pkt_len=3Dmtu + 1 + HEADER_SIZE['eth']) pkt.send_pkt(tx_port=3Dintf) rx_pkts_over, _ =3D self.strip_portstats(index) self.verify(rx_pkts =3D=3D rx_pkts_over, "Packet over mtu = should not be forwarded") --=20 2.17.2