test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/tx_preparation: optimize script
@ 2019-08-23 17:03 Wenjie Li
  2019-08-23  8:24 ` Yao, BingX Y
  2019-09-04  5:00 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-08-23 17:03 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

move stop/quit testpmd into tear_down; otherwise, if one case is failed,
the testpmd is still running, it will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_tx_preparation.py | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
index eea95c1..ba0aac7 100644
--- a/tests/TestSuite_tx_preparation.py
+++ b/tests/TestSuite_tx_preparation.py
@@ -173,8 +173,6 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify()
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit() 
  
     def test_tx_preparation_TSO(self):
         """
@@ -185,16 +183,13 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify(1)
-        self.dut_testpmd.execute_cmd('stop')
-        self.dut_testpmd.quit()
-
 
     def tear_down(self):
         """
         Run after each test case. 
-        """ 
-        pass
-
+        """
+        self.dut_testpmd.execute_cmd('stop')
+        self.dut_testpmd.quit()
         
     def tear_down_all(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-04  5:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 17:03 [dts] [PATCH V1] tests/tx_preparation: optimize script Wenjie Li
2019-08-23  8:24 ` Yao, BingX Y
2019-09-04  5:00 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).