test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case
  2021-03-12 13:30 [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case sunqin
@ 2021-03-12  6:08 ` Sun, QinX
  2021-03-15  7:25 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Sun, QinX @ 2021-03-12  6:08 UTC (permalink / raw)
  To: dts; +Cc: Fu, Qi

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

> -----Original Message-----
> From: Sun, QinX <qinx.sun@intel.com>
> Sent: Friday, March 12, 2021 9:30 PM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>; Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case

Tested-by: Sun Qin <qinx.sun@intel.com>

[-- Attachment #2: TestFlexibleRxd.log --]
[-- Type: application/octet-stream, Size: 1073353 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case
@ 2021-03-12 13:30 sunqin
  2021-03-12  6:08 ` Sun, QinX
  2021-03-15  7:25 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: sunqin @ 2021-03-12 13:30 UTC (permalink / raw)
  To: dts; +Cc: qi.fu, sunqin

Confirmed with developer,only type=0x8100 needs to be supported in single vlan mode,

other type values do not need to be verified, so remove the type=0x88A8 case from

test suite and plan.

Signed-off-by: sunqin <qinx.sun@intel.com>
---
 test_plans/flexible_rxd_test_plan.rst | 38 +++++++--------------------
 tests/TestSuite_flexible_rxd.py       |  6 -----
 2 files changed, 10 insertions(+), 34 deletions(-)

diff --git a/test_plans/flexible_rxd_test_plan.rst b/test_plans/flexible_rxd_test_plan.rst
index c3a0e1c6..b2ca34a4 100644
--- a/test_plans/flexible_rxd_test_plan.rst
+++ b/test_plans/flexible_rxd_test_plan.rst
@@ -123,25 +123,7 @@ Check the output in testpmd, **ctag=1:0:23** is expected, which is consistent wi
   ol_flags: PKT_RX_RSS_HASH PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKSUM_UNKNOWN
 
 
-Test Case 02: Check single VLAN fields in RXD (802.1ad)
-=======================================================
-
-Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
-
-Launch testpmd command::
-
-  ./x86_64-native-linux-gcc/app/testpmd -l 6-9 -n 4 -w 18:00.0,proto_xtr=vlan -- -i --rxq=32 --txq=32 --portmask=0x1 --nb-cores=2
-
-Test packet::
-
-  p = Ether(src='3c:fd:fe:bc:f6:78', dst='68:05:ca:a3:13:4c', type=0x88A8)/Dot1Q(prio=1,vlan=23)/IP()/UDP()/DNS()
-
-Expected output in testpmd::
-
-  stag=1:0:23
-
-
-Test Case 03: Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag
+Test Case 02: Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag
 ======================================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -159,7 +141,7 @@ Expected output in testpmd::
   stag=1:0:23
 
 
-Test Case 04: Check double VLAN fields in RXD (802.1Q) 2 VLAN tags
+Test Case 03: Check double VLAN fields in RXD (802.1Q) 2 VLAN tags
 ==================================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -178,7 +160,7 @@ Expected output in testpmd::
   ctag=4:0:56
 
 
-Test Case 05: Check double VLAN fields in RXD (802.1ad)
+Test Case 04: Check double VLAN fields in RXD (802.1ad)
 =======================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -197,7 +179,7 @@ Expected output in testpmd::
   ctag=4:0:56
 
 
-Test Case 06: Check IPv4 fields in RXD
+Test Case 05: Check IPv4 fields in RXD
 ======================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -219,7 +201,7 @@ Expected output in testpmd::
   proto=17
 
 
-Test Case 07: Check IPv6 fields in RXD 
+Test Case 06: Check IPv6 fields in RXD
 =======================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -241,7 +223,7 @@ Expected output in testpmd::
   hoplimit=34
 
 
-Test Case 08: Check IPv6 flow field in RXD
+Test Case 07: Check IPv6 flow field in RXD
 =======================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -261,7 +243,7 @@ Expected output in testpmd::
   flow=0x98765
 
 
-Test Case 09: Check TCP fields in IPv4 in RXD
+Test Case 08: Check TCP fields in IPv4 in RXD
 =======================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -280,7 +262,7 @@ Expected output in testpmd::
   flags=AS
 
 
-Test Case 10: Check TCP fields in IPv6 in RXD
+Test Case 09: Check TCP fields in IPv6 in RXD
 =======================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -299,7 +281,7 @@ Expected output in testpmd::
   flags=S
 
 
-Test Case 11: Check IPv4, IPv6, TCP fields in RXD on specific queues
+Test Case 10: Check IPv4, IPv6, TCP fields in RXD on specific queues
 ====================================================================
 
 Test steps are same to ``Test Case 01``, just change the launch command of testpmd, test packet and expected output
@@ -341,7 +323,7 @@ Expected output in testpmd::
   flags=AS
 
 
-Test Case 12: Check effect of replacing pkg from RXID #22 to RXID #16
+Test Case 11: Check effect of replacing pkg from RXID #22 to RXID #16
 =====================================================================
 
 Put the ice.pkg with RXID #16(ice-1.3.7.0.pkg and more) to /lib/firmware/updates/intel/ice/ddp/ice.pkg, then reload ice driver::
diff --git a/tests/TestSuite_flexible_rxd.py b/tests/TestSuite_flexible_rxd.py
index 6ce0a091..648173e7 100644
--- a/tests/TestSuite_flexible_rxd.py
+++ b/tests/TestSuite_flexible_rxd.py
@@ -117,12 +117,6 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):
         """
         self.check_single_VLAN_fields_in_RXD_8021Q()
 
-    def test_check_single_VLAN_fields_in_RXD_8021ad(self):
-        """
-        Check single VLAN fields in RXD (802.1ad)
-        """
-        self.check_single_VLAN_fields_in_RXD_8021ad()
-
     def test_check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag(self):
         """
         Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case
  2021-03-12 13:30 [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case sunqin
  2021-03-12  6:08 ` Sun, QinX
@ 2021-03-15  7:25 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-03-15  7:25 UTC (permalink / raw)
  To: Sun, QinX, dts; +Cc: Fu, Qi, Sun, QinX

> Confirmed with developer,only type=0x8100 needs to be supported in single vlan
> mode,
> 
> other type values do not need to be verified, so remove the type=0x88A8 case
> from
> 
> test suite and plan.
> 
> Signed-off-by: sunqin <qinx.sun@intel.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-15  7:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 13:30 [dts] [PATCH V1] tests/flexible_rxd: remove one unsupported case sunqin
2021-03-12  6:08 ` Sun, QinX
2021-03-15  7:25 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git