From: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/vf_offload : enable hw vlan
Date: Fri, 2 Feb 2018 03:09:34 +0000 [thread overview]
Message-ID: <9866F1E5CE768A45B24F6603C6EF54DE012EA4E3@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62F7FBBD@SHSMSX103.ccr.corp.intel.com>
on the basis of yao lei's email yesterday :
1.
In previous, testpmd will enable DEV_RX_OFFLOAD_VLAN_FILTER and DEV_RX_OFFLOAD_VLAN_STRIP by default.
Now, they are default off. We need declare them in the testpmd parameter by adding:
--enable-hw-vlan-filter
--enable-hw-vlan-strip
2. Following four testpmd parameter are dropped now because the vlan rx offload are default off.
--disable-hw-vlan
--disable-hw-vlan-filter
--disable-hw-vlan-strip
--disable-hw-vlan-extend
Instead, four new parameter are added.
--enable-hw-vlan
--enable-hw-vlan-filter
--enable-hw-vlan-strip
--enable-hw-vlan-extend
-----Original Message-----
From: Liu, Yong
Sent: Friday, February 2, 2018 11:01 AM
To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: RE: [dts] [PATCH V1] tests/vf_offload : enable hw vlan
Meijuan,
Why change the default setting for RX VLAN offloading? Previous setting is disable and why you enabled it?
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Friday, February 02, 2018 10:47 AM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_offload : enable hw vlan
>
> need enable hw vlan when setup testpmd, you can refer to dpdk commit
> 8b9bd0ef
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_offload.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_vf_offload.py
> b/tests/TestSuite_vf_offload.py index c1983ca..dbae6f9 100644
> --- a/tests/TestSuite_vf_offload.py
> +++ b/tests/TestSuite_vf_offload.py
> @@ -208,7 +208,7 @@ class TestVfOffload(TestCase):
> verify forwarded packets have correct checksum
> """
> self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " %
> - (self.portMask) + "--disable-hw-
> vlan --enable-rx-cksum " + "" +
> + (self.portMask) +
> + "--enable-hw-vlan
> --enable-rx-cksum " + "" +
> "--port-topology=loop")
> self.vm0_testpmd.execute_cmd('set fwd csum')
>
> @@ -258,7 +258,7 @@ class TestVfOffload(TestCase):
> """
>
> self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " %
> - (self.portMask) + "--disable-hw-
> vlan --enable-rx-cksum " +
> + (self.portMask) +
> + "--enable-hw-vlan
> --enable-rx-cksum " +
> "--port-topology=loop")
> self.vm0_testpmd.execute_cmd('set fwd csum')
>
> --
> 1.9.3
next prev parent reply other threads:[~2018-02-02 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 2:47 zhao,meijuan
2018-02-02 3:00 ` Liu, Yong
2018-02-02 3:09 ` Zhao, MeijuanX [this message]
2018-02-02 3:41 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9866F1E5CE768A45B24F6603C6EF54DE012EA4E3@shsmsx102.ccr.corp.intel.com \
--to=meijuanx.zhao@intel.com \
--cc=dts@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).