test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Han, YingyaX" <yingyax.han@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan
Date: Thu, 8 Feb 2018 07:38:50 +0000	[thread overview]
Message-ID: <9AC1400278453341942179604C2BF126D64C04@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62F9C397@SHSMSX103.ccr.corp.intel.com>

I checked this case on several different platforms and DEV_RX_OFFLOAD_VLAN must to be set.
Thanks ,
yingya
-----Original Message-----
From: Liu, Yong 
Sent: Thursday, February 8, 2018 2:06 PM
To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org
Cc: Han, YingyaX <yingyax.han@intel.com>
Subject: RE: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan

Yingya,
In test_qinq_pack_type case, testpmd will enable qinq and meanwhile DEV_RX_OFFLOAD_VLAN_EXTEND flag will be set.
Can you check whether DEV_RX_OFFLOAD_VLAN is must for this case?

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Monday, February 05, 2018 6:11 PM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan
> 
> need enable hw vlan parameter,because default value is off
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
>  tests/TestSuite_qinq_filter.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_qinq_filter.py 
> b/tests/TestSuite_qinq_filter.py index 3f9c1ac..d1310a5 100644
> --- a/tests/TestSuite_qinq_filter.py
> +++ b/tests/TestSuite_qinq_filter.py
> @@ -146,7 +146,7 @@ class TestQinqFilter(TestCase):
>          """
> 
>          self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \
> -                               --portmask=%s --port-topology=loop \
> +                               --portmask=%s --enable-hw-vlan --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss' % 
> (self.target, self.coreMask, self.portMask),
>                                 "testpmd> ")
>          self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, 
> "testpmd> ")
> --
> 1.9.3

  reply	other threads:[~2018-02-08  7:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 10:10 han,yingya
2018-02-08  6:05 ` Liu, Yong
2018-02-08  7:38   ` Han, YingyaX [this message]
2018-02-08  7:46     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9AC1400278453341942179604C2BF126D64C04@SHSMSX101.ccr.corp.intel.com \
    --to=yingyax.han@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).