* [dts] [PATCH V1]tests/qinq_filter:enable hw vlan @ 2018-02-05 10:10 han,yingya 2018-02-08 6:05 ` Liu, Yong 0 siblings, 1 reply; 4+ messages in thread From: han,yingya @ 2018-02-05 10:10 UTC (permalink / raw) To: dts; +Cc: han,yingya need enable hw vlan parameter,because default value is off Signed-off-by: han,yingya <yingyax.han@intel.com> --- tests/TestSuite_qinq_filter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py index 3f9c1ac..d1310a5 100644 --- a/tests/TestSuite_qinq_filter.py +++ b/tests/TestSuite_qinq_filter.py @@ -146,7 +146,7 @@ class TestQinqFilter(TestCase): """ self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \ - --portmask=%s --port-topology=loop \ + --portmask=%s --enable-hw-vlan --port-topology=loop \ --rxq=4 --txq=4 --disable-rss' % (self.target, self.coreMask, self.portMask), "testpmd> ") self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ") -- 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan 2018-02-05 10:10 [dts] [PATCH V1]tests/qinq_filter:enable hw vlan han,yingya @ 2018-02-08 6:05 ` Liu, Yong 2018-02-08 7:38 ` Han, YingyaX 0 siblings, 1 reply; 4+ messages in thread From: Liu, Yong @ 2018-02-08 6:05 UTC (permalink / raw) To: Han, YingyaX, dts; +Cc: Han, YingyaX Yingya, In test_qinq_pack_type case, testpmd will enable qinq and meanwhile DEV_RX_OFFLOAD_VLAN_EXTEND flag will be set. Can you check whether DEV_RX_OFFLOAD_VLAN is must for this case? Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Monday, February 05, 2018 6:11 PM > To: dts@dpdk.org > Cc: Han, YingyaX <yingyax.han@intel.com> > Subject: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan > > need enable hw vlan parameter,because default value is off > Signed-off-by: han,yingya <yingyax.han@intel.com> > --- > tests/TestSuite_qinq_filter.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/TestSuite_qinq_filter.py > b/tests/TestSuite_qinq_filter.py > index 3f9c1ac..d1310a5 100644 > --- a/tests/TestSuite_qinq_filter.py > +++ b/tests/TestSuite_qinq_filter.py > @@ -146,7 +146,7 @@ class TestQinqFilter(TestCase): > """ > > self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \ > - --portmask=%s --port-topology=loop \ > + --portmask=%s --enable-hw-vlan --port- > topology=loop \ > --rxq=4 --txq=4 --disable-rss' % > (self.target, self.coreMask, self.portMask), > "testpmd> ") > self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, > "testpmd> ") > -- > 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan 2018-02-08 6:05 ` Liu, Yong @ 2018-02-08 7:38 ` Han, YingyaX 2018-02-08 7:46 ` Liu, Yong 0 siblings, 1 reply; 4+ messages in thread From: Han, YingyaX @ 2018-02-08 7:38 UTC (permalink / raw) To: Liu, Yong, dts I checked this case on several different platforms and DEV_RX_OFFLOAD_VLAN must to be set. Thanks , yingya -----Original Message----- From: Liu, Yong Sent: Thursday, February 8, 2018 2:06 PM To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org Cc: Han, YingyaX <yingyax.han@intel.com> Subject: RE: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan Yingya, In test_qinq_pack_type case, testpmd will enable qinq and meanwhile DEV_RX_OFFLOAD_VLAN_EXTEND flag will be set. Can you check whether DEV_RX_OFFLOAD_VLAN is must for this case? Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Monday, February 05, 2018 6:11 PM > To: dts@dpdk.org > Cc: Han, YingyaX <yingyax.han@intel.com> > Subject: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan > > need enable hw vlan parameter,because default value is off > Signed-off-by: han,yingya <yingyax.han@intel.com> > --- > tests/TestSuite_qinq_filter.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/TestSuite_qinq_filter.py > b/tests/TestSuite_qinq_filter.py index 3f9c1ac..d1310a5 100644 > --- a/tests/TestSuite_qinq_filter.py > +++ b/tests/TestSuite_qinq_filter.py > @@ -146,7 +146,7 @@ class TestQinqFilter(TestCase): > """ > > self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \ > - --portmask=%s --port-topology=loop \ > + --portmask=%s --enable-hw-vlan --port- > topology=loop \ > --rxq=4 --txq=4 --disable-rss' % > (self.target, self.coreMask, self.portMask), > "testpmd> ") > self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, > "testpmd> ") > -- > 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan 2018-02-08 7:38 ` Han, YingyaX @ 2018-02-08 7:46 ` Liu, Yong 0 siblings, 0 replies; 4+ messages in thread From: Liu, Yong @ 2018-02-08 7:46 UTC (permalink / raw) To: Han, YingyaX, dts; +Cc: Pei, Yulong, Lin, Xueqin Yingya, QinQ filter case can work without DEV_RX_OFFLOAD_VLAN flag. I assume that packet type case will like it. Please check the output of packet type, what kind of packet will be dumped when rx vlan offloading is disabled? Thanks, Marvin > -----Original Message----- > From: Han, YingyaX > Sent: Thursday, February 08, 2018 3:39 PM > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org > Subject: RE: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan > > I checked this case on several different platforms and DEV_RX_OFFLOAD_VLAN > must to be set. > Thanks , > yingya > -----Original Message----- > From: Liu, Yong > Sent: Thursday, February 8, 2018 2:06 PM > To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org > Cc: Han, YingyaX <yingyax.han@intel.com> > Subject: RE: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan > > Yingya, > In test_qinq_pack_type case, testpmd will enable qinq and meanwhile > DEV_RX_OFFLOAD_VLAN_EXTEND flag will be set. > Can you check whether DEV_RX_OFFLOAD_VLAN is must for this case? > > Thanks, > Marvin > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > > Sent: Monday, February 05, 2018 6:11 PM > > To: dts@dpdk.org > > Cc: Han, YingyaX <yingyax.han@intel.com> > > Subject: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan > > > > need enable hw vlan parameter,because default value is off > > Signed-off-by: han,yingya <yingyax.han@intel.com> > > --- > > tests/TestSuite_qinq_filter.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/TestSuite_qinq_filter.py > > b/tests/TestSuite_qinq_filter.py index 3f9c1ac..d1310a5 100644 > > --- a/tests/TestSuite_qinq_filter.py > > +++ b/tests/TestSuite_qinq_filter.py > > @@ -146,7 +146,7 @@ class TestQinqFilter(TestCase): > > """ > > > > self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \ > > - --portmask=%s --port-topology=loop \ > > + --portmask=%s --enable-hw-vlan --port- > > topology=loop \ > > --rxq=4 --txq=4 --disable-rss' % > > (self.target, self.coreMask, self.portMask), > > "testpmd> ") > > self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, > > "testpmd> ") > > -- > > 1.9.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-08 7:46 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-05 10:10 [dts] [PATCH V1]tests/qinq_filter:enable hw vlan han,yingya 2018-02-08 6:05 ` Liu, Yong 2018-02-08 7:38 ` Han, YingyaX 2018-02-08 7:46 ` Liu, Yong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).