From: "Rosen, Rami" <rami.rosen@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] add --crc-strip param when starting i40evf driver testpmd
Date: Wed, 22 Mar 2017 20:52:01 +0000 [thread overview]
Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F93D4BE66D@HASMSX110.ger.corp.intel.com> (raw)
In-Reply-To: <1490074407-32207-1-git-send-email-gangx.xu@intel.com>
Hi, Gang,
Won't it be better to move the comment about the need to use "t--xqflags" downward, so that it will be located immediately before the code line it refers to? Thus:
@@ -101,6 +100,12 @@ class PmdOutput():
def start_testpmd(self, cores, param='', eal_param='', socket=0):
+ black_dic = {'i40evf':' --crc-strip'}
+ for (pci_bus, pci_id) in self.dut.pci_devices_info:
+ driver = get_nic_driver(pci_id)
+ if black_dic.has_key(driver):
+ if black_dic[driver] not in param:
+ param += black_dic[driver]
# in dpdk2.0 need used --txqflags param to open hardware features
if "--txqflags" not in param:
param += " --txqflags=0"
Regards,
Rami Rosen
Intel Corporation
next prev parent reply other threads:[~2017-03-22 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 5:33 xu,gang
2017-03-22 20:52 ` Rosen, Rami [this message]
2017-03-29 6:04 xu,gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9B0331B6EBBD0E4684FBFAEDA55776F93D4BE66D@HASMSX110.ger.corp.intel.com \
--to=rami.rosen@intel.com \
--cc=dts@dpdk.org \
--cc=gangx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).