* [dts] [PATCH V1] add --crc-strip param when starting i40evf driver testpmd
@ 2017-03-21 5:33 xu,gang
2017-03-22 20:52 ` Rosen, Rami
0 siblings, 1 reply; 3+ messages in thread
From: xu,gang @ 2017-03-21 5:33 UTC (permalink / raw)
To: dts; +Cc: xu,gang
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
framework/pmd_output.py | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 13dcaef..507f771 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -31,10 +31,9 @@
import os
import re
-from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
+from settings import TIMEOUT,PROTOCOL_PACKET_SIZE,get_nic_driver
from utils import create_mask
-
class PmdOutput():
"""
@@ -101,6 +100,12 @@ class PmdOutput():
def start_testpmd(self, cores, param='', eal_param='', socket=0):
# in dpdk2.0 need used --txqflags param to open hardware features
+ black_dic = {'i40evf':' --crc-strip'}
+ for (pci_bus, pci_id) in self.dut.pci_devices_info:
+ driver = get_nic_driver(pci_id)
+ if black_dic.has_key(driver):
+ if black_dic[driver] not in param:
+ param += black_dic[driver]
if "--txqflags" not in param:
param += " --txqflags=0"
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] add --crc-strip param when starting i40evf driver testpmd
2017-03-21 5:33 [dts] [PATCH V1] add --crc-strip param when starting i40evf driver testpmd xu,gang
@ 2017-03-22 20:52 ` Rosen, Rami
0 siblings, 0 replies; 3+ messages in thread
From: Rosen, Rami @ 2017-03-22 20:52 UTC (permalink / raw)
To: Xu, GangX, dts; +Cc: Xu, GangX
Hi, Gang,
Won't it be better to move the comment about the need to use "t--xqflags" downward, so that it will be located immediately before the code line it refers to? Thus:
@@ -101,6 +100,12 @@ class PmdOutput():
def start_testpmd(self, cores, param='', eal_param='', socket=0):
+ black_dic = {'i40evf':' --crc-strip'}
+ for (pci_bus, pci_id) in self.dut.pci_devices_info:
+ driver = get_nic_driver(pci_id)
+ if black_dic.has_key(driver):
+ if black_dic[driver] not in param:
+ param += black_dic[driver]
# in dpdk2.0 need used --txqflags param to open hardware features
if "--txqflags" not in param:
param += " --txqflags=0"
Regards,
Rami Rosen
Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dts] [PATCH V1] add --crc-strip param when starting i40evf driver testpmd
@ 2017-03-29 6:04 xu,gang
0 siblings, 0 replies; 3+ messages in thread
From: xu,gang @ 2017-03-29 6:04 UTC (permalink / raw)
To: dts; +Cc: xu,gang
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
framework/pmd_output.py | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 13dcaef..507f771 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -31,10 +31,9 @@
import os
import re
-from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
+from settings import TIMEOUT,PROTOCOL_PACKET_SIZE,get_nic_driver
from utils import create_mask
-
class PmdOutput():
"""
@@ -101,6 +100,12 @@ class PmdOutput():
def start_testpmd(self, cores, param='', eal_param='', socket=0):
# in dpdk2.0 need used --txqflags param to open hardware features
+ black_dic = {'i40evf':' --crc-strip'}
+ for (pci_bus, pci_id) in self.dut.pci_devices_info:
+ driver = get_nic_driver(pci_id)
+ if black_dic.has_key(driver):
+ if black_dic[driver] not in param:
+ param += black_dic[driver]
if "--txqflags" not in param:
param += " --txqflags=0"
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-29 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 5:33 [dts] [PATCH V1] add --crc-strip param when starting i40evf driver testpmd xu,gang
2017-03-22 20:52 ` Rosen, Rami
2017-03-29 6:04 xu,gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).