From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rami.rosen@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id D65001396
 for <dts@dpdk.org>; Wed, 22 Mar 2017 21:52:06 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga104.jf.intel.com with ESMTP; 22 Mar 2017 13:52:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,206,1486454400"; d="scan'208";a="947173745"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga003.jf.intel.com with ESMTP; 22 Mar 2017 13:52:05 -0700
Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 22 Mar 2017 13:52:04 -0700
Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by
 FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 22 Mar 2017 13:52:04 -0700
Received: from HASMSX110.ger.corp.intel.com ([169.254.11.198]) by
 hasmsx108.ger.corp.intel.com ([169.254.9.244]) with mapi id 14.03.0248.002;
 Wed, 22 Mar 2017 22:52:02 +0200
From: "Rosen, Rami" <rami.rosen@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
CC: "Xu, GangX" <gangx.xu@intel.com>
Thread-Topic: [dts] [PATCH V1] add --crc-strip param when starting i40evf
 driver	testpmd
Thread-Index: AQHSogSgb4UznwB54kSM0MKdKlA40KGhVtGQ
Date: Wed, 22 Mar 2017 20:52:01 +0000
Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F93D4BE66D@HASMSX110.ger.corp.intel.com>
References: <1490074407-32207-1-git-send-email-gangx.xu@intel.com>
In-Reply-To: <1490074407-32207-1-git-send-email-gangx.xu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWEzYWEwNjctY2U2ZS00ODc1LWE2ZDktN2RjNGRkODBiYjA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ3djBYWXI4SGE3N1d6b0o4VGl4QlI4SVJZVXo2ZzkyZXZnWnBScnFOS0VBPSJ9
x-ctpclassification: CTP_IC
x-originating-ip: [10.184.70.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dts] [PATCH V1] add --crc-strip param when starting i40evf
 driver	testpmd
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Mar 2017 20:52:07 -0000

Hi, Gang,

Won't it be better to move the comment about the need to use "t--xqflags" d=
ownward, so that it will be located immediately before the code line it ref=
ers to?  Thus:

@@ -101,6 +100,12 @@ class PmdOutput():
=20
     def start_testpmd(self, cores, param=3D'', eal_param=3D'', socket=3D0)=
:
+        black_dic =3D {'i40evf':' --crc-strip'}
+        for (pci_bus, pci_id) in self.dut.pci_devices_info:
+            driver =3D get_nic_driver(pci_id)
+            if black_dic.has_key(driver):
+                if black_dic[driver] not in param:
+                    param +=3D black_dic[driver]
         # in dpdk2.0 need used --txqflags param to open hardware features
         if "--txqflags" not in param:
             param +=3D " --txqflags=3D0"
=20

Regards,
Rami Rosen
Intel Corporation