Re: [dts] [PATCH V3 1/5] conf/pktgen: remove un-used optons

["Chen, Zhaoyan" <zhaoyan.chen@intel.com>]

Acked-by: Zhaoyan Chen <zhaoyan.chen@intel.com>



Regards,
Zhaoyan Chen

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of yufengmx
> Sent: Friday, November 29, 2019 5:03 PM
> To: dts@dpdk.org; Wang, Yinan <yinan.wang@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V3 1/5] conf/pktgen: remove un-used optons
> 
> 
> *. remove core_num, it is not used by pktgen.
> *. remove warmup key, set it in suite script.
> *. remove duration key, set it in suite script.
> *. remove ip_src key, set it in suite script.
> *. remove ip_dst key, set it in suite script.
> *. add more core_mask setting option.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  conf/pktgen.cfg | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/conf/pktgen.cfg b/conf/pktgen.cfg index 667e1e8..e111459 100644
> --- a/conf/pktgen.cfg
> +++ b/conf/pktgen.cfg
> @@ -4,7 +4,14 @@
>  #    trex server binary file is under this directory.
>  # trex_lib_path(optional): trex stateless client libs directory, it is optional.
>  #    If it is not set, use a default relative directory.
> -# coremask -c: A hexadecimal bitmask of cores to run on
> +# coremask:
> +#  1. a list of masks (one core mask per port), sort sequence as
> +#    <port 0 core mask>,<port 1 core mask>
> +#     example:  core_mask=0x3,0x5
> +#  2. CORE_MASK_PIN
> +#     for each dual ports (a group that shares the same cores), the cores will
> +#     be divided half pinned for each port.
> +#     example:  core_mask=CORE_MASK_PIN
>  # num -n: Number of memory channels
>  # proc_type --proc-type: Type of this process  # pci_blacklist --pci-blacklist, -b: Add a
> PCI device in black list.
> @@ -20,13 +27,8 @@
> trex_lib_path=/opt/trex/vx.xxx/automation/trex_control_plane/interactive
>  config_file=/etc/trex_cfg.yaml
>  server=10.67.111.143
>  pcap_file=/opt/trex-core-2.26/scripts/stl/sample.pcap
> -core_num=4
> -#core_mask=0x3
> -ip_src=16.0.0.1
> -ip_dst=10.0.0.1
> -warmup=15
> -duration=-1
> -#start_trex=yes
> +core_mask=0x3,0x5
> +start_trex=yes
> 
>  # IXIA port Configuration
>  # IxiaGroup: Group name for IXIA ports
> --
> 2.21.0