test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/distributor: modify script add novector path expect
@ 2022-07-05  8:16 Lingli Chen
  2022-07-06  6:11 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Lingli Chen @ 2022-07-05  8:16 UTC (permalink / raw)
  To: dts; +Cc: Lingli Chen

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1993 bytes --]

The “--force-max-simd-bitwidth=64” is relatively new to DPDK (novector code path) and severely limits the performance of the burst mode of the distributor.
So modify script to add novector path expect

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/distributor_test_plan.rst |  4 ++++
 tests/TestSuite_distributor.py       | 12 +++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/test_plans/distributor_test_plan.rst b/test_plans/distributor_test_plan.rst
index 7e61bef4..12fd9e9f 100644
--- a/test_plans/distributor_test_plan.rst
+++ b/test_plans/distributor_test_plan.rst
@@ -40,6 +40,10 @@ Compared CPU cycles for normal distributor and burst API
 
 Verify burst distributor API cost much less cycles then normal version
 
+The novector path severely limits the performance of the burst mode of the distributor.
+so novector: expect single mode > burst mode
+vector: expect single mode > burst mode * 2
+
 Test case: Distribute with maximum workers
 ==========================================
 Start distributor sample with 63(0xeffffffffffffffff0) workers
diff --git a/tests/TestSuite_distributor.py b/tests/TestSuite_distributor.py
index 7b41eb01..6878edbd 100644
--- a/tests/TestSuite_distributor.py
+++ b/tests/TestSuite_distributor.py
@@ -65,9 +65,15 @@ class TestDistributor(TestCase):
         )
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
-        self.verify(
-            cycles_single > cycles_burst * 2, "Burst performance should be much better"
-        )
+        if "force-max-simd-bitwidth=64" in eal_para:
+            self.verify(
+                cycles_single > cycles_burst, "Burst performance should be much better"
+            )
+        else:
+            self.verify(
+                cycles_single > cycles_burst * 2,
+                "Burst performance should be much better",
+            )
 
     def test_perf_distributor(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts][PATCH V1] tests/distributor: modify script add novector path expect
  2022-07-05  8:16 [dts][PATCH V1] tests/distributor: modify script add novector path expect Lingli Chen
@ 2022-07-06  6:11 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2022-07-06  6:11 UTC (permalink / raw)
  To: dts, Lingli Chen; +Cc: Lingli Chen

On Tue,  5 Jul 2022 04:16:47 -0400, Lingli Chen <linglix.chen@intel.com> wrote:
> The “--force-max-simd-bitwidth=64” is relatively new to DPDK (novector code path) and severely limits the performance of the burst mode of the distributor.
> So modify script to add novector path expect
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-06  6:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05  8:16 [dts][PATCH V1] tests/distributor: modify script add novector path expect Lingli Chen
2022-07-06  6:11 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).