From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58145A0503; Wed, 18 May 2022 17:38:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33F5840156; Wed, 18 May 2022 17:38:15 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72]) by mails.dpdk.org (Postfix) with ESMTP id 1AD7A400D6 for ; Wed, 18 May 2022 17:38:14 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HS1isZybvJCHsWZr8nMeDgZu6+jwn6vBZf/iEZalzNXXI5AJU/TPUS6BjQtRBlkesg5TadQufUw2E0c3oQrRjFbjGC7oAjr7uYa+ROHWWazGC4OLTTuuUG+j+drW89Pdln12gP2e+wbYgy0qBTCncIvnGj0KEe0T0cKyFw38vSc8QZNUPKgnPdvY1mdyOCQI6e8Yq+qQ8OD2IsaJILPA2mbwgCisNtrmymKs78a4K72jEfDSOVzfzBApoPa+U/0XPgCmPQoAY30V7lxzQx+ueYSzshP/q4Fn2P1Fmkp3UFrdYB+6IJdNNuFRGv5frBMFetNnXLc3Ax8fes/kbMmzRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FQGns2s/ufR8KrmHpQ/emRFSnSmbZtJJRrNORcQlgNY=; b=P4CTVz4/R47sL02RmPfe1VpLMGN6zl3DuI9AJJJIJjuAGrnm8NatmlgTbgFo+SnSCb5DkuTfKBaFie1XKY03++Qy0gV9omm1qwJC+pEtIcrWPt6AKYim+gJGVGaSKFpCye39/U5pWZk0OBG+P3MFJCKn0/zG7EslrvBCTU5G9z0KT7MQE6iUrdn39cwczC6sb27Si0NnQnNOMbhwbMN2aoTanfk4FoFd4dl+pHOxmH+8V9k7+Jn89eeMto0KrpsAgJzGNcQvXI5Dp+T/4kqn0HX2qnb7xlOX7Gf99uV2Ko5uBS0K+hFYKywMpI/82rjwGymemcUN6sI3j6kB4fb3Cg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQGns2s/ufR8KrmHpQ/emRFSnSmbZtJJRrNORcQlgNY=; b=qf08703RENU01IHLAznhNquLkoglFyEPw4oFO+0pBKxRL4EjkiVFTIX8Ivnj/p0TrThpFvRMMtq7Ao/lrvG+7q069XdsYD2hE/bb9ZLFph9a/xIwg18lW9VGGoSGdf3wamOhOZj7iKWP2WTfUHdMCtt9H4amq64ZaQWGc+k/Ri4= Received: from DB6PR1001CA0021.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::31) by DB9PR08MB7494.eurprd08.prod.outlook.com (2603:10a6:10:36d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 15:38:11 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::f2) by DB6PR1001CA0021.outlook.office365.com (2603:10a6:4:b7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Wed, 18 May 2022 15:38:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 15:38:11 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Wed, 18 May 2022 15:38:11 +0000 X-CR-MTA-TID: 64aa7808 Received: from acc54698b0c7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FCC3ADAB-1CCB-4FB4-A0FA-9E8E53FCC642.1; Wed, 18 May 2022 15:38:05 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id acc54698b0c7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 15:38:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MyD57btsNVijoFHpUs263lyIM5wgkdew8FRzAA593KdQTKic8yhkkKYaawXt2fkJ/TF440CdFxg1kej0/X/dE96Ez+HczvWxj3kJCPgyCXEfbhZARWTQYV7W3k/z21EO7F4Dgy2uSPrfss3wp01MvF9tgiTCK82NOHa7sRSVyWJoVpHHd7YN7cSe3+KTNvsmVP3dSQ7FCDL7FSPPw0mkOHy2JMO/XqkcRwZYwXp+qkps7fhx4RJ5D25V8sr2HlJyE9q0EZtAFdMKi1d1R7SUJd8YuZ3ysgIofBNoy2Uz7oCQ7P2h4XHglLGEJLGeq//nK5CDNGPQmeVHovfqYR2lIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FQGns2s/ufR8KrmHpQ/emRFSnSmbZtJJRrNORcQlgNY=; b=BkgDTKdcrEflOP+MCeBNW0MNl2Ju7KSn+cUvNvUoOJlTZvjsy55UZrjwcOObxsFvuJdzYmrjI4FWw6RxyTNiLK8m6vz/th6Va4/VspFVSJNHLBFVAG9gtX9icqLuTvvOdJ2uqxpvlZBlo9MVLBNawbJNnzzTuJ71vpog3Ay6eyHzvGgnlaSTHZbBx/XdPBWhkZLfmtcGxq4ysspUrOrQaNFindVKoThxZElD/0qkgEu6ZgIoIalanP9pVqItic4+hJxQO+GOKCoBhsOAQb/Ppgrv7NGblb8sZAS5fF/aPUfypZGBsBQ+/cYEPYLPWODP1XNBrYQgcV5Bwn9OQiO33Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQGns2s/ufR8KrmHpQ/emRFSnSmbZtJJRrNORcQlgNY=; b=qf08703RENU01IHLAznhNquLkoglFyEPw4oFO+0pBKxRL4EjkiVFTIX8Ivnj/p0TrThpFvRMMtq7Ao/lrvG+7q069XdsYD2hE/bb9ZLFph9a/xIwg18lW9VGGoSGdf3wamOhOZj7iKWP2WTfUHdMCtt9H4amq64ZaQWGc+k/Ri4= Received: from AM8PR08MB5810.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::20) by DB9PR08MB7193.eurprd08.prod.outlook.com (2603:10a6:10:2cc::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 15:38:01 +0000 Received: from AM8PR08MB5810.eurprd08.prod.outlook.com ([fe80::996d:b13d:f458:5dc4]) by AM8PR08MB5810.eurprd08.prod.outlook.com ([fe80::996d:b13d:f458:5dc4%5]) with mapi id 15.20.5273.013; Wed, 18 May 2022 15:38:00 +0000 From: Honnappa Nagarahalli To: =?iso-8859-2?Q?Juraj_Linke=B9?= , "thomas@monjalon.net" , "lijuan.tu@intel.com" , "ohilyard@iol.unh.edu" CC: "dts@dpdk.org" , David Marchand , nd , "bruce.richardson@intel.com" Subject: RE: [PATCH v1] cleanup: rename base classes Thread-Topic: [PATCH v1] cleanup: rename base classes Thread-Index: AQHYaZOCRbuCY86o2k+H58LSxE6UWK0iWJmggABIkICAAQ5hoIABBm+AgAAO+vA= Date: Wed, 18 May 2022 15:38:00 +0000 Message-ID: References: <20220516133340.1056427-1-juraj.linkes@pantheon.tech> <16365457.Ash8RoxBsO@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4ECF5C6429848146B92215B312BC0970.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 86806d6f-e126-407a-8fac-08da38e46a43 x-ms-traffictypediagnostic: DB9PR08MB7193:EE_|DBAEUR03FT028:EE_|DB9PR08MB7494:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YfI8R1AyM3E/fyJHCach2enSeFZXwfPqL78D2OhWHPBlrdHRbWR8VM2KMHoEnk3IIX0spFIhHjZXw6etTx9a4TVIrBM+Kfum9t2aUhvDPXbAH4SiO9NHGbFe3h6fjCPjxFXAu9sRO3xcSJIk8/plCww5iiuAAZqkc/RkABlJSez1qJ1t/Q1YWUG0wHhoLySEh5k+VJq7RxkA4d+MgecnteW/S38M2pEW/wD/tyhEIHTP8h4dcoIDaCXMX3LZS3QYKitbo0JRE52qBSt1zBPfmr5cwO8uPGcYSkW+Ha77OCdw+4jxo0xDdns7rvp6lOSDavC+Osm4JaenpoOXBLsFHQx8A0ElA7BOhpGCTGocG3toQmFlZY7vOdkjIG1TDi60IIIB8ARkJYWxHc9MDzZnN2zAEj2gXfkkQvPmLrGg/sEnXb7B8QfIoqYQNBfFtnvHrJBdxbcHLukU5KSEX/wnYNEH37QZVr8XgugnP+xoDw67uNboAmr8G+39KmH9wq+g34EKYizNUSDRZrm5taiMhTUj6TKytDPmBn5Qt/8RZvMcfd8nI2JlSrXaoaalj+47wMJ0NEP3A8GZvdZeq1Mlp8lDvfnBhrqJgaMpExjyjhgyc/TfDo3Qs9WtVy9iUzH2hoPMOlHc7LObHOjGFhTbzxpK9Za/flGIbVpmsSctIPHUuBrbIK+mTX9qKWfod7DS1HnvNdU1vwzFmB/7ZO4zX1VWGKIxghQdryFCztskalKfIeU9lTvBhR0WCb11HGqp34r1N7qLZomj5V3bMYxtdYJI6pDnJiel+4Njx6Lc2Uk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR08MB5810.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(71200400001)(2906002)(508600001)(26005)(9686003)(7696005)(6506007)(33656002)(966005)(38100700002)(122000001)(8676002)(76116006)(4326008)(86362001)(66476007)(66946007)(38070700005)(66446008)(64756008)(66556008)(54906003)(5660300002)(316002)(52536014)(55016003)(110136005)(8936002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7193 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 30828618-da04-4e6f-54a7-08da38e463f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5pPl5+IYINo3D0zNbZUNoxJS41WXI45OLQ3xKRcoLqKwomQXg9oMe7Fwn2VhafvZLX4SqDOfbWquHNMgZe12TwRANKkqeodI5ox7PINKUErTKYSdAotQtIp0rsEn/U7pVDhTLYWZVWRb/fRzJ6bw79/W38hy6wGJhBeJ849B5CQNC8OxrQuT8KIxlZYdKHwL2z7skN/poBc2Wp/KkgMiODRt6jaSonF8phuRBN9fYU2VojOO8qic/7QgVVLJuPcMsXFTZF+SpsRBvoiQwIdR6gGq6szvo/WxOupcVmWebMXLcVu+j84UFeq5V6Y+KhkKQrx/5vxzY3mzVErfb9OhmGevCWSYkKtiKIKoEsp6uBtH9H/jOBhs+T0Kvd7pvThGiNBZHzYGJFaXQvJ6gEAz4JDrEZXj6NrFJrbu+yo0N58UUf6LJ5u1YVk7smvvRd3+DcLT3QM9Gh20EKybbcVOFAQZjKH2yBaYlcOpCszhDhu0TGglkTX86qdDeDfXZs6YRRm0X4Z00SODWj4MBG4pA5VBpUNtzz1BC7mtJtPpetx3Rm1xwCF0V6OebVZtysitt2/w3Hb/GHlXxYqrk0X6WiTmzSFvQjbVEmN7KpqTViulmvlrJdHBMQO/zXLOj2IR+r4rWcM7mlNttb519H2EwPmF+LS29ry+2nSmMHduUYRH3RjIEG/s8PgXlAQENP28m8K1RpTh2nES38o5XmpxvbQaAh0ffSqPHhcvHhRPJcG7Xqb4VgmucxD4kZ8+7XnuAb4HgZU0XT7q0wmfv3eYiQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(508600001)(55016003)(110136005)(6506007)(40460700003)(54906003)(26005)(82310400005)(9686003)(70586007)(36860700001)(5660300002)(2906002)(107886003)(186003)(4326008)(8676002)(7696005)(966005)(356005)(81166007)(70206006)(86362001)(8936002)(52536014)(336012)(47076005)(33656002)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 15:38:11.2701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86806d6f-e126-407a-8fac-08da38e46a43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7494 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > > > > > > > > The current naming of the base elements DTS works with is a bit > > > > > confusing, which this patch attemps to ameliorate. The basic > > > > > elements could be divided into and described in short as follows: > > > > > * A node: a broad term encompassing a host where any of the DTS > > > > > elements are present. This could be a physical or virtualized > > > > > server or a container. > > > > > > OK > > > > > > > > * The control node: the host where DTS runs > > > > > > OK > > > > > > > > * An SUT (system under test) node: This is where DPDK along with > > > > > the tested hardware resides. The system comprises DPDK and the > > hardware. > > > > > > Is there any difference between a SUT and a "tested node"? > > > > As defined above, the system under test is DPDK with the hardware we're > interested in testing (usually the devices DPDK works with). I'm not sure= what > the definition of a "tested node" is, but what would make senes to me is = that > the tested node would be the node where the SUT is located (the same as a= n > SUT node). > This definition rests on what a system is and do we apply that to our con= text, > for example: > a regularly interacting or interdependent group of items forming a unifie= d > whole [0] >=20 > I went with DPDK + the hardware it's using as the unified whole as those = are > the parts we're interested in, but the unified whole could reasonably mea= n > more than just DPDK + it's hardware (or, from another point of view, the > hardware we're testing utilizing DPDK). >=20 > [0] https://www.merriam-webster.com/dictionary/system >=20 I am not sure if Thomas is asking to change 'SUT' to 'tested node'. >From my side, 'SUT' is better. > > > > > * A traffic generator node: The node where the traffic generator > > > > > is present, such as Trex, Scapy or a hardware traffic generator (= e.g. > > > > > IXIA) > > > > > > OK > > > > > > > > All references to DUT were removed. This is because it was used > > > > > to mean both the server where DPDK/NIC are present and the DUT > > > > > (device under test, i.e. the NIC) in different contexts. Where > > > > > applicable, DUT was replaced with NIC and the rest were replaced > > > > > with SUT. With this change, it's clear what's meant and the > > > > > abbreviations are very different, which removes that layer of > confusion. > > > > > > "NIC" does not mean it is a device under test. > > > Also we could have other kind of devices under test, like crypto card= s. > > May be for other cards, we could use "XxxAccelerator"? We could leave > > "NIC" as is. > > > NIC is not necessarily a device under test, but a device under test could= be a > NIC in the proper context (such as when the tested device is a NIC, which= is > where the references to NICs). > Currently, when DTS docs or code mentions a NIC, it's always a NIC that's > being tested (and no other device type). In DTS, when DUT refers to a dev= ice, > it's always a NIC (meaning that when DTS refers to a NIC, it uses either = NIC or > DUT which this change unifies to just NIC). There are references to other > devices, such as QAT, but DUT is never used to refer to non-NIC devices. >=20 > We could use DUT to mean any type of device (NIC, QAT, other accelerators= ) > being tested, it's just that's not how it's used anywhere in DTS. >=20 > So the policy that this change brings is basically to refer to device typ= es (NIC, > QAT, etc.) instead of a broad category (DUT). Let us know whether this ma= kes > sense. I would prefer to refer to individual device types rather than a single wor= d that refers to all the device types. Also, it is not applicable here, we should refer to devices types in a gene= ral sense. For ex: QAT is specific to Intel's crypto device, we should use = 'Crypto' instead. >=20 > > > > > > > > Rename the following classes: > > > > > Crb -> Node > > > > > Dut -> SutNode > > > > > Tester -> TrafficGeneratorNode > > > > > DPDKdut -> DpdkSut > > > > > DPDKtester -> DpdkTrafficGenerator VirtDut -> VirtSut CrbsConf > > > > > -> TopologyConf PktgenConf -> PacketGeneratorConf > > > > > > I think you need to choose between "TrafficGenerator" and > > > "PacketGenerator". > > +1 for a single term > > > Agreed. We talked this over and we're going with TrafficGenerator. >=20 > > > > > >=20