From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A4FAA046B for ; Mon, 19 Aug 2019 07:28:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C1DA52BF1; Mon, 19 Aug 2019 07:28:48 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9A9AC2BE1 for ; Mon, 19 Aug 2019 07:28:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Aug 2019 22:28:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,403,1559545200"; d="scan'208";a="353137190" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 18 Aug 2019 22:28:46 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 22:28:45 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 22:28:45 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.19]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.112]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 13:28:43 +0800 From: "Mo, YufengX" To: "Fu, Qi" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to support nic of ipgre Thread-Index: AQHVVjQ7Unv8YVsfUUWvGeUrsYPn6qcB6qdg//9/UgCAAIdT8A== Date: Mon, 19 Aug 2019 05:28:42 +0000 Message-ID: References: <20190819110625.73544-1-qi.fu@intel.com> <20190819110625.73544-9-qi.fu@intel.com> <122BE83F39B639498C1565A7B0CDA2200113B95D@SHSMSX106.ccr.corp.intel.com> In-Reply-To: <122BE83F39B639498C1565A7B0CDA2200113B95D@SHSMSX106.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to support nic of ipgre X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi,fuqi You can try this, its logic will return False. Is it your expected? nic =3D 'fortville_spirit' print nic.startswith("fortville" and "carlsville") > -----Original Message----- > From: Fu, Qi > Sent: Monday, August 19, 2019 1:24 PM > To: Mo, YufengX ; dts@dpdk.org > Subject: RE: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to= support nic of ipgre >=20 > Hi, >=20 > Lijuan has reviewed these patchese and I have verified them before. > If use 'self.nic.startswith("fortville" or "carlsville")' it can't work, = but use 'self.nic.startswith("fortville" and "carlsville")' works well. >=20 > Best regards, > Fu, Qi >=20 >=20 > -----Original Message----- > From: Mo, YufengX > Sent: Monday, August 19, 2019 1:06 PM > To: Fu, Qi ; dts@dpdk.org > Cc: Fu, Qi > Subject: RE: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to= support nic of ipgre >=20 > Have your leader review your source code? Below checking syntax is wrong >=20 >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of qifu > > Sent: Monday, August 19, 2019 7:06 PM > > To: dts@dpdk.org > > Cc: Fu, Qi > > Subject: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to > > support nic of ipgre > > > > Add carlsville to support nic of ipgre. > > Signed-off-by: qifu > > --- > > tests/TestSuite_ipgre.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index > > 6f465fa..04fd651 100644 > > --- a/tests/TestSuite_ipgre.py > > +++ b/tests/TestSuite_ipgre.py > > @@ -63,7 +63,7 @@ class TestIpgre(TestCase): > > """ > > self.printFlag =3D self._enable_debug > > ports =3D self.dut.get_ports() > > - self.verify(self.nic.startswith("fortville"), > > + self.verify(self.nic.startswith("fortville" and > > + "carlsville"), > > "GRE tunnel packet type only support by Fortville"= ) > > self.verify(len(ports) >=3D 1, "Insufficient ports for testing= ") > > valports =3D [_ for _ in ports if self.tester.get_local_port(_= ) > > !=3D -1] > > -- > > 2.17.1