* [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting
@ 2019-08-08 6:22 yufengmx
2019-08-08 6:22 ` [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: yufengmx @ 2019-08-08 6:22 UTC (permalink / raw)
To: dts; +Cc: yufengmx
These commits are internal bugs fixed, which are reported by ma,lihong
*. add missing rate percent key of stream config option in pktgen module.
*. add missing start traffic option input in measure_throughput method.
yufengmx (2):
framework/pktgen_base: fix measure_throughput missed option input
framework/pktgen: fix PacketGeneratorHelper missed rate setting
framework/pktgen.py | 1 +
framework/pktgen_base.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option
2019-08-08 6:22 [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting yufengmx
@ 2019-08-08 6:22 ` yufengmx
2019-08-28 6:52 ` Ma, LihongX
2019-08-08 6:22 ` [dts] [PATCH V2 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate yufengmx
2019-08-08 6:25 ` [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting Mo, YufengX
2 siblings, 1 reply; 5+ messages in thread
From: yufengmx @ 2019-08-08 6:22 UTC (permalink / raw)
To: dts; +Cc: yufengmx
input
add missing _start_transmission options input in measure_throughput method.
Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
framework/pktgen_base.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/pktgen_base.py b/framework/pktgen_base.py
index e9d3fcb..85b54cf 100644
--- a/framework/pktgen_base.py
+++ b/framework/pktgen_base.py
@@ -170,7 +170,7 @@ class PacketGenerator(object):
bps_rx = []
pps_rx = []
self._prepare_transmission(stream_ids=stream_ids)
- self._start_transmission(stream_ids)
+ self._start_transmission(stream_ids, options)
delay = options.get('delay') or 5
time.sleep(delay)
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option
2019-08-08 6:22 ` [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
@ 2019-08-28 6:52 ` Ma, LihongX
0 siblings, 0 replies; 5+ messages in thread
From: Ma, LihongX @ 2019-08-28 6:52 UTC (permalink / raw)
To: Mo, YufengX, dts; +Cc: Mo, YufengX
tested-by: lihong<lihongx.ma@intel.com>
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
Sent: Thursday, August 8, 2019 2:23 PM
To: dts@dpdk.org
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option
input
add missing _start_transmission options input in measure_throughput method.
Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
framework/pktgen_base.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/pktgen_base.py b/framework/pktgen_base.py index e9d3fcb..85b54cf 100644
--- a/framework/pktgen_base.py
+++ b/framework/pktgen_base.py
@@ -170,7 +170,7 @@ class PacketGenerator(object):
bps_rx = []
pps_rx = []
self._prepare_transmission(stream_ids=stream_ids)
- self._start_transmission(stream_ids)
+ self._start_transmission(stream_ids, options)
delay = options.get('delay') or 5
time.sleep(delay)
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V2 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate
2019-08-08 6:22 [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting yufengmx
2019-08-08 6:22 ` [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
@ 2019-08-08 6:22 ` yufengmx
2019-08-08 6:25 ` [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting Mo, YufengX
2 siblings, 0 replies; 5+ messages in thread
From: yufengmx @ 2019-08-08 6:22 UTC (permalink / raw)
To: dts; +Cc: yufengmx
setting
add missing stream rate option in prepare_stream_from_tginput method.
Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
framework/pktgen.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/framework/pktgen.py b/framework/pktgen.py
index 1c8acac..2c6cf7f 100644
--- a/framework/pktgen.py
+++ b/framework/pktgen.py
@@ -194,6 +194,7 @@ class PacketGeneratorHelper(object):
pcap = config[2]
_options = deepcopy(self.default_opt)
_options['pcap'] = pcap
+ _options['stream_config']['rate'] = ratePercent
# if vm is set
if vm_config:
_options['fields_config'] = \
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting
2019-08-08 6:22 [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting yufengmx
2019-08-08 6:22 ` [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
2019-08-08 6:22 ` [dts] [PATCH V2 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate yufengmx
@ 2019-08-08 6:25 ` Mo, YufengX
2 siblings, 0 replies; 5+ messages in thread
From: Mo, YufengX @ 2019-08-08 6:25 UTC (permalink / raw)
To: dts, Tu, Lijuan
Hi, would you review series again?
> -----Original Message-----
> From: Mo, YufengX
> Sent: Thursday, August 8, 2019 2:23 PM
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V2 0/2] dts/pktgen: fix missing parameter setting
>
> These commits are internal bugs fixed, which are reported by ma,lihong
>
> *. add missing rate percent key of stream config option in pktgen module.
> *. add missing start traffic option input in measure_throughput method.
>
> yufengmx (2):
> framework/pktgen_base: fix measure_throughput missed option input
> framework/pktgen: fix PacketGeneratorHelper missed rate setting
>
> framework/pktgen.py | 1 +
> framework/pktgen_base.py | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-28 6:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 6:22 [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting yufengmx
2019-08-08 6:22 ` [dts] [PATCH V2 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
2019-08-28 6:52 ` Ma, LihongX
2019-08-08 6:22 ` [dts] [PATCH V2 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate yufengmx
2019-08-08 6:25 ` [dts] [PATCH V2 0/2] dts/pktgen: fix missing parameter setting Mo, YufengX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).