From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97120A0613 for ; Thu, 26 Sep 2019 05:26:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 560439E4; Thu, 26 Sep 2019 05:26:22 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3F2A6271 for ; Thu, 26 Sep 2019 05:26:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 20:26:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,550,1559545200"; d="scan'208";a="180028613" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 25 Sep 2019 20:26:19 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 20:26:18 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 20:26:17 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 11:26:16 +0800 From: "Ma, LihongX" To: "Mo, YufengX" , "Zhang, YanX A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm Thread-Index: AQHVdBT1cF2XC38URUGmL5pDozBrgKc9QvqAgAACgbCAAAGzgIAAAuUAgAABhrA= Date: Thu, 26 Sep 2019 03:26:16 +0000 Message-ID: References: <1569368930-13898-1-git-send-email-lihongx.ma@intel.com> <2C49E4B25FAD1D419F7564D633EF72E1F490C4@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, yufen Very thanks about review for my patch. I am glad for it. -----Original Message----- From: Mo, YufengX=20 Sent: Thursday, September 26, 2019 11:24 AM To: Ma, LihongX ; Zhang, YanX A ; dts@dpdk.org Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before = connect to vm Hi, lihong =20 Ok, It is my mis-understanding. Ignore my comment. > -----Original Message----- > From: Ma, LihongX > Sent: Thursday, September 26, 2019 11:18 AM > To: Mo, YufengX ; Zhang, YanX A ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen befor= e connect to vm >=20 > Hi,yufeng > Yes, the code will change the tester ssh config when dts run on tester. > The qemu is start on the dut, but the connect is from the tester, so I ch= ange the ssh config on tester. >=20 > -----Original Message----- > From: Mo, YufengX > Sent: Thursday, September 26, 2019 11:06 AM > To: Ma, LihongX ; Zhang, YanX A ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen befor= e connect to vm >=20 > Hi,ma lihong >=20 > When dts is running on tester node(tester/dut not the same node), these c= ode change the tester ssh config. >=20 > But virtual machine is running on dut, virtual machine's ip address is as= signed by dut/qemu and is managed by dut/libvirt tool. >=20 >=20 > > -----Original Message----- > > From: Ma, LihongX > > Sent: Thursday, September 26, 2019 11:00 AM > > To: Mo, YufengX ; Zhang, YanX A ; dts@dpdk.org > > Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen bef= ore connect to vm > > > > Hi, yufeng > > Yan has verify this scenes, the dts and dut not on same server. > > And i think all the session connect is from the server which run dts, s= o it can not use the self.host_session. > > > > -----Original Message----- > > From: Mo, YufengX > > Sent: Thursday, September 26, 2019 10:49 AM > > To: Zhang, YanX A ; dts@dpdk.org > > Cc: Ma, LihongX > > Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen bef= ore connect to vm > > > > Hi,zhangyan > > > > when dts doesn't run on dut, your fix will malfunction. > > > > In LibvirtKvm class, use self.host_session.send_expect to do action on = the node, which run virtual machine using libvirt tool. > > > > BRs > > Yufen, Mo > > > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhang, YanX A > > > Sent: Wednesday, September 25, 2019 3:18 PM > > > To: Ma, LihongX ; dts@dpdk.org > > > Cc: Ma, LihongX > > > Subject: Re: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen b= efore connect to vm > > > > > > Tested-by: Zhang, YanX A > > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong > > > Sent: Wednesday, September 25, 2019 7:49 AM > > > To: dts@dpdk.org > > > Cc: Ma, LihongX > > > Subject: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen befor= e connect to vm > > > > > > Signed-off-by: lihong > > > --- > > > framework/qemu_libvirt.py | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/framework/qemu_libvirt.py b/framework/qemu_libvirt.py in= dex d2edd31..5b25dec 100644 > > > --- a/framework/qemu_libvirt.py > > > +++ b/framework/qemu_libvirt.py > > > @@ -817,6 +817,9 @@ class LibvirtKvm(VirtBase): > > > while count: > > > out =3D self.__control_session('ifconfig') > > > if "10.0.2" in out: > > > + pos =3D self.vm_ip.find(':') > > > + ssh_key =3D '[' + self.vm_ip[:pos] + ']' + self.vm_i= p[pos:] > > > + os.system('ssh-keygen -R %s' % ssh_key) > > > return True > > > time.sleep(6) > > > count -=3D 1 > > > -- > > > 2.7.4