From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 992F6A3201 for ; Mon, 21 Oct 2019 03:16:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65804F72; Mon, 21 Oct 2019 03:16:26 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 50F80F11 for ; Mon, 21 Oct 2019 03:16:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 18:16:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,321,1566889200"; d="scan'208";a="372031280" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 20 Oct 2019 18:16:22 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 18:16:22 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 18:16:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX151.ccr.corp.intel.com ([10.239.6.50]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 09:16:20 +0800 From: "Ma, LihongX" To: "Peng, ZhihongX" , "dts@dpdk.org" CC: "Peng, ZhihongX" Thread-Topic: [dts] [PATCH V1] Packets larger than mtu 8 bytes can be received by cvl; the portstats command must be executed when the program starts to receive packets as large as mtu. Thread-Index: AQHVhL6xi565r+ooFk65J9t/Y3JV6KdkT6lw Date: Mon, 21 Oct 2019 01:16:19 +0000 Message-ID: References: <20191017154412.13493-1-zhihongx.peng@intel.com> In-Reply-To: <20191017154412.13493-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] Packets larger than mtu 8 bytes can be received by cvl; the portstats command must be executed when the program starts to receive packets as large as mtu. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, zhihong I think you can use the value 'offset' instead of you 'ice_eth_overhead', = reset the offset value like ['powerville', 'springville'],=20 Then you does not need to judge nic type when create Packet. And I think yo= u can write the jira bug id in the file. -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong Sent: Thursday, October 17, 2019 11:44 PM To: dts@dpdk.org Cc: Peng, ZhihongX Subject: [dts] [PATCH V1] Packets larger than mtu 8 bytes can be received b= y cvl; the portstats command must be executed when the program starts to re= ceive packets as large as mtu. Signed-off-by: Peng Zhihong --- tests/TestSuite_userspace_ethtool.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspa= ce_ethtool.py index 116fd3a..bdbbea3 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -546,6 +546,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerato= r): mtus =3D [1519, 2048] mtu_threshold =3D 2022 offset =3D 0 + ice_eth_overhead =3D 8 if self.nic in ['powerville', 'springville']: mtu_threshold =3D 2026 offset =3D 4 @@ -561,10 +562,10 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenera= tor): if mtu > mtu_threshold: if self.nic in ['powerville', 'springville']: mtu =3D mtu_threshold - self.dut.send_expect("stop %s" % index, "EthApp>") - self.dut.send_expect("mtu %d %d" % (index, mtu), "EthA= pp>") - self.dut.send_expect("open %s" % index, "EthApp>") + self.dut.send_expect("stop %s" % index, "EthApp>") self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>"= ) + self.dut.send_expect("open %s" % index, "EthApp>") + self.dut.send_expect("portstats %d" % (index),=20 + "EthApp>") time.sleep(5) ori_rx_pkts, _ =3D self.strip_portstats(index) pkt_size =3D mtu + HEADER_SIZE['eth'] + offset @@ -572,7 += 573,10 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator): pkt.send_pkt(self.tester, tx_port=3Dintf, count=3D4) rx_pkts, _ =3D self.strip_portstats(index) self.verify(rx_pkts =3D=3D ori_rx_pkts + 4, "Packet match = mtu not forwarded as expected") - pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3Dmtu + 1 + HEADE= R_SIZE['eth'] + offset) + if self.nic in ['columbiaville_25g', 'columbiaville_100g']= : + pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3Dmtu + ice_e= th_overhead + 1 + HEADER_SIZE['eth'] + offset) + else: + pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3Dmtu + 1 +=20 + HEADER_SIZE['eth'] + offset) pkt.send_pkt(self.tester, tx_port=3Dintf, count=3D4) rx_pkts_over, _ =3D self.strip_portstats(index) self.verify(rx_pkts =3D=3D rx_pkts_over, "Packet over mtu = should not be forwarded") -- 2.17.1