Re: [dts] [PATCH V1] tests/flow_filtering: automation of flow_filtering

["Ma, LihongX" <lihongx.ma@intel.com>]

Hi, xiaoxiao
I have some comments as below.

BR
lihong

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
Sent: Friday, October 25, 2019 2:49 AM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V1] tests/flow_filtering: automation of flow_filtering

*.add automation scripts according to flow_filtering test plan

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_flow_filtering.py | 110 ++++++++++++++++++++++++++++++
 1 file changed, 110 insertions(+)
 create mode 100644 tests/TestSuite_flow_filtering.py

diff --git a/tests/TestSuite_flow_filtering.py b/tests/TestSuite_flow_filtering.py
new file mode 100644
index 0000000..60511dc
--- /dev/null
+++ b/tests/TestSuite_flow_filtering.py
@@ -0,0 +1,110 @@
+# BSD LICENSE
+#

Lihong: change 2010-2019 to <2019>
+# Copyright(c) 2010-2019 Intel Corporation. All rights reserved.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without # 
+modification, are permitted provided that the following conditions # 
+are met:
+#
+#   * Redistributions of source code must retain the above copyright
+#     notice, this list of conditions and the following disclaimer.
+#   * Redistributions in binary form must reproduce the above copyright
+#     notice, this list of conditions and the following disclaimer in
+#     the documentation and/or other materials provided with the
+#     distribution.
+#   * Neither the name of Intel Corporation nor the names of its
+#     contributors may be used to endorse or promote products derived
+#     from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS # 
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT # 
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR # 
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT # 
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, # 
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT # 
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, # 
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY # 
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT # 
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # 
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import os
+import utils
+import time
+import re
+import os
+from test_case import TestCase
+from settings import HEADER_SIZE
+
+
+class TestFlowFiltering(TestCase):
+
+    def set_up_all(self):
+        """
+        Run before each test suite
+        """
+        # initialize ports topology
+        self.dut_ports = self.dut.get_ports(self.nic)
+        # Verify that enough ports are available
+        self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")

Lihong: the command is useless, because framework have set this command
+        self.dut.send_expect("export RTE_SDK=`pwd`", "#")
+        out = self.dut.build_dpdk_apps("./examples/flow_filtering/")
+        self.verify('Error' not in out, "Compilation failed")
+
+    def set_up(self):
+        """
+        Run before each test case.
+        """

Lihong: the self.dts_mac is fixed, so I think you can put this value in set_up_all
+        self.dts_mac = self.dut.get_mac_address(self.dut_ports[0])
+        self.dut.send_expect("./examples/flow_filtering/build/flow -l 1 
+ -n 1", "initializing port", 100)
+
+
+    def send_packet(self, pkg):
+        """
+        Send packets according to parameters.
+        """

Lihong: please use the Packet method to send pkt
+        txitf = 
+ self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]
+ ))
+
+        self.tester.scapy_foreground()
+        self.tester.scapy_append('sendp(%s, iface="%s")' % (pkg, txitf))
+        self.tester.scapy_execute()
+        time.sleep(3)
+
+    def check_flow_queue(self):
+        '''
+        Get dut flow result
+        '''

Lihong: the default timeout of function get_session_ouput is 15s, in this suite, I think timeout=2 is enough, 15s will too long.
+        result = self.dut.get_session_output()
+        self.verify("queue" in result, "Dut receive flow failed!")
+        queue_result = re.findall(r"queue=(\S+)", result)
+        return queue_result
+
+    def test_flow_filtering_match_rule(self):
+
+        pkg_list = ['Ether(dst="%s")/IP(src="0.0.0.0", dst="192.168.1.1")/Raw("x"*20)' % self.dts_mac,
+                    'Ether(dst="%s")/IP(src="0.0.0.1", dst="192.168.1.1")/Raw("x"*20)' % self.dts_mac]
+        for pkg in pkg_list:
+            self.send_packet(pkg)
+
+        queue_list = self.check_flow_queue()
+        self.verify(len(queue_list) == 2, "Dut receive flow queue error!")
+        self.verify(queue_list[0] == queue_list[1] and queue_list[0] == 
+ "0x1", "Flow filter not match rule!")
+
+    def test_flow_filtering_dismatch_rule(self):
+        pkg = 'Ether(dst="%s")/IP(src="0.0.0.0", dst="192.168.1.2")/Raw("x"*20)' % self.dts_mac
+        self.send_packet(pkg)
+        queue_list = self.check_flow_queue()
+        self.verify(len(queue_list) == 1 and queue_list[0] == "0x0", 
+ "Dismatch rule failed!")
+
+    def tear_down(self):
+        """
+        Run after each test case.
+        """
+        self.dut.send_expect("^C", "#")
+
+    def tear_down_all(self):
+        """
+        Run after each test suite.
+        """
+        self.dut.kill_all()
--
2.17.0