From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A0CFA00BE; Thu, 31 Oct 2019 07:50:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 157171C1CD; Thu, 31 Oct 2019 07:50:52 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0CBB21C1CA for ; Thu, 31 Oct 2019 07:50:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 23:50:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="190527648" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 30 Oct 2019 23:50:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 30 Oct 2019 23:50:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 30 Oct 2019 23:50:47 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 30 Oct 2019 23:50:47 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Thu, 31 Oct 2019 14:50:46 +0800 From: "Ma, LihongX" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V1] tests/dual_vlan:modify the command to set vlan Thread-Index: AQHVjgpENxgaImbgu06RfSbWQuotzKd0Uq5g Date: Thu, 31 Oct 2019 06:50:44 +0000 Message-ID: References: <1572320565-72409-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1572320565-72409-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/dual_vlan:modify the command to set vlan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, Lijuan You can ignore this patch, because wenhui have submit patch V2 : [dts] [PAT= CH V2] tests/dual_vlan:replace qinq with extend BR lihong -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu wenhui Sent: Tuesday, October 29, 2019 11:43 AM To: dts@dpdk.org Cc: Zhu, WenhuiX Subject: [dts] [PATCH V1] tests/dual_vlan:modify the command to set vlan Change the command according to the modification of DPDK-2a0b41984c7 Signed-off-by: zhu wenhui --- tests/TestSuite_dual_vlan.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py in= dex 9cb3879..066a45d 100644 --- a/tests/TestSuite_dual_vlan.py +++ b/tests/TestSuite_dual_vlan.py @@ -176,8 +176,8 @@ class TestDualVlan(TestCase): self.dut.send_expect("rx_vlan rm %s %s" % (outvlan= , dutRxPortId), "testpmd> ") continue =20 - if mode =3D=3D "qinq": - self.verify("qinq(extend) %s" % modeName[mode] in out, "%s= setting error" % mode) + if mode =3D=3D "qinq_strip": + self.verify("qinq strip %s" % modeName[mode] in out,=20 + "%s setting error" % mode) continue elif mode =3D=3D "stripq": continue @@ -208,7 +208,7 @@ class TestDualVlan(TestCase): if (self.nic in ["cavium_a063", "cavium_a064"]) and temp[2] =3D=3D= "on": ## Skip QinQ for cavium devices as it is not supported. return - self.mode_config(strip=3Dtemp[0], filter=3Dtemp[1], qinq=3Dtemp[2]= ) + self.mode_config(strip=3Dtemp[0], filter=3Dtemp[1],=20 + qinq_strip=3Dtemp[2]) =20 if (caseDef & txCase) !=3D 0: self.dut.send_expect('stop', "testpmd> ") @@ -280,7 +280,7 @@ = class TestDualVlan(TestCase): """ self.mode_config(filter=3D"on") self.mode_config(strip=3D"off") - self.mode_config(qinq=3D"off") + self.mode_config(qinq_strip=3D"off") self.vlan_send_packet(outvlan) out =3D self.get_tcpdump_package() print out @@ -305,7 +305,7 @@ class TestDualVlan(TestCase): =20 self.mode_config(filter=3D"on") self.mode_config(strip=3D"off") - self.mode_config(qinq=3D"off") + self.mode_config(qinq_strip=3D"off") =20 self.dut.send_expect("rx_vlan add %s %s" % (outvlan, dutRxPortId),= "testpmd> ") self.vlan_send_packet(outvlan) @@ -323,7 +323,7 @@ class TestDualVlan(TestCase): """ =20 self.mode_config(filter=3D"off") - self.mode_config(qinq=3D"off") + self.mode_config(qinq_strip=3D"off") self.mode_config(strip=3D"on") if self.nic in [ "columbiaville_25g", "columbiaville_100g", "fortv= ille_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g"= , "fortpark_TLV", "carlsville"]: self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPort= Id), "testpmd> ") @@ -345,7 +345,7 @@ class TestDualVlan(TestCase): self.verify(self.nic not in ["columbiaville_25g", "columbiaville_1= 00g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fo= rtville_25g", "fortpark_TLV", "cavium_a063", "cavium_a064", "carlsville"], = "%s NIC not support queue vlan strip " % self.nic) =20 self.mode_config(filter=3D"off") - self.mode_config(qinq=3D"off") + self.mode_config(qinq_strip=3D"off") self.mode_config(strip=3D"off") self.mode_config(stripq=3D"off") if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_= spirit_single", "fortville_25g", "fortpark_TLV", "carlsville"]: @@ -372,7 +372,7 @@ class TestDualVlan(TestCase): Enable/Disable VLAN packets inserting """ self.mode_config(filter=3D"off") - self.mode_config(qinq=3D"off") + self.mode_config(qinq_strip=3D"off") =20 # hartwell need to set CTRL.VME for vlan insert if(self.nic =3D=3D "hartwell"): @@ -406,7 +406,7 @@ class TestDualVlan(TestCase): """ self.verify(self.nic not in ["columbiaville_25g", "columbiaville_1= 00g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fo= rtville_25g", "fortpark_TLV", "hartwell", "carlsville"], "%s NIC not suppor= t tcpid " % self.nic) =20 - self.mode_config(filter=3D"on", strip=3D"on", qinq=3D"on") + self.mode_config(filter=3D"on", strip=3D"on", qinq_strip=3D"on") # nic only support inner model, except fortville nic self.dut.send_expect("vlan set inner tpid 1234 %s" % dutRxPortId, = "testpmd> ") self.vlan_send_packet(outvlan, invlan) -- 2.17.2