test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd
Date: Thu, 31 Oct 2019 07:21:43 +0000	[thread overview]
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB256E4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1572418779-87768-1-git-send-email-weix.xie@intel.com>

Hi, xiewei
As the commit 2a0b41984c7 , we will use the ' vlan set extend on' instead of 'vlan set qinq on'
And if we will identification the packet as Qin vlan pkts, so we should add 'vlan set strip on xx' before 'vlan set extend on'

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
Sent: Wednesday, October 30, 2019 3:00 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd

change testpmd cmd in dpdk-2a0b41984c7

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_vlan_ethertype_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vlan_ethertype_config.py b/tests/TestSuite_vlan_ethertype_config.py
index 33e9948..d66f0d3 100644
--- a/tests/TestSuite_vlan_ethertype_config.py
+++ b/tests/TestSuite_vlan_ethertype_config.py
@@ -344,7 +344,7 @@ class TestVlanEthertypeConfig(TestCase):
         random_vlan = random.randint(1, MAX_VLAN - 1)
         rx_vlans = [1, random_vlan, MAX_VLAN]
         self.dut.send_expect(
-            "vlan set qinq on %d" % dutRxPortId, "testpmd> ", 20)
+            "vlan set qinq_strip on %d" % dutRxPortId, "testpmd> ", 20)
         self.dut.send_expect("set verbose 1", "testpmd> ")
         self.dut.send_expect("set fwd rxonly", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
-- 
2.17.2


      reply	other threads:[~2019-10-31  7:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  6:59 Xie Wei
2019-10-31  7:21 ` Ma, LihongX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB256E4@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).