test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>
Subject: Re: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in	tear_down
Date: Mon, 4 Nov 2019 02:07:34 +0000	[thread overview]
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB25B86@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191101145956.28773-1-xiaoxiaox.zeng@intel.com>

Hi, xiaoxiao
In this suite, the scapy is called multiple times, so I think you should put the command `self.tester.send_expect("killall scapy", "#", 5)`  in tear_down instead of tear_down_all
And by the way ,after kill the scapy, the session ' self.send_packets_session' which create by tester should ' destroy_session' too.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
Sent: Friday, November 1, 2019 11:00 PM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down

*.This suit not close send_package tool,it make next suit's testpmd get large rx_pakage when start

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_multiple_pthread.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_multiple_pthread.py b/tests/TestSuite_multiple_pthread.py
index 1ea71a5..f247751 100644
--- a/tests/TestSuite_multiple_pthread.py
+++ b/tests/TestSuite_multiple_pthread.py
@@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
         """
         Run after each test suite.
         """
-        pass
+        self.tester.send_expect("killall scapy", "#", 5)
-- 
2.17.0


  reply	other threads:[~2019-11-04  2:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 14:59 Xiaoxiao Zeng
2019-11-04  2:07 ` Ma, LihongX [this message]
2019-11-22  3:30 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB25B86@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=xiaoxiaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).