* [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down
@ 2019-11-01 14:59 Xiaoxiao Zeng
2019-11-04 2:07 ` Ma, LihongX
2019-11-22 3:30 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: Xiaoxiao Zeng @ 2019-11-01 14:59 UTC (permalink / raw)
To: dts; +Cc: Xiaoxiao Zeng
*.This suit not close send_package tool,it make next suit's testpmd get large rx_pakage when start
Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
tests/TestSuite_multiple_pthread.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_multiple_pthread.py b/tests/TestSuite_multiple_pthread.py
index 1ea71a5..f247751 100644
--- a/tests/TestSuite_multiple_pthread.py
+++ b/tests/TestSuite_multiple_pthread.py
@@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
"""
Run after each test suite.
"""
- pass
+ self.tester.send_expect("killall scapy", "#", 5)
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down
2019-11-01 14:59 [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down Xiaoxiao Zeng
@ 2019-11-04 2:07 ` Ma, LihongX
2019-11-22 3:30 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Ma, LihongX @ 2019-11-04 2:07 UTC (permalink / raw)
To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX
Hi, xiaoxiao
In this suite, the scapy is called multiple times, so I think you should put the command `self.tester.send_expect("killall scapy", "#", 5)` in tear_down instead of tear_down_all
And by the way ,after kill the scapy, the session ' self.send_packets_session' which create by tester should ' destroy_session' too.
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
Sent: Friday, November 1, 2019 11:00 PM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down
*.This suit not close send_package tool,it make next suit's testpmd get large rx_pakage when start
Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
tests/TestSuite_multiple_pthread.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_multiple_pthread.py b/tests/TestSuite_multiple_pthread.py
index 1ea71a5..f247751 100644
--- a/tests/TestSuite_multiple_pthread.py
+++ b/tests/TestSuite_multiple_pthread.py
@@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
"""
Run after each test suite.
"""
- pass
+ self.tester.send_expect("killall scapy", "#", 5)
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down
2019-11-01 14:59 [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down Xiaoxiao Zeng
2019-11-04 2:07 ` Ma, LihongX
@ 2019-11-22 3:30 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-22 3:30 UTC (permalink / raw)
To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX
It's not a good idea to kill all scapy, it will impact other users who is also using scapy but another process.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Friday, November 1, 2019 11:00 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in
> tear_down
>
> *.This suit not close send_package tool,it make next suit's testpmd get large
> rx_pakage when start
>
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
> tests/TestSuite_multiple_pthread.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_multiple_pthread.py
> b/tests/TestSuite_multiple_pthread.py
> index 1ea71a5..f247751 100644
> --- a/tests/TestSuite_multiple_pthread.py
> +++ b/tests/TestSuite_multiple_pthread.py
> @@ -237,4 +237,4 @@ class TestMultiplePthread(TestCase):
> """
> Run after each test suite.
> """
> - pass
> + self.tester.send_expect("killall scapy", "#", 5)
> --
> 2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-22 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 14:59 [dts] [PATCH V1] tests/ multiple_pthread: add killall scapy in tear_down Xiaoxiao Zeng
2019-11-04 2:07 ` Ma, LihongX
2019-11-22 3:30 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).