From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57524A04A2; Wed, 6 Nov 2019 02:11:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E4981BFC3; Wed, 6 Nov 2019 02:11:57 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 319711BFC0 for ; Wed, 6 Nov 2019 02:11:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 17:11:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="232686081" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 05 Nov 2019 17:11:53 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:11:53 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:11:53 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 09:11:51 +0800 From: "Ma, LihongX" To: "Zhu, ShuaiX" , "dts@dpdk.org" CC: "Wang, Yinan" , "Zhu, ShuaiX" Thread-Topic: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS Thread-Index: AQHVk6CiGBGlqPc7F0Gi2aS/JSGl7ad9VQ8A Date: Wed, 6 Nov 2019 01:11:50 +0000 Message-ID: References: <1572934913-57413-1-git-send-email-shuaix.zhu@intel.com> In-Reply-To: <1572934913-57413-1-git-send-email-shuaix.zhu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, shuai I think you time.sleep(3) should add after the command ' self.vhost_seconda= ry.send_expect(final_cmd_secondary, " ", 120)' Because you only wait the first app but not wait the second app. And I think you can use ' Checking' or 'Port' instead of ' ' as a expected = word. -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai Sent: Tuesday, November 5, 2019 2:22 PM To: dts@dpdk.org Cc: Wang, Yinan ; Zhu, ShuaiX Subject: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS RSS is not support by virito device and will thus will return error configu= re device with RSS enabled. Need to disable RSS when configuring virtio dev= ice. Signed-off-by: zhu,shuai --- tests/TestSuite_vdev_primary_secondary.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/TestSuite_vdev_primary_secondary.py b/tests/TestSuite_vd= ev_primary_secondary.py index 8b7b899..102a9e0 100644 --- a/tests/TestSuite_vdev_primary_secondary.py +++ b/tests/TestSuite_vdev_primary_secondary.py @@ -119,6 +119,7 @@ class TestVdevPrimarySecondary(TestCase): final_cmd_first =3D example_cmd_auto % (self.mem_channels, self.qu= eues) final_cmd_secondary =3D example_cmd_secondary % (self.mem_channels= , self.queues) self.vhost_first.send_expect(final_cmd_first, " ", 120) + time.sleep(3) self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120) =20 =20 @@ -126,6 +127,8 @@ class TestVdevPrimarySecondary(TestCase): self.vm_dut.send_expect("cp ./examples/multi_process/symmetric_mp/= main.c .", "#") self.vm_dut.send_expect( "sed -i '/.offloads =3D DEV_RX_OFFLOAD_CHECKSUM,/d' ./exam= ples/multi_process/symmetric_mp/main.c", "#") + self.vm_dut.send_expect( + "sed -i 's/.mq_mode =3D ETH_MQ_RX_RSS,/.mq_mode = =3D ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "= #") out =3D self.vm_dut.build_dpdk_apps('./examples/multi_process/symm= etric_mp') self.verify("Error" not in out, "compilation symmetric_mp error") =20 --=20 2.17.2