Re: [dts] [PATCH V1] tests/port_representor:automation of port_representor

["Ma, LihongX" <lihongx.ma@intel.com>]

Hi, xiewei
Same comments as below.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
Sent: Monday, November 11, 2019 5:21 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1] tests/port_representor:automation of port_representor

new automation of port_representor according to test plan

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_port_representor.py | 291 ++++++++++++++++++++++++++++
 1 file changed, 291 insertions(+)
 create mode 100644 tests/TestSuite_port_representor.py

diff --git a/tests/TestSuite_port_representor.py b/tests/TestSuite_port_representor.py
new file mode 100644
index 0000000..eac8491
--- /dev/null
+++ b/tests/TestSuite_port_representor.py
@@ -0,0 +1,291 @@
+# BSD LICENSE
+#
+# Copyright(c) 2010-2019 Intel Corporation. All rights reserved.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without # 
+modification, are permitted provided that the following conditions # 
+are met:
+#
+#   * Redistributions of source code must retain the above copyright
+#     notice, this list of conditions and the following disclaimer.
+#   * Redistributions in binary form must reproduce the above copyright
+#     notice, this list of conditions and the following disclaimer in
+#     the documentation and/or other materials provided with the
+#     distribution.
+#   * Neither the name of Intel Corporation nor the names of its
+#     contributors may be used to endorse or promote products derived
+#     from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS # 
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT # 
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR # 
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT # 
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, # 
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT # 
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, # 
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY # 
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT # 
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # 
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+"""
+Use two representor ports as the control plane to manage the two VFs, 
+the control plane could change VFs behavior such as change promiscous 
+mode, stats reset, etc. our statistical data information is independent 
+on the control plane and data plane.
+"""
+
+import time
+import re
+
+from test_case import TestCase
+from dut import Dut
+from packet import Packet
+
+
+class TestPortRepresentor(TestCase):
+    def set_up_all(self):
+        """
+        Prerequisite steps for each test suite.
+        """
+        self.verify(self.nic in ["fortville_eagle", "fortville_spirit",
+                                 "fortville_spirit_single", "fortville_25g"], "NIC Unsupported: " + str(self.nic))
+        self.dut_ports = self.dut.get_ports(self.nic)
+        self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
+
+        self.session_secondary = self.dut.new_session()
+        self.session_third = self.dut.new_session()
+
+        localPort = self.tester.get_local_port(self.dut_ports[0])
+        self.tester_itf = self.tester.get_interface(localPort)
+        self.tester_mac = self.tester.get_mac(localPort)
+        self.pf_interface = self.dut.ports_info[self.dut_ports[0]]['intf']
+        self.pf_mac = self.dut.get_mac_address(0)
+        self.pf_pci = self.dut.ports_info[self.dut_ports[0]]['pci']
+
+        self.unicast_mac = "00:11:22:33:44:55"
+
+        # This is to set up 1pf and 2vfs environment
+        # PF is bound to igb_uio, while VF is bound to vfio-pci.

#Lihong: about the driver igb_uio, before run the suite, it is have been set in framework, so I think this step is uesless
+        self.dut.send_expect("modprobe uio", "#", 70)
+        self.dut.send_expect("insmod ./" + self.target + "/kmod/igb_uio.ko", "#", 60)
+        self.dut.send_expect("modprobe vfio-pci", "#", 70)
+
+        self.dut.generate_sriov_vfs_by_port(self.dut_ports[0], 2, "igb_uio")
+        self.two_vfs_port = self.dut.ports_info[self.dut_ports[0]]["vfs_port"]
+        try:
+            for port in self.two_vfs_port:
+                port.bind_driver(driver="vfio-pci")
+        except Exception as e:
+            self.destroy_env()
+            raise Exception(e)
+        self.vfs_pci = 
+ self.dut.ports_info[self.dut_ports[0]]['sriov_vfs_pci']
+
+    def set_up(self):
+        """
+        Run before each test case.
+        """
+        self.vf_flag = 1
+
+    def destroy_env(self):
+        """
+        This is to stop testpmd and destroy 1pf and 2vfs environment.
+        """
+        if self.vf_flag == 1:
+            self.session_third.send_expect("quit", "#")
+            time.sleep(3)
+            self.session_secondary.send_expect("quit", "#")
+            time.sleep(3)
+            self.dut.send_expect("quit", "#")
+            time.sleep(3)
+        else:
+            self.dut.send_expect("quit", "#")
+        self.vf_flag = 0
+
+    def testpmd_pf(self):

# lihong: please do not use the hard core for lcores, and use the create_eal_parameters in dut to create the eal params to start testpmd
+        cmd_pf = "./%s/app/testpmd --lcores 1,2 -n 4 -w %s,representor=0-1 --proc-type auto --file-prefix testpmd-pf -- -i --port-topology=chained" % (self.target, self.pf_pci)
#lihong: the expect word is 'testpmd>'
+        return self.dut.send_expect(cmd_pf, "testpmd", 120)
+
+    def testpmd_vf0(self):

# lihong: same as before
+        cmd_vf0 = "./%s/app/testpmd --lcores 3,4 -n 4 -w %s --proc-type auto --file-prefix testpmd-vf0 -- -i" % (self.target, self.vfs_pci[0])
+        self.out_vf0 = self.session_secondary.send_expect(cmd_vf0, "testpmd>", 120)
+        pattern = re.compile(r"(([A-Fa-f0-9]{2}:){5}[A-Fa-f0-9]{2})")
+        self.vf0_mac = pattern.search(self.out_vf0).group()
+
+    def testpmd_vf1(self):
+        cmd_vf1 = "./%s/app/testpmd --lcores 5,6 -n 4 -w %s --proc-type auto --file-prefix testpmd-vf1 -- -i" % (self.target, self.vfs_pci[1])
+        self.out_vf1 = self.session_third.send_expect(cmd_vf1, "testpmd>", 120)
+        pattern = re.compile(r"(([A-Fa-f0-9]{2}:){5}[A-Fa-f0-9]{2})")
+        self.vf1_mac = pattern.search(self.out_vf1).group()
+
+    def test_port_representor_vf_stats_show_and_clear(self):
+        """
+        use control testpmd to get and clear dataplane testpmd ports Stats
+        """
+        self.testpmd_pf()

# lihong : if all testpmd should use cmd 'set promisc all off', I think you can put it in testpmd_pf/vf function.
+        self.dut.send_expect("set promisc 0 off", "testpmd>")
+        self.dut.send_expect("start", "testpmd>", 2)

#lihong: if you want use the timesleep to wait link up, you can use the interface ' wait_link_status_up' in pmdout.py 
+        time.sleep(2)
+        self.testpmd_vf0()
+        self.session_secondary.send_expect("set promisc 0 off", "testpmd>")
+        self.session_secondary.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf1()
+        self.session_third.send_expect("set promisc 0 off", "testpmd>")
+        self.session_third.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        # check port stats in control testpmd
+        pkt1 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.pf_mac)
+        pkt2 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.vf0_mac)
+        pkt3 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.vf1_mac)
+        pkts = [pkt1, pkt2, pkt3]
+        p = Packet()
+        for i in pkts:
+            p.append_pkt(i)
+        p.send_pkt(self.tester, tx_port=self.tester_itf, count=10)
+
+        output_before = self.dut.send_expect("show port stats all", "testpmd")
+        self.logger.info(output_before)
+        result_before = re.compile('RX-packets:\s+(.*?)\s+?').findall(output_before, re.S)

# lihong: some nic can not support the promisc, so I think you should modify you verify condition
+        self.verify(int(result_before[1]) == 10 and int(result_before[2]) == 10, "VF Stats show error")
+        # clear port stats in control testpmd
+        self.dut.send_expect("clear vf stats 0 0", "testpmd", 2)
+        self.dut.send_expect("clear vf stats 0 1", "testpmd", 2)
+        self.dut.send_expect("clear port stats all", "testpmd", 2)
+        time.sleep(1)

# lihong: use the unified expect word 'testpmd>'
+        output_after = self.dut.send_expect("show port stats all", "testpmd")
+        self.logger.info(output_after)
+        result_after = re.compile('RX-packets:\s+(.*?)\s+?').findall(output_after, re.S)
+        self.verify(int(result_after[1]) == 0 and int(result_after[2]) 
+ == 0, "VF Stats clear error")
+
+    def test_port_representor_vf_promiscous(self):
+        """
+        use control testpmd to enable/disable dataplane testpmd ports promiscous mode
+        """
+        self.testpmd_pf()
+        self.dut.send_expect("set promisc 0 off", "testpmd>")
+        self.dut.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf0()
+        self.session_secondary.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf1()
+        self.session_third.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+
+        # vf promiscous enable
+        self.dut.send_expect("set promisc 1 on", "testpmd>")
+        pkt1 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.pf_mac)
+        pkt2 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.vf0_mac)
+        pkt3 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.vf1_mac)
+        pkt4 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.unicast_mac)
+        pkts = [pkt1, pkt2, pkt3, pkt4]
+        p = Packet()
+        for i in pkts:
+            p.append_pkt(i)
+        p.send_pkt(self.tester, tx_port=self.tester_itf, count=10)
+        out_enable = self.dut.send_expect("show port stats all", "testpmd")
+        self.logger.info(out_enable)
+        result_enable = re.compile('RX-packets:\s+(.*?)\s+?').findall(out_enable, re.S)
+        self.verify(int(result_enable[1]) == 20 and 
+ int(result_enable[2]) == 20, "VFs receive packets error")
+
+        # clear port stats in control testpmd
+        self.dut.send_expect("clear vf stats 0 0", "testpmd", 2)
+        self.dut.send_expect("clear vf stats 0 1", "testpmd", 2)
+        self.dut.send_expect("clear port stats all", "testpmd", 2)
+        time.sleep(1)
+
+        # vf promiscous disable
+        self.dut.send_expect("set promisc 1 off", "testpmd>")
+        p = Packet()
+        for i in pkts:
+            p.append_pkt(i)
+        p.send_pkt(self.tester, tx_port=self.tester_itf, count=10)
+        out_disable = self.dut.send_expect("show port stats all", "testpmd")
+        self.logger.info(out_disable)
+        result_disable = re.compile('RX-packets:\s+(.*?)\s+?').findall(out_disable, re.S)
+        self.verify(int(result_disable[1]) == 10 and 
+ int(result_disable[2]) == 20, "VFs receive packets error")
+
+    def test_port_representor_vf_mac_addr(self):
+        """
+        use control testpmd to set vf mac address
+        """
+        self.testpmd_pf()
+        self.dut.send_expect("mac_addr set 1 aa:11:22:33:44:55", "testpmd>")
+        self.dut.send_expect("mac_addr set 2 aa:22:33:44:55:66", "testpmd>")
+        self.dut.send_expect("set promisc 0 off", "testpmd>")
+        self.dut.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf0()
+        self.session_secondary.send_expect("set promisc 0 off", "testpmd>")
+        self.session_secondary.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf1()
+        self.session_third.send_expect("set promisc 0 off", "testpmd>")
+        self.session_third.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        # check port stats in control testpmd
+        pkt1 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.pf_mac)
+        pkt2 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.vf0_mac)
+        pkt3 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.vf1_mac)
+        pkt4 = 'Ether(src="%s",dst="%s")/IP()' % (self.tester_mac, self.unicast_mac)
+        pkts = [pkt1, pkt2, pkt3, pkt4]
+        p = Packet()
+        for i in pkts:
+            p.append_pkt(i)
+        p.send_pkt(self.tester, tx_port=self.tester_itf, count=10)
+
+        out = self.dut.send_expect("show port stats all", "testpmd")
+        self.logger.info(out)
+        result = re.compile('RX-packets:\s+(.*?)\s+?').findall(out, re.S)
+        self.verify(int(result[1]) == 10 and int(result[2]) == 10, "VFs 
+ receive packets error")
+
+    def test_port_representor_vlan_filter(self):
+        """
+        use control testpmd to set vlan
+        """
+        self.testpmd_pf()
+        self.dut.send_expect("set promisc 1 off", "testpmd>")
+        self.dut.send_expect("vlan set filter on 1", "testpmd>")
+        self.dut.send_expect("rx_vlan add 3 1", "testpmd>")
+        self.dut.send_expect("set promisc 2 off", "testpmd>")
+        self.dut.send_expect("vlan set filter on 2", "testpmd>")
+        self.dut.send_expect("rx_vlan add 4 2", "testpmd>")
+        self.dut.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf0()
+        self.session_secondary.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+        self.testpmd_vf1()
+        self.session_third.send_expect("start", "testpmd>", 2)
+        time.sleep(2)
+
+        # check port stats in control testpmd
+        pkt1 = 'Ether(src="%s",dst="%s")/Dot1Q(vlan=3)/IP()' % (self.tester_mac, self.vf0_mac)
+        pkt2 = 'Ether(src="%s",dst="%s")/Dot1Q(vlan=4)/IP()' % (self.tester_mac, self.vf1_mac)
+        pkts = [pkt1, pkt2]
+        p = Packet()
+        for i in pkts:
+            p.append_pkt(i)
+        p.send_pkt(self.tester, tx_port=self.tester_itf, count=10)
+
+        out = self.dut.send_expect("show port stats all", "testpmd")
+        self.logger.info(out)
+        result = re.compile('RX-packets:\s+(.*?)\s+?').findall(out, re.S)
+        self.verify(int(result[1]) == 10 and int(result[2]) == 10, "VFs 
+ receive packets error")
+
+    def tear_down(self):
+        """
+        Run after each test case.
+        """
+        self.destroy_env()
+
+    def tear_down_all(self):
+        """
+        Run after each test suite.
+        """
+        self.dut.kill_all()
+        self.dut.destroy_sriov_vfs_by_port(self.dut_ports[0])
+        self.dut.close_session(self.session_secondary)
+        self.dut.close_session(self.session_third)
--
2.17.2