From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api
Date: Tue, 26 Nov 2019 05:17:28 +0000 [thread overview]
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB29196@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1574651867-173718-1-git-send-email-qimaix.xiao@intel.com>
Hi, Qimai
I think we should optimization the dut code instead of change the suite code.
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
Sent: Monday, November 25, 2019 11:18 AM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]tests/TestSuite_shutdown_api: update invocation of new api
update parameter of start_testpmd
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
tests/TestSuite_shutdown_api.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..4404f8b 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -248,7 +248,7 @@ class TestShutdownApi(TestCase):
"""
testcorelist = self.dut.get_core_list("1S/8C/1T", socket=self.ports_socket)
- self.pmdout.start_testpmd(testcorelist, "--portmask=%s --port-topology=loop" % utils.create_mask([self.ports[0]]), socket=self.ports_socket)
+ self.pmdout.start_testpmd("1S/8C/1T", "--portmask=%s
+ --port-topology=loop" % utils.create_mask([self.ports[0]]),
+ socket=self.ports_socket)
self.dut.send_expect("set promisc all off", "testpmd>")
fwdcoremask = utils.create_mask(testcorelist[-3:])
--
2.17.1
next prev parent reply other threads:[~2019-11-26 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 3:17 Xiao Qimai
2019-11-26 5:17 ` Ma, LihongX [this message]
2019-11-27 9:17 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB29196@SHSMSX101.ccr.corp.intel.com \
--to=lihongx.ma@intel.com \
--cc=dts@dpdk.org \
--cc=qimaix.xiao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).