* [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
@ 2019-11-25 9:32 Xiao Qimai
2019-11-27 2:38 ` Ma, LihongX
2019-11-27 9:28 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2019-11-25 9:32 UTC (permalink / raw)
To: dts; +Cc: Xiao Qimai
fix create_eal_parameters method
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
framework/dut.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/framework/dut.py b/framework/dut.py
index 4d8874a..f26b081 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -120,12 +120,13 @@ class Dut(Crb):
if config:
# deal with cores
if config.has_key('cores'):
- if config['cores'] == '' or config['cores'].lower() == 'default':
- core_list = self.get_core_list(default_cores)
- elif type(config['cores']) == list:
+ if type(config['cores']) == list:
core_list = config['cores']
- else:
- core_list = self.get_core_list(config['cores'], socket=socket)
+ elif isinstance(config['cores'], str):
+ if config['cores'] == '' or config['cores'].lower() == 'default':
+ core_list = self.get_core_list(default_cores)
+ else:
+ core_list = self.get_core_list(config['cores'], socket=socket)
else:
core_list = self.get_core_list(default_cores)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
2019-11-25 9:32 [dts] [PATCH V1]framework/dut: fix create_eal_parameters method Xiao Qimai
@ 2019-11-27 2:38 ` Ma, LihongX
2019-11-27 9:28 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Ma, LihongX @ 2019-11-27 2:38 UTC (permalink / raw)
To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX
Reviewed-by:ma,lihong <lihongx.ma@intel.com>
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
Sent: Monday, November 25, 2019 5:33 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
fix create_eal_parameters method
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
framework/dut.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/framework/dut.py b/framework/dut.py index 4d8874a..f26b081 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -120,12 +120,13 @@ class Dut(Crb):
if config:
# deal with cores
if config.has_key('cores'):
- if config['cores'] == '' or config['cores'].lower() == 'default':
- core_list = self.get_core_list(default_cores)
- elif type(config['cores']) == list:
+ if type(config['cores']) == list:
core_list = config['cores']
- else:
- core_list = self.get_core_list(config['cores'], socket=socket)
+ elif isinstance(config['cores'], str):
+ if config['cores'] == '' or config['cores'].lower() == 'default':
+ core_list = self.get_core_list(default_cores)
+ else:
+ core_list = self.get_core_list(config['cores'],
+ socket=socket)
else:
core_list = self.get_core_list(default_cores)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
2019-11-25 9:32 [dts] [PATCH V1]framework/dut: fix create_eal_parameters method Xiao Qimai
2019-11-27 2:38 ` Ma, LihongX
@ 2019-11-27 9:28 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-27 9:28 UTC (permalink / raw)
To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Monday, November 25, 2019 5:33 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
>
> fix create_eal_parameters method
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> framework/dut.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/framework/dut.py b/framework/dut.py index 4d8874a..f26b081
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -120,12 +120,13 @@ class Dut(Crb):
> if config:
> # deal with cores
> if config.has_key('cores'):
> - if config['cores'] == '' or config['cores'].lower() == 'default':
> - core_list = self.get_core_list(default_cores)
> - elif type(config['cores']) == list:
> + if type(config['cores']) == list:
> core_list = config['cores']
> - else:
> - core_list = self.get_core_list(config['cores'], socket=socket)
> + elif isinstance(config['cores'], str):
> + if config['cores'] == '' or config['cores'].lower() == 'default':
> + core_list = self.get_core_list(default_cores)
> + else:
> + core_list = self.get_core_list(config['cores'],
> + socket=socket)
> else:
> core_list = self.get_core_list(default_cores)
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-27 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 9:32 [dts] [PATCH V1]framework/dut: fix create_eal_parameters method Xiao Qimai
2019-11-27 2:38 ` Ma, LihongX
2019-11-27 9:28 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).