test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] framework/tester: only restore ports if start trex in dts
Date: Wed, 25 Dec 2019 09:06:38 +0000	[thread overview]
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB3E5FE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1577228799-25999-1-git-send-email-lihongx.ma@intel.com>

Tested-by:ma,lihong<lihongx.ma@intel.com>

-----Original Message-----
From: Ma, LihongX 
Sent: Wednesday, December 25, 2019 7:07 AM
To: dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts][PATCH V1] framework/tester: only restore ports if start trex in dts

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/tester.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/framework/tester.py b/framework/tester.py index 5b4aff0..7b05832 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -808,7 +808,9 @@ class Tester(Crb):
         if self.it_uses_external_generator():
             if self.is_pktgen and self.pktgen:
                 self.pktgen.quit_generator()
-                self.restore_trex_interfaces()
+                # only restore ports if start trex in dts
+                if 'start_trex' in self.pktgen.conf.keys():
+                    self.restore_trex_interfaces()
                 self.pktgen = None
             elif self.ixia_packet_gen:
                 self.ixia_packet_gen.close()
--
2.7.4


  reply	other threads:[~2019-12-25  9:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-24 23:06 lihong
2019-12-25  9:06 ` Ma, LihongX [this message]
2019-12-27  8:01 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB3E5FE@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).