From: Narala Praneeth Reddy <nareddy@marvell.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: Faisal Masood <fmasood@marvell.com>,
Vijaya Bhaskar Annayyolla <avijay@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063
Date: Wed, 24 Apr 2019 11:27:28 +0000 [thread overview]
Message-ID: <BL0PR18MB2290BC46C95E75B531C931CDB93C0@BL0PR18MB2290.namprd18.prod.outlook.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA6575F@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 4673 bytes --]
Please find inline comments.
________________________________
From: Tu, Lijuan <lijuan.tu@intel.com>
Sent: Wednesday, April 24, 2019 1:10 AM
To: Narala Praneeth Reddy; dts@dpdk.org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063
External Email
----------------------------------------------------------------------
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, April 22, 2019 10:24 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype
> mapping is not supported for cavium_a063
>
> From: Praneeth Reddy <nareddy@marvell.com>
>
> Marking this test case as not applicable for cavium_a063
>
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
> conf/test_case_checklist.json | 62
> +++++++++++++++++++++++++++++++++++++++-
> tests/TestSuite_ptype_mapping.py | 2 +-
> 2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index a1aa90b..decc946 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2200,5 +2200,65 @@
> "Bug ID": "",
> "Comments": "the nic not support this case"
> }
> - ]
> + ],
> + "ptype_mapping_get": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "cavium_a063"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "the nic not support this case"
> + }
> + ],
> + "ptype_mapping_replace": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "cavium_a063"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "the nic not support this case"
> + }
> + ],
> + "ptype_mapping_reset": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "cavium_a063"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "the nic not support this case"
> + }
> + ],
> + "ptype_mapping_update": [
> + {
> + "OS": [
> + "ALL"
> + ],
> + "NIC": [
> + "cavium_a063"
> + ],
> + "Target": [
> + "ALL"
> + ],
> + "Bug ID": "",
> + "Comments": "the nic not support this case"
> + }
> + ]
> }
> diff --git a/tests/TestSuite_ptype_mapping.py
> b/tests/TestSuite_ptype_mapping.py
> index 2771337..6e1fce1 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):
> Run at the start of each test suite.
> """
> self.verify(self.nic in ['fortville_eagle', 'fortville_spirit',
> - 'fortville_spirit_single', 'fortville_25g'],
> + 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],
[Lijuan] The NIC in the list above means support these cases. But from other context, Cavium_a063 does not support ptype mapping, Did I miss anything?
[Praneeth] ptype_mapping test case get FAIL and mention NIC not supported whenever complete DTS test suite ran for cavium_a063, inorder to make this test case as N/A, did following changes.
1. Added cavium_a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails and moves to next step.
2. Later as I added all ptype_mapping test cases in test_case_checklist.json, ptype_mapping test cases gets skip without executing. Finally the result will be N/A instead of FAIL.
Is this right way? Is there any other procedure to mark this test case as N/A for cavium_a063.
> 'ptype mapping test can not support %s nic' % self.nic)
> ports = self.dut.get_ports()
> self.verify(len(ports) >= 1, "Insufficient ports for testing")
> --
> 1.8.3.1
[-- Attachment #2: Type: text/html, Size: 11546 bytes --]
next prev parent reply other threads:[~2019-04-24 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 5:24 nareddy
2019-04-23 19:40 ` Tu, Lijuan
2019-04-24 11:27 ` Narala Praneeth Reddy [this message]
2019-04-24 16:31 ` Tu, Lijuan
2019-04-26 8:43 ` Narala Praneeth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR18MB2290BC46C95E75B531C931CDB93C0@BL0PR18MB2290.namprd18.prod.outlook.com \
--to=nareddy@marvell.com \
--cc=avijay@marvell.com \
--cc=dts@dpdk.org \
--cc=fmasood@marvell.com \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).