Please find inline comments.


________________________________
From: Tu, Lijuan <lijuan.tu@intel.com>
Sent: Wednesday, April 24, 2019 1:10 AM
To: Narala Praneeth Reddy; dts@dpdk.org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063

External Email

----------------------------------------------------------------------


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, April 22, 2019 10:24 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype
> mapping is not supported for cavium_a063
>
> From: Praneeth Reddy <nareddy@marvell.com>
>
> Marking this test case as not applicable for cavium_a063
>
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  conf/test_case_checklist.json    | 62
> +++++++++++++++++++++++++++++++++++++++-
>  tests/TestSuite_ptype_mapping.py |  2 +-
>  2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index a1aa90b..decc946 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2200,5 +2200,65 @@
>              "Bug ID": "",
>              "Comments": "the nic not support this case"
>          }
> -    ]
> +    ],
> +     "ptype_mapping_get": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_replace": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_reset": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_update": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "cavium_a063"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "the nic not support this case"
> +        }
> +     ]
>  }
> diff --git a/tests/TestSuite_ptype_mapping.py
> b/tests/TestSuite_ptype_mapping.py
> index 2771337..6e1fce1 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):
>          Run at the start of each test suite.
>          """
>          self.verify(self.nic in ['fortville_eagle', 'fortville_spirit',
> -            'fortville_spirit_single', 'fortville_25g'],
> +            'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],
[Lijuan] The NIC in the list above means support these cases. But from other context, Cavium_a063 does not support ptype mapping, Did I miss anything?
[Praneeth] ptype_mapping test case get FAIL and mention NIC not supported whenever complete DTS test suite ran for cavium_a063, inorder to make this test case as N/A, did following changes.
                              1. Added cavium_a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails and moves to next step.
                              2. Later as I added all ptype_mapping test cases in test_case_checklist.json, ptype_mapping test cases gets skip without executing. Finally the result will be N/A instead of FAIL.
                       Is this right way? Is there any other procedure to mark this test case as N/A for cavium_a063.
>              'ptype mapping test can not support %s nic' % self.nic)
>          ports = self.dut.get_ports()
>          self.verify(len(ports) >= 1, "Insufficient ports for testing")
> --
> 1.8.3.1