From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EC1E5A05D3 for ; Wed, 24 Apr 2019 13:27:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B0B41B4BD; Wed, 24 Apr 2019 13:27:37 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 338F35F32 for ; Wed, 24 Apr 2019 13:27:36 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3OBK5Im018050; Wed, 24 Apr 2019 04:27:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=0c/78nudV0SWTpGzJ5o4YnbwbF4LnFoUC88v20ZbnkY=; b=ZVCjFQkgtYo2XDT2bJ7Jok28BhX/F4GMC620AtszTj++XXqpvqJhv4WEn4VkefYa90CO 7z/NWQNZSh0T1pvjdTPyklCXcrvWjMoai6lc2ky+/3S3+WnIDV49HobPgidsDFC1dTwq 0VvsBFT0ISRvmvDAE9cvjlw4a99DUMNpbgy9Oy1iGFiXpxhrv5Xvi5tvwSEt3MQMP2er TFdTvIkrUJ7zOsgsNhc2bVEvTB/UWSLLc3g9Dz8P8fPcoOdR8+Xm88cvmhvupNLAO+Zu IbW/mA/6APnacKazNHw0ydnZnkQTn0UNTDc/dDrIKFUe6kgx4me1PNw4WGek5secjKr6 +A== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2s2nnjg7s2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2019 04:27:34 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 24 Apr 2019 04:27:33 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.59) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 24 Apr 2019 04:27:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0c/78nudV0SWTpGzJ5o4YnbwbF4LnFoUC88v20ZbnkY=; b=vCQyPLSe8zG4Tg2/DfWp60nwwWi7vOXaKZBj8uHnWMcopFeKNqvq26vDZ4r9Clz5oMmK5ougM+M4XdSawcUJ9zxrPn8JrE80fPzBcI7fTiW9qZ37t2DoC36PSxTjlfSZ09jaVGxMJGFgHFlVJqTVd+gwm+27lHSOq2AHVWSLxd4= Received: from BL0PR18MB2290.namprd18.prod.outlook.com (52.132.30.22) by BL0PR18MB2209.namprd18.prod.outlook.com (52.132.29.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Wed, 24 Apr 2019 11:27:28 +0000 Received: from BL0PR18MB2290.namprd18.prod.outlook.com ([fe80::8d88:20e7:db88:4884]) by BL0PR18MB2290.namprd18.prod.outlook.com ([fe80::8d88:20e7:db88:4884%3]) with mapi id 15.20.1813.017; Wed, 24 Apr 2019 11:27:28 +0000 From: Narala Praneeth Reddy To: "Tu, Lijuan" , "dts@dpdk.org" CC: Faisal Masood , Vijaya Bhaskar Annayyolla Thread-Topic: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 Thread-Index: AQHU+gyBchXay+sTh0GV/b0Z8Xaxu6ZLKxAf Date: Wed, 24 Apr 2019 11:27:28 +0000 Message-ID: References: <1555997061-21977-1-git-send-email-nareddy@marvell.com>, <8CE3E05A3F976642AAB0F4675D0AD20E0BA6575F@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA6575F@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 969fa704-1e0c-41e0-4d70-08d6c8a7d55f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BL0PR18MB2209; x-ms-traffictypediagnostic: BL0PR18MB2209: x-microsoft-antispam-prvs: x-forefront-prvs: 00179089FD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(376002)(346002)(136003)(366004)(189003)(199004)(13464003)(76176011)(86362001)(102836004)(7696005)(55016002)(236005)(110136005)(53546011)(53936002)(99286004)(3846002)(6506007)(55236004)(107886003)(6246003)(54896002)(6116002)(9686003)(486006)(316002)(478600001)(19627405001)(54906003)(2906002)(446003)(66446008)(73956011)(4326008)(97736004)(81156014)(76116006)(66476007)(52536014)(81166006)(74316002)(229853002)(6436002)(11346002)(66946007)(66066001)(64756008)(66556008)(14454004)(26005)(5660300002)(256004)(71190400001)(71200400001)(186003)(33656002)(6606003)(7736002)(25786009)(476003)(8936002)(14444005)(2501003)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR18MB2209; H:BL0PR18MB2290.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: fJikcLQJy/sxWUefsXhvU6G9TTXYZkWZpEVZB3hD4sgUH2u1HBBNYX6RSLOEbNKjtuhE9km5Tm6m2K9fXuIcww22rJ3ji29sbQKs0S8uA0mrZ2iWC+xOVGMcxgyQJbb1DFYVOSD6HkmNuUKQN3sNlTHhDM5QEFX2RjgtcGa6JbJA7UczFQezpX43QmLsWmJxGGhNKc6qBIGtNNXRGt6FP0/Woc3s+YIvS97L0YY6PvTuF3sMsihIwc7C4UfQqfw1W7ASd7YHUf1UCp9NHu4JPEikTMiiWWxcXiMe/IzJXOD8s41a++z3PoO8N3yRiZ4xP1iWswIhBLj6/d5frLMs9pmVQMV1i4MgztAnt2jxBKpaVlftRiuYuZ0jXEXyeT9+ECLh5amYN/ctogb3colFNDxfzuEGOGQnJtlWCsEi0zI= Content-Type: multipart/alternative; boundary="_000_BL0PR18MB2290BC46C95E75B531C931CDB93C0BL0PR18MB2290namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 969fa704-1e0c-41e0-4d70-08d6c8a7d55f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2019 11:27:28.3149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR18MB2209 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-24_08:, , signatures=0 Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --_000_BL0PR18MB2290BC46C95E75B531C931CDB93C0BL0PR18MB2290namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Please find inline comments. ________________________________ From: Tu, Lijuan Sent: Wednesday, April 24, 2019 1:10 AM To: Narala Praneeth Reddy; dts@dpdk.org Cc: Faisal Masood; Vijaya Bhaskar Annayyolla Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specif= ic ptype mapping is not supported for cavium_a063 External Email ---------------------------------------------------------------------- > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > nareddy@marvell.com > Sent: Monday, April 22, 2019 10:24 PM > To: dts@dpdk.org > Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy > > Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype > mapping is not supported for cavium_a063 > > From: Praneeth Reddy > > Marking this test case as not applicable for cavium_a063 > > Signed-off-by: Praneeth Reddy > --- > conf/test_case_checklist.json | 62 > +++++++++++++++++++++++++++++++++++++++- > tests/TestSuite_ptype_mapping.py | 2 +- > 2 files changed, 62 insertions(+), 2 deletions(-) > > diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.jso= n > index a1aa90b..decc946 100644 > --- a/conf/test_case_checklist.json > +++ b/conf/test_case_checklist.json > @@ -2200,5 +2200,65 @@ > "Bug ID": "", > "Comments": "the nic not support this case" > } > - ] > + ], > + "ptype_mapping_get": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_replace": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_reset": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_update": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ] > } > diff --git a/tests/TestSuite_ptype_mapping.py > b/tests/TestSuite_ptype_mapping.py > index 2771337..6e1fce1 100644 > --- a/tests/TestSuite_ptype_mapping.py > +++ b/tests/TestSuite_ptype_mapping.py > @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase): > Run at the start of each test suite. > """ > self.verify(self.nic in ['fortville_eagle', 'fortville_spirit', > - 'fortville_spirit_single', 'fortville_25g'], > + 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'], [Lijuan] The NIC in the list above means support these cases. But from othe= r context, Cavium_a063 does not support ptype mapping, Did I miss anything? [Praneeth] ptype_mapping test case get FAIL and mention NIC not supported w= henever complete DTS test suite ran for cavium_a063, inorder to make this t= est case as N/A, did following changes. 1. Added cavium_a063 to support list in TestS= uite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails a= nd moves to next step. 2. Later as I added all ptype_mapping test ca= ses in test_case_checklist.json, ptype_mapping test cases gets skip without= executing. Finally the result will be N/A instead of FAIL. Is this right way? Is there any other procedure to m= ark this test case as N/A for cavium_a063. > 'ptype mapping test can not support %s nic' % self.nic) > ports =3D self.dut.get_ports() > self.verify(len(ports) >=3D 1, "Insufficient ports for testing") > -- > 1.8.3.1 --_000_BL0PR18MB2290BC46C95E75B531C931CDB93C0BL0PR18MB2290namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Please find inline comments.



From: Tu, Lijuan <liju= an.tu@intel.com>
Sent: Wednesday, April 24, 2019 1:10 AM
To: Narala Praneeth Reddy; dts@dpdk.org
Cc: Faisal Masood; Vijaya Bhaskar Annayyolla
Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd= specific ptype mapping is not supported for cavium_a063
 
External Email

----------------------------------------------------------------------


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, April 22, 2019 10:24 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific pt= ype
> mapping is not supported for cavium_a063
>
> From: Praneeth Reddy <nareddy@marvell.com>
>
> Marking this test case as not applicable for cavium_a063
>
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  conf/test_case_checklist.json    | 62
> ++++++++++++++= +++++++++++++++= ++++++++++-
>  tests/TestSuite_ptype_mapping.py |  2 +-
>  2 files changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.= json
> index a1aa90b..decc946 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2200,5 +2200,65 @@
>            = ;  "Bug ID": "",
>            = ;  "Comments": "the nic not support this case"
>          }
> -    ]
> +    ],
> +     "ptype_mapping_get": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_replace": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_reset": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +    ],
> +     "ptype_mapping_update": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "cavium_a063"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "the nic not support this case"
> +        }
> +     ]
>  }
> diff --git a/tests/TestSuite_ptype_mapping.py
> b/tests/TestSuite_ptype_mapping.py
> index 2771337..6e1fce1 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):
>          Run at the start= of each test suite.
>          ""&quo= t;
>          self.verify(self= .nic in ['fortville_eagle', 'fortville_spirit',
> -            'f= ortville_spirit_single', 'fortville_25g'],
> +           = ; 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],
[Lijuan] The NIC in the list above means support these cases. But from othe= r context, Cavium_a063 does not support ptype mapping, Did I miss anything?=
[Praneeth] ptype_mapping test case get FAIL and mention NIC not suppor= ted whenever complete DTS test suite ran for cavium_a063, inorder to make t= his test case as N/A, did following changes.
             &n= bsp;                1. Added cavium= _a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping = test cases doesn't get fails and moves to next step.
               =               2. Later as I added = all ptype_mapping test cases in test_case_checklist.json, ptype_mapping tes= t cases gets skip without executing. Finally the result will be N/A instead= of FAIL.
                &nbs= p;      Is this right way? Is there any other procedure to m= ark this test case as N/A for cavium_a063.
>            = ;  'ptype mapping test can not support %s nic' % self.nic)
>          ports =3D self.d= ut.get_ports()
>          self.verify(len(= ports) >=3D 1, "Insufficient ports for testing")
> --
> 1.8.3.1

--_000_BL0PR18MB2290BC46C95E75B531C931CDB93C0BL0PR18MB2290namp_--