test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Huang, ZhiminX" <zhiminx.huang@intel.com>
To: "Li, WeiyuanX" <weiyuanx.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WeiyuanX" <weiyuanx.li@intel.com>
Subject: RE: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode
Date: Fri, 28 Oct 2022 05:15:14 +0000	[thread overview]
Message-ID: <BN0PR11MB571256246ED9B53505ADD0EAFD329@BN0PR11MB5712.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221018020938.30275-1-weiyuanx.li@intel.com>

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Tuesday, October 18, 2022 10:10 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case
> cancel trust mode
> 
> Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
> address to the testpmd.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
> index 73435339..494204a2 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -334,13 +334,13 @@ class TestKernelpfIavf(TestCase):
>          self.send_random_pkt(self.wrong_mac, count=1)
>          out = self.vm_dut.get_session_output()
>          self.verify(self.wrong_mac in out, "vf receive pkt fail with wrong
> mac")
> +        self.dut.send_expect("ip link set dev %s vf 0 trust off" %
> + self.host_intf, "# ")
> 
>      def test_vf_multicast(self):
>          """
>          enable kernel trust mode
>          """
>          multicast_mac = "01:80:C2:00:00:08"
> -        self.dut.send_expect("ip link set dev %s vf 0 trust on" %
> self.host_intf, "# ")
>          self.launch_testpmd(dcf_flag=self.dcf_mode)
>          self.vm_testpmd.execute_cmd("set fwd mac")
>          self.vm_testpmd.execute_cmd("set promisc all off") @@ -355,6
> +355,7 @@ class TestKernelpfIavf(TestCase):
>          self.verify(multicast_mac not in out, "vf receive pkt with multicast
> mac")
> 
>          self.vm_testpmd.execute_cmd("set allmulti all on")
> +        self.vm_testpmd.execute_cmd(f"mcast_addr add 0
> + {multicast_mac}")
>          self.send_random_pkt(self.vf_mac, count=1)
>          out = self.vm_dut.get_session_output()
>          self.verify(self.vf_mac in out, "vf receive pkt fail with current mac")
> --
> 2.27.0
If you want to replace 'trust on vf' to 'mcast_addr add' in testcase,
Please update the testplan synchronously.


      parent reply	other threads:[~2022-10-28  5:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  2:09 Weiyuan Li
2022-10-27  7:47 ` Chen, LingliX
2022-10-28  5:15 ` Huang, ZhiminX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN0PR11MB571256246ED9B53505ADD0EAFD329@BN0PR11MB5712.namprd11.prod.outlook.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).