test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode
@ 2022-10-18  2:09 Weiyuan Li
  2022-10-27  7:47 ` Chen, LingliX
  2022-10-28  5:15 ` Huang, ZhiminX
  0 siblings, 2 replies; 3+ messages in thread
From: Weiyuan Li @ 2022-10-18  2:09 UTC (permalink / raw)
  To: dts; +Cc: Weiyuan Li

Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
address to the testpmd.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 73435339..494204a2 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -334,13 +334,13 @@ class TestKernelpfIavf(TestCase):
         self.send_random_pkt(self.wrong_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(self.wrong_mac in out, "vf receive pkt fail with wrong mac")
+        self.dut.send_expect("ip link set dev %s vf 0 trust off" % self.host_intf, "# ")
 
     def test_vf_multicast(self):
         """
         enable kernel trust mode
         """
         multicast_mac = "01:80:C2:00:00:08"
-        self.dut.send_expect("ip link set dev %s vf 0 trust on" % self.host_intf, "# ")
         self.launch_testpmd(dcf_flag=self.dcf_mode)
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("set promisc all off")
@@ -355,6 +355,7 @@ class TestKernelpfIavf(TestCase):
         self.verify(multicast_mac not in out, "vf receive pkt with multicast mac")
 
         self.vm_testpmd.execute_cmd("set allmulti all on")
+        self.vm_testpmd.execute_cmd(f"mcast_addr add 0 {multicast_mac}")
         self.send_random_pkt(self.vf_mac, count=1)
         out = self.vm_dut.get_session_output()
         self.verify(self.vf_mac in out, "vf receive pkt fail with current mac")
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode
  2022-10-18  2:09 [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode Weiyuan Li
@ 2022-10-27  7:47 ` Chen, LingliX
  2022-10-28  5:15 ` Huang, ZhiminX
  1 sibling, 0 replies; 3+ messages in thread
From: Chen, LingliX @ 2022-10-27  7:47 UTC (permalink / raw)
  To: dts


> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Tuesday, October 18, 2022 10:10 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case
> cancel trust mode
> 
> Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
> address to the testpmd.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Tested-by: Lingli Chen <linglix.chen@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode
  2022-10-18  2:09 [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode Weiyuan Li
  2022-10-27  7:47 ` Chen, LingliX
@ 2022-10-28  5:15 ` Huang, ZhiminX
  1 sibling, 0 replies; 3+ messages in thread
From: Huang, ZhiminX @ 2022-10-28  5:15 UTC (permalink / raw)
  To: Li, WeiyuanX, dts; +Cc: Li, WeiyuanX

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Tuesday, October 18, 2022 10:10 AM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case
> cancel trust mode
> 
> Case vf_multicast cancel trust model and use 'mcast_addr' add multicast
> address to the testpmd.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
> index 73435339..494204a2 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -334,13 +334,13 @@ class TestKernelpfIavf(TestCase):
>          self.send_random_pkt(self.wrong_mac, count=1)
>          out = self.vm_dut.get_session_output()
>          self.verify(self.wrong_mac in out, "vf receive pkt fail with wrong
> mac")
> +        self.dut.send_expect("ip link set dev %s vf 0 trust off" %
> + self.host_intf, "# ")
> 
>      def test_vf_multicast(self):
>          """
>          enable kernel trust mode
>          """
>          multicast_mac = "01:80:C2:00:00:08"
> -        self.dut.send_expect("ip link set dev %s vf 0 trust on" %
> self.host_intf, "# ")
>          self.launch_testpmd(dcf_flag=self.dcf_mode)
>          self.vm_testpmd.execute_cmd("set fwd mac")
>          self.vm_testpmd.execute_cmd("set promisc all off") @@ -355,6
> +355,7 @@ class TestKernelpfIavf(TestCase):
>          self.verify(multicast_mac not in out, "vf receive pkt with multicast
> mac")
> 
>          self.vm_testpmd.execute_cmd("set allmulti all on")
> +        self.vm_testpmd.execute_cmd(f"mcast_addr add 0
> + {multicast_mac}")
>          self.send_random_pkt(self.vf_mac, count=1)
>          out = self.vm_dut.get_session_output()
>          self.verify(self.vf_mac in out, "vf receive pkt fail with current mac")
> --
> 2.27.0
If you want to replace 'trust on vf' to 'mcast_addr add' in testcase,
Please update the testplan synchronously.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-28  5:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18  2:09 [dts][PATCH V1] tests/kernelpf_iavf: optimize script multicast case cancel trust mode Weiyuan Li
2022-10-27  7:47 ` Chen, LingliX
2022-10-28  5:15 ` Huang, ZhiminX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).