RE: [dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite

RE: [dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite

[Jiale, SongX]

> -----Original Message-----
> From: Jiale, SongX <songx.jiale@intel.com>
> Sent: Thursday, September 8, 2022 7:12 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite
> 
> 1. rename the name of ice_dcf_date_path to ice_dcf_data_path.
> 2. synchronize testplan modifications.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---
Acked-by: Peng, Yuan <yuan.peng@intel.com>

RE: [dts] [PATCH V3 1/2] test_plans/ice_dcf_data_path: rename suite

[Jiale, SongX]

> -----Original Message-----
> From: Jiale, SongX <songx.jiale@intel.com>
> Sent: Thursday, September 8, 2022 7:12 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V3 1/2] test_plans/ice_dcf_data_path: rename suite
> 
> 1. rename the name of ice_dcf_date_path to ice_dcf_data_path.
> 2. modify the format of testplan.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---
Acked-by: Peng, Yuan <yuan.peng@intel.com>

RE: [dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite

[Chen, LingliX]

> -----Original Message-----
> From: Song Jiale <songx.jiale@intel.com>
> Sent: Thursday, September 8, 2022 7:12 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite
> 
> 1. rename the name of ice_dcf_date_path to ice_dcf_data_path.
> 2. synchronize testplan modifications.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---

Tested-by: Lingli Chen <linglix.chen@intel.com>

[dts] [PATCH V3 1/2] test_plans/ice_dcf_data_path: rename suite

[Song Jiale]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 7784 bytes --]

1. rename the name of ice_dcf_date_path to ice_dcf_data_path.
2. modify the format of testplan.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 ...an.rst => ice_dcf_data_path_test_plan.rst} | 48 ++++++++++++++-----
 test_plans/index.rst                          |  2 +-
 2 files changed, 38 insertions(+), 12 deletions(-)
 rename test_plans/{ice_dcf_date_path_test_plan.rst => ice_dcf_data_path_test_plan.rst} (88%)

diff --git a/test_plans/ice_dcf_date_path_test_plan.rst b/test_plans/ice_dcf_data_path_test_plan.rst
similarity index 88%
rename from test_plans/ice_dcf_date_path_test_plan.rst
rename to test_plans/ice_dcf_data_path_test_plan.rst
index 1a0df884..bc413d69 100644
--- a/test_plans/ice_dcf_date_path_test_plan.rst
+++ b/test_plans/ice_dcf_data_path_test_plan.rst
@@ -1,3 +1,15 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2019 Intel Corporation
+
+
+=======================
+ICE DCF Data Path Tests
+=======================
+
+Description
+===========
+
+This document provides the plan for testing DCF data path function of Intel® Ethernet 800 Series.
 
 Common steps for launching DCF
 ==============================
@@ -17,7 +29,7 @@ Set a VF as trust ::
 Launch dpdk on the VF, request DCF mode ::
 
     ./usertools/dpdk-devbind.py -b vfio-pci 18:01.0
-    ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 6-10 -n 4 -a 18:01.0,cap=dcf --file-prefix=vf -- -i
+    ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 6-10 -n 4 -a 18:01.0,cap=dcf --file-prefix=vf -- -i --rxq=4 --txq=4
 
 
 Test Case: Launch DCF and do macfwd
@@ -64,7 +76,9 @@ Send a series packets to check if DCF RSS is correct for IPv4 ::
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:11:22:33:44:55")/IP(src="192.168.1.3", dst="192.168.1.2")/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:11:22:33:44:55")/IP(src="192.168.1.1", dst="192.168.1.2")/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3, and should be same to p4.
+Expected:
+   p1 hash value is not equal to p2 or p3, and should be same to p4.
+   check the packets are distributed to queues by rss.
 
 Send a series packets to check if DCF RSS is correct for IPv6 ::
 
@@ -73,7 +87,9 @@ Send a series packets to check if DCF RSS is correct for IPv6 ::
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:11:22:33:44:55")/IPv6(src="::21", dst="::11")/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:11:22:33:44:55")/IPv6(src="::22", dst="::11")/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3, and should be same to p4.
+Expected:
+   p1 hash value is not equal to p2 or p3, and should be same to p4.
+   check the packets are distributed to queues by rss.
 
 Send a series packets to check if DCF RSS is correct for tunnelling packet (inner IPv4) ::
 
@@ -84,8 +100,9 @@ Send a series packets to check if DCF RSS is correct for tunnelling packet (inne
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="11:22:33:44:55:77")/IPv6(src="::11", dst="::22")/GRE()/IP(src="192.168.1.1", dst="192.168.1.2")/Raw('x'*64), iface=intf)
 
 
-Expected: p1 hash value is not equal to p2 or p3. p1 hash value is equal to p4 and p5.
-
+Expected:
+   p1 hash value is not equal to p2 or p3. p1 hash value is equal to p4 and p5.
+   check the packets are distributed to queues by rss.
 
 Send a series packets to check if DCF RSS is correct for tunnelling packet (inner IPv6) ::
 
@@ -95,7 +112,9 @@ Send a series packets to check if DCF RSS is correct for tunnelling packet (inne
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="11:22:33:44:55:77")/IP(src="1.1.1.2", dst="2.2.2.1")/GRE()/IPv6(src="::22", dst="::11")/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="11:22:33:44:55:77")/IPv6(src="::33", dst="::44")/GRE()/IPv6(src="::22", dst="::11")/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3. p1 hash value is equal to p4 and p5.
+Expected:
+   p1 hash value is not equal to p2 or p3. p1 hash value is equal to p4 and p5.
+   p1/p2/p3 should be devided into different queues.
 
 
 Test Case: Check default rss for L4
@@ -121,7 +140,9 @@ Send a series packets to check if DCF RSS is correct for IPv4 ::
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:11:22:33:44:55")/IP(src="192.168.1.1", dst="192.168.1.2")/UDP(sport=1234, dport=5679)/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:22:33:44:55:77")/IP(src="192.168.1.1", dst="192.168.1.2")/TCP(sport=1234, dport=5678)/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6.
+Expected:
+   p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6.
+   check the packets are distributed to queues by rss.
 
 Send a series packets to check if DCF RSS is correct for IPv6 ::
 
@@ -132,7 +153,9 @@ Send a series packets to check if DCF RSS is correct for IPv6 ::
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:11:22:33:44:55")/IPv6(src="::22", dst="::11")/UDP(sport=1234, dport=5679)/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="11:22:33:44:55:77")/IPv6(src="::22", dst="::11")/TCP(sport=1234, dport=5678)/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6.
+Expected:
+   p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6.
+   check the packets are distributed to queues by rss.
 
 Send a series packets to check if DCF RSS is correct for tunnelling packet (inner IPv4) ::
 
@@ -144,8 +167,9 @@ Send a series packets to check if DCF RSS is correct for tunnelling packet (inne
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:22:33:44:55:77")/IP(src="1.1.1.2", dst="2.2.2.1")/GRE()/IP(src="192.168.1.1", dst="192.168.1.2")/UDP(sport=1234, dport=5678)/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:22:33:44:55:77")/IPv6(src="::11", dst="::22")/GRE()/IP(src="192.168.1.1", dst="192.168.1.2")/TCP(sport=1234, dport=5678)/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6 and p7.
-
+Expected:
+   p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6 and p7.
+   check the packets are distributed to queues by rss.
 
 Send a series packets to check if DCF RSS is correct for tunnelling packet (inner IPv6) ::
 
@@ -157,7 +181,9 @@ Send a series packets to check if DCF RSS is correct for tunnelling packet (inne
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:22:33:44:55:77")/IP(src="1.1.1.2", dst="2.2.2.1")/GRE()/IPv6(src="::22", dst="::11")/UDP(sport=1234, dport=5678)/Raw('x'*64), iface=intf)
     sendp(Ether(dst="D2:6B:4C:EB:1C:26", src="00:22:33:44:55:77")/IPv6(src="::33", dst="::44")/GRE()/IPv6(src="::22", dst="::11")/UDP(sport=1234, dport=5678)/Raw('x'*64), iface=intf)
 
-Expected: p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6 and p7.
+Expected:
+   p1 hash value is not equal to p2 or p3 or p4 or p5, and should be equal to p6 and p7.
+   check the packets are distributed to queues by rss.
 
 
 Test Case: Create rule with to original VF action
diff --git a/test_plans/index.rst b/test_plans/index.rst
index 2d797b6d..5b0b409a 100644
--- a/test_plans/index.rst
+++ b/test_plans/index.rst
@@ -28,7 +28,7 @@ The following are the test plans for the DPDK DTS automated test system.
     ice_advanced_iavf_rss_pppol2tpoudp_test_plan
     ice_advanced_rss_vlan_esp_ah_l2tp_pfcp_test_plan
     ice_dcf_acl_filter_test_plan
-    ice_dcf_date_path_test_plan
+    ice_dcf_data_path_test_plan
     ice_dcf_switch_filter_test_plan
     ice_dcf_switch_filter_pppoe_test_plan
     ice_dcf_switch_filter_gtpu_test_plan
-- 
2.17.1

[dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite

[Song Jiale]

1. rename the name of ice_dcf_date_path to ice_dcf_data_path.
2. synchronize testplan modifications.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 ...te_ice_dcf_date_path.py => TestSuite_ice_dcf_data_path.py} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename tests/{TestSuite_ice_dcf_date_path.py => TestSuite_ice_dcf_data_path.py} (99%)

diff --git a/tests/TestSuite_ice_dcf_date_path.py b/tests/TestSuite_ice_dcf_data_path.py
similarity index 99%
rename from tests/TestSuite_ice_dcf_date_path.py
rename to tests/TestSuite_ice_dcf_data_path.py
index 3181aad7..a31681fb 100644
--- a/tests/TestSuite_ice_dcf_date_path.py
+++ b/tests/TestSuite_ice_dcf_data_path.py
@@ -10,7 +10,7 @@ from framework.pmd_output import PmdOutput
 from framework.test_case import TestCase
 
 
-class DcfDatePathTest(TestCase):
+class DcfDataPathTest(TestCase):
     vf_mac = "D2:6B:4C:EB:1C:26"
     wrong_mac = "68:05:CA:8D:ED:A8"
 
@@ -37,7 +37,7 @@ class DcfDatePathTest(TestCase):
     def set_up(self):
         self.pmd_output.start_testpmd(
             cores="1S/4C/1T",
-            param="--txq=2 --rxq=2 --txd=384 --rxd=384",
+            param="--txq=4 --rxq=4",
             prefix="vf",
             ports=[self.used_vf_pci],
             port_options={self.used_vf_pci: "cap=dcf"},
-- 
2.17.1

[dts] [PATCH V3 2/2] tests/ice_dcf_data_path: rename suite

[lijuan.tu]

On Thu,  8 Sep 2022 11:11:48 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> 1. rename the name of ice_dcf_date_path to ice_dcf_data_path.
> 2. synchronize testplan modifications.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks