* [dts] [PATCH V1] test/dual_vlan: Code optimization @ 2020-06-30 6:58 ChenBo 2020-06-30 7:07 ` Chen, BoX C 0 siblings, 1 reply; 3+ messages in thread From: ChenBo @ 2020-06-30 6:58 UTC (permalink / raw) To: dts; +Cc: ChenBo Delete code that will not be executed Signed-off-by: ChenBo <box.c.chen@intel.com> --- tests/TestSuite_dual_vlan.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py index daa23d3..73d3156 100644 --- a/tests/TestSuite_dual_vlan.py +++ b/tests/TestSuite_dual_vlan.py @@ -348,8 +348,6 @@ class TestDualVlan(TestCase): self.mode_config(extend="off") self.mode_config(strip="off") self.mode_config(stripq="off") - if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]: - self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId), "testpmd> ") self.vlan_send_packet(outvlan) out = self.get_tcpdump_package() self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " + out) @@ -366,8 +364,6 @@ class TestDualVlan(TestCase): self.vlan_send_packet(outvlan) out = self.get_tcpdump_package() self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " + out) - if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV","fortpark_BASE-T" "carlsville"]: - self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId), "testpmd> ") def test_vlan_insert_config(self): """ -- 2.17.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] test/dual_vlan: Code optimization 2020-06-30 6:58 [dts] [PATCH V1] test/dual_vlan: Code optimization ChenBo @ 2020-06-30 7:07 ` Chen, BoX C 2020-06-30 7:16 ` Peng, Yuan 0 siblings, 1 reply; 3+ messages in thread From: Chen, BoX C @ 2020-06-30 7:07 UTC (permalink / raw) To: dts [-- Attachment #1: Type: text/plain, Size: 1919 bytes --] Tested-by: Chen, BoX C <BoX.C.Chen@intel.com> Regards, Chen Bo > -----Original Message----- > From: Chen, BoX C <box.c.chen@intel.com> > Sent: June 30, 2020 14:59 > To: dts@dpdk.org > Cc: Chen, BoX C <box.c.chen@intel.com> > Subject: [dts][PATCH V1] test/dual_vlan: Code optimization > > Delete code that will not be executed > > Signed-off-by: ChenBo <box.c.chen@intel.com> > --- > tests/TestSuite_dual_vlan.py | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py > index daa23d3..73d3156 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -348,8 +348,6 @@ class TestDualVlan(TestCase): > self.mode_config(extend="off") > self.mode_config(strip="off") > self.mode_config(stripq="off") > - if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", > "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]: > - self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId), > "testpmd> ") > self.vlan_send_packet(outvlan) > out = self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " + > out) @@ -366,8 +364,6 @@ class TestDualVlan(TestCase): > self.vlan_send_packet(outvlan) > out = self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " + > out) > - if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", > "fortville_spirit", "fortville_spirit_single", "fortville_25g", > "fortpark_TLV","fortpark_BASE-T" "carlsville"]: > - self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId), > "testpmd> ") > > def test_vlan_insert_config(self): > """ > -- > 2.17.1 [-- Attachment #2: TestDualVlan.log --] [-- Type: application/octet-stream, Size: 915543 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] test/dual_vlan: Code optimization 2020-06-30 7:07 ` Chen, BoX C @ 2020-06-30 7:16 ` Peng, Yuan 0 siblings, 0 replies; 3+ messages in thread From: Peng, Yuan @ 2020-06-30 7:16 UTC (permalink / raw) To: Chen, BoX C, dts; +Cc: Peng, Yuan Acked by Peng, Yuan <yuan.peng@intel.com> -----Original Message----- From: dts <dts-bounces@dpdk.org> On Behalf Of Chen, BoX C Sent: Tuesday, June 30, 2020 3:08 PM To: dts@dpdk.org Subject: Re: [dts] [PATCH V1] test/dual_vlan: Code optimization Tested-by: Chen, BoX C <BoX.C.Chen@intel.com> Regards, Chen Bo > -----Original Message----- > From: Chen, BoX C <box.c.chen@intel.com> > Sent: June 30, 2020 14:59 > To: dts@dpdk.org > Cc: Chen, BoX C <box.c.chen@intel.com> > Subject: [dts][PATCH V1] test/dual_vlan: Code optimization > > Delete code that will not be executed > > Signed-off-by: ChenBo <box.c.chen@intel.com> > --- > tests/TestSuite_dual_vlan.py | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/tests/TestSuite_dual_vlan.py > b/tests/TestSuite_dual_vlan.py index daa23d3..73d3156 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -348,8 +348,6 @@ class TestDualVlan(TestCase): > self.mode_config(extend="off") > self.mode_config(strip="off") > self.mode_config(stripq="off") > - if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", > "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]: > - self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId), > "testpmd> ") > self.vlan_send_packet(outvlan) > out = self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan strip queue > disable error : " + > out) @@ -366,8 +364,6 @@ class TestDualVlan(TestCase): > self.vlan_send_packet(outvlan) > out = self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan strip queue > disable error: " + > out) > - if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", > "fortville_spirit", "fortville_spirit_single", "fortville_25g", > "fortpark_TLV","fortpark_BASE-T" "carlsville"]: > - self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId), > "testpmd> ") > > def test_vlan_insert_config(self): > """ > -- > 2.17.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-30 7:17 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-30 6:58 [dts] [PATCH V1] test/dual_vlan: Code optimization ChenBo 2020-06-30 7:07 ` Chen, BoX C 2020-06-30 7:16 ` Peng, Yuan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).