From: "Chen, BoX C" <box.c.chen@intel.com>
To: Owen Hilyard <ohilyard@iol.unh.edu>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhang, XiX" <xix.zhang@intel.com>,
"Zhang, XuemingX" <xuemingx.zhang@intel.com>,
"Ma, LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529
Date: Thu, 27 Aug 2020 07:35:51 +0000 [thread overview]
Message-ID: <BN6PR11MB1667E1CA1B31A8252E0642BFD9550@BN6PR11MB1667.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200826155329.281082-1-ohilyard@iol.unh.edu>
Tested Failed by: xix.zhang@intel.com
There may be two more errors:
1.The Iface here is a function variable, not an Iface defined by scapy. I think you forgot to put quotation marks
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
def replay_pcap_file_on_tester(self, iface, packet_file_path):
self.tester.send_expect("scapy", ">>>")
self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
- self.scapy_exec(f"sendp(packets, iface={iface})")
+ self.scapy_exec(f"sendp(packets, iface='{iface}')")
self.tester.send_expect("quit()", "# ")
2.SyntaxError: invalid syntax(This format should not appear :UDP(chksum=chksum=0xf))
File "/usr/lib/python3.6/code.py", line 64, in runsource
code = self.compile(source, filename, symbol)
File "/usr/lib/python3.6/codeop.py", line 168, in __call__
return _maybe_compile(self.compiler, source, filename, symbol)
File "/usr/lib/python3.6/codeop.py", line 99, in _maybe_compile
raise err1
File "/usr/lib/python3.6/codeop.py", line 87, in _maybe_compile
code1 = compiler(source + "\n", filename, symbol)
File "/usr/lib/python3.6/codeop.py", line 133, in __call__
codeob = compile(source, filename, symbol, self.flags, 1)
File "<console>", line 1
sendp(eth/IP()/UDP(chksum=0xf)/VXLAN()/IP()/UDP(chksum=chksum=0xf)/('X'*50), iface=iface)
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
> Sent: August 26, 2020 23:53
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>; Zhang, XuemingX
> <xuemingx.zhang@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Owen
> Hilyard <ohilyard@iol.unh.edu>
> Subject: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529
>
> added missing quote in template for scapy packets.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
> tests/TestSuite_checksum_offload.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index c4a877d..b07ae16 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
> for l4 in l4_protos:
> for chksum in "", "chksum=0xf":
> vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
> - f"eth/IP({chksum})/{l4}()/(X'*50)",
> + f"eth/IP({chksum})/{l4}()/('X'*50)",
> "PKT_RX_IP_CKSUM_", f"{l4}",
> should_pass=(chksum == ""))
> if vf is not None:
> --
> 2.25.1
next prev parent reply other threads:[~2020-08-27 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:53 Owen Hilyard
2020-08-27 7:35 ` Chen, BoX C [this message]
2020-09-01 2:55 ` Ma, LihongX
2020-09-04 7:13 ` [dts] [PATCH V1] tests/checksum_offload: " Owen Hilyard
2020-09-09 5:32 ` Ma, LihongX
2020-09-09 21:08 ` Owen Hilyard
2020-09-09 21:14 ` Owen Hilyard
2020-09-09 21:16 ` Owen Hilyard
2020-09-15 8:27 ` Tu, Lijuan
2020-09-10 1:45 ` Ma, LihongX
2020-09-10 1:50 ` Ma, LihongX
2020-09-11 18:33 ` Owen Hilyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB1667E1CA1B31A8252E0642BFD9550@BN6PR11MB1667.namprd11.prod.outlook.com \
--to=box.c.chen@intel.com \
--cc=dts@dpdk.org \
--cc=lihongx.ma@intel.com \
--cc=ohilyard@iol.unh.edu \
--cc=xix.zhang@intel.com \
--cc=xuemingx.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).