From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 323D8A04B1; Thu, 27 Aug 2020 09:36:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28BE01C0B9; Thu, 27 Aug 2020 09:36:01 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 39D271C069 for ; Thu, 27 Aug 2020 09:35:59 +0200 (CEST) IronPort-SDR: DT6LH4jPcuu53+v5R6gN4Sg6t7qhw/kef62lK5A3lbHj8Hz/nrQOaPWiewjc+xVJSJZWXr4UsH tZDwu2kiWlVA== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="174487631" X-IronPort-AV: E=Sophos;i="5.76,359,1592895600"; d="scan'208";a="174487631" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 00:35:58 -0700 IronPort-SDR: R+oC/IGx8+nS9hD1bhgNvGtqvfk0AGYs0t+3D1Y1QpKWtfNbeVUS+N7EBy93R4BA7qXD12qOy0 M2/q64Rjg/0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,359,1592895600"; d="scan'208";a="444349090" Received: from orsmsx604-2.jf.intel.com (HELO ORSMSX604.amr.corp.intel.com) ([10.22.229.84]) by orsmga004.jf.intel.com with ESMTP; 27 Aug 2020 00:35:57 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 27 Aug 2020 00:35:55 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 27 Aug 2020 00:35:55 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 27 Aug 2020 00:35:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CrmPmMlgpk1f1JGF9PTSmapTDGakA7JopQliVeCxb2//S7p0J4o6fjqy1odbtNf58Hxxla3LlflJwiaIbTFjSmKC82cgC/fFjqBaYIbzOxjBYEsYlLDG0/Jb0ZtuucIrAwZ7iuw9J4Gy1KS63tRm+3PtfclZmy1eu2HbzZF/QAkNuEq66Gq9EwUvu4y3EWhcRll9MpiS2AB37jktE/OxpAkUlZb+JHcYScOPxz2RZCzl7fNkyAyu+ErSgFeBTxZpFSCJnIL37lUG93rtFrKIQbCvP/xqfn7q6W+LEBlvvTLjYSeoNR5AHx/nFbqwjZ9YxdHi2p2GLDIK6A5KdoUTew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MUNeNkO0B2fTnhJG8t8/JWMjhZcwMJ9nrmt+UMAA8vA=; b=BU+6lvFJHFCHtA08Qe4YLHlsX0tCK/Dwgj+IbhTA9OHQSsxChieh+H9mmhye5fT4Rf9I59Vta/uBinBduvaLvdZFr07ZU/ENeRLXWPhf/MNm5HvwgWNpkat+gxTsnZwJn39/ifkDh4o9O2ZS93NLOmPf/xXYYD29ymqbwgmH9IqQe0So4O0nEJLUvwsClqllG+ca4HD3YqlNb2BEwA2h9IROOMJzo3ZxRiZnf//KjE88JjtJpCV5Z7EKr1TUB460i8gY58JUk5R+26vd0yPvV7td1vd8X/azR1FGh+vXinPKW4XYwGmyQfG0Tj5sROjHBhVET+XX+yQIAZ3PN/682w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MUNeNkO0B2fTnhJG8t8/JWMjhZcwMJ9nrmt+UMAA8vA=; b=xwMJ9fa6T55BG3uUBnaCuRQmcKPO0VpebcDMvSb7S+zzJhSjT7cq3Wfxqi5kmp2aTvf83HZxRyJicPmTpzU0/rDXmQcVjVzgHJgHVMU9UZMVa9zk61caoKeVoKPT9fvUCQbDfptxZ5V0wbukthW76NSwMnKkaoukFMqODJrxGcw= Received: from BN6PR11MB1667.namprd11.prod.outlook.com (2603:10b6:405:e::12) by BN7PR11MB2674.namprd11.prod.outlook.com (2603:10b6:406:b2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Thu, 27 Aug 2020 07:35:51 +0000 Received: from BN6PR11MB1667.namprd11.prod.outlook.com ([fe80::c75:66f5:d072:746a]) by BN6PR11MB1667.namprd11.prod.outlook.com ([fe80::c75:66f5:d072:746a%12]) with mapi id 15.20.3305.031; Thu, 27 Aug 2020 07:35:51 +0000 From: "Chen, BoX C" To: Owen Hilyard , "dts@dpdk.org" CC: "Zhang, XiX" , "Zhang, XuemingX" , "Ma, LihongX" Thread-Topic: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529 Thread-Index: AQHWe8Enl5joh74DwECO6QraEHPDzKlLkC3A Date: Thu, 27 Aug 2020 07:35:51 +0000 Message-ID: References: <20200826155329.281082-1-ohilyard@iol.unh.edu> In-Reply-To: <20200826155329.281082-1-ohilyard@iol.unh.edu> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: iol.unh.edu; dkim=none (message not signed) header.d=none;iol.unh.edu; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6efeded-e733-4aee-0a35-08d84a5bd2e9 x-ms-traffictypediagnostic: BN7PR11MB2674: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fAz/IB7IiAh1CczsCv2wa8gt+cW4dNqI7m6zA3pDrUHnGp/kztUeQTm5NSRnGTR7U/zArAXTk4T8OleYxPQ7cfcWsBegiE8nk4LKdMm/CTMYHjveCcrSIN9Ykua0hS2OS/WRo8/ISvH7ztjM1QgRtfVuRPlkW29c9FaDQFcV7fluLbCildZqNYKqZim390QvcoWIBtzC1R+vi7q8pU5G4kApvzuevw35VAUm8/aXUnBPmoC8/KHcvwuGGTQmv1tCkoRrW2cqmaUWBY/ZAT7HoLz2WyPaxYekxU51AtCW1dOmJNAYTiT8b+W10lsDFgNTLVVYuwR3p3qdA3U3ZJxBhg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1667.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(2906002)(33656002)(54906003)(110136005)(8936002)(71200400001)(8676002)(86362001)(66446008)(478600001)(6506007)(26005)(5660300002)(186003)(316002)(9686003)(64756008)(4326008)(52536014)(83380400001)(53546011)(66476007)(76116006)(55016002)(7696005)(107886003)(66946007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 682aapBkkDiSyjrMsn9D80HVguxd2WAedZCiq5r+QCUMgFNxja7hwNZelQ4q+OhdC79Qef097Pu+DRqRfY76dtk576YLkY04QcPzxLA+768AS7zvOhJ4qKPlndIXUV7xjoGSASIlmduxjlcmoKX5oP0gFP+IRodzKaEOw4UseBi60mvhlDOeCNjAfVP+zYl19naV6DNz27OI8PWs3Mzc/JLcynhQfhPV7OHnbjiTbDdpbU20K52uphhTxHvkT0gVe5TXunJW4lcqSRNkn+2THVzUhcouk3k9DvNPWfgEnMP3z4NNFyTTOlDwPuFadwddocuewrPKThKFoBfzI0HDl826sPpuGdGSTg2EQHcUwXwRJ6UZSraiUDqxmfpvEympLZGdrXzUW+TAdM7m6Jl8JsW/rYLLfqPgM2OgxRFcMUI4bwUg60pVZIS/rAbwm/dPS0dWUmg9frKVFW7T0Llb8QtkzyTXYSOtmeNz/PJ4FnrjD1imY6q+3JxqLRoQQbM+WdpxoXmRCOXTZ4dMuo7D8jqJDjrfL8tRda3lf40/ne/QHV9kXNUBcrnvSBbpMjeTvYaelYsVtpYES1Jxnvb3pbsQqn8oAYWSeQtAZGNaf/rdsdZ5hKyopK64WvLC+vgaRHZ+FJmc7NG5knuKw6TIhQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1667.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6efeded-e733-4aee-0a35-08d84a5bd2e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2020 07:35:51.2712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fj2SoaRlksUQfVCpiichva3DMnTJDmUGIksoV1xS+nDbMKoHwCL1julAlUGVanZCHiOiL1jXFQg/tv9yLV1svg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2674 X-OriginatorOrg: intel.com Subject: Re: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Tested Failed by: xix.zhang@intel.com There may be two more errors: 1.The Iface here is a function variable, not an Iface defined by scapy. I t= hink you forgot to put quotation marks @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase): def replay_pcap_file_on_tester(self, iface, packet_file_path): self.tester.send_expect("scapy", ">>>") self.scapy_exec(f"packets =3D rdpcap('{packet_file_path}')") - self.scapy_exec(f"sendp(packets, iface=3D{iface})") + self.scapy_exec(f"sendp(packets, iface=3D'{iface}')") self.tester.send_expect("quit()", "# ") =20 2.SyntaxError: invalid syntax(This format should not appear :UDP(chksum=3Dc= hksum=3D0xf)) File "/usr/lib/python3.6/code.py", line 64, in runsource code =3D self.compile(source, filename, symbol) File "/usr/lib/python3.6/codeop.py", line 168, in __call__ return _maybe_compile(self.compiler, source, filename, symbol) File "/usr/lib/python3.6/codeop.py", line 99, in _maybe_compile raise err1 File "/usr/lib/python3.6/codeop.py", line 87, in _maybe_compile code1 =3D compiler(source + "\n", filename, symbol) File "/usr/lib/python3.6/codeop.py", line 133, in __call__ codeob =3D compile(source, filename, symbol, self.flags, 1) File "", line 1 sendp(eth/IP()/UDP(chksum=3D0xf)/VXLAN()/IP()/UDP(chksum=3Dchksum=3D0xf= )/('X'*50), iface=3Diface) > -----Original Message----- > From: dts On Behalf Of Owen Hilyard > Sent: August 26, 2020 23:53 > To: dts@dpdk.org > Cc: Zhang, XiX ; Zhang, XuemingX > ; Ma, LihongX ; Owen > Hilyard > Subject: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529 >=20 > added missing quote in template for scapy packets. >=20 > Signed-off-by: Owen Hilyard > --- > tests/TestSuite_checksum_offload.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index c4a877d..b07ae16 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase): > for l4 in l4_protos: > for chksum in "", "chksum=3D0xf": > vf =3D self.send_pkt_expect_good_bad_from_flag_catch_fai= lure( > - f"eth/IP({chksum})/{l4}()/(X'*50)", > + f"eth/IP({chksum})/{l4}()/('X'*50)", > "PKT_RX_IP_CKSUM_", f"{l4}", > should_pass=3D(chksum =3D=3D "")) > if vf is not None: > -- > 2.25.1